Parse messages.json in ExtensionUnpacker (like we do for manifest) and pass them to sandboxed_extension_unpacker.

Added unittest files for unpacker and sandboxed unpacker.

TEST=Try loading any of the unpacker samples added in this CL. They should either pass, or show error and fail.
BUG=27362

Review URL: http://codereview.chromium.org/390019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32345 0039d316-1c4b-4281-b951-d872f2087c98

24 files changed, 76 insertions, 0 deletions

diff --git a/chrome/test/data/extensions/unpacker/empty_default_locale.crx b/chrome/test/data/extensions/unpacker/empty_default_locale.crx
new file mode 100644
index 0000000..d8f1e0e
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/empty_default_locale.crx
diff --git a/chrome/test/data/extensions/unpacker/empty_default_locale/manifest.json b/chrome/test/data/extensions/unpacker/empty_default_locale/manifest.json
new file mode 100644
index 0000000..6f43cf2
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/empty_default_locale/manifest.json
@@ -0,0 +1,6 @@
+{
+  "description": "Default locale can't be empty",
+  "name": "empty_default_locale",
+  "default_locale": "",
+  "version": "1.0"
+}
diff --git a/chrome/test/data/extensions/unpacker/good_l10n.crx b/chrome/test/data/extensions/unpacker/good_l10n.crx
new file mode 100644
index 0000000..ee56569
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/good_l10n.crx
diff --git a/chrome/test/data/extensions/unpacker/good_l10n/_locales/en_US/messages.json b/chrome/test/data/extensions/unpacker/good_l10n/_locales/en_US/messages.json
new file mode 100644
index 0000000..b5b53c6
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/good_l10n/_locales/en_US/messages.json
@@ -0,0 +1,5 @@
+{
+  "eh": {
+    "message": "this is valid catalog"
+  }
+}
diff --git a/chrome/test/data/extensions/unpacker/good_l10n/_locales/sr/messages.json b/chrome/test/data/extensions/unpacker/good_l10n/_locales/sr/messages.json
new file mode 100644
index 0000000..b5b53c6
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/good_l10n/_locales/sr/messages.json
@@ -0,0 +1,5 @@
+{
+  "eh": {
+    "message": "this is valid catalog"
+  }
+}
diff --git a/chrome/test/data/extensions/unpacker/good_l10n/manifest.json b/chrome/test/data/extensions/unpacker/good_l10n/manifest.json
new file mode 100644
index 0000000..cf2e2a9
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/good_l10n/manifest.json
@@ -0,0 +1,6 @@
+{
+  "description": "All is well",
+  "name": "good_l10n",
+  "default_locale": "sr",
+  "version": "1.0"
+}
diff --git a/chrome/test/data/extensions/unpacker/has_default_missing_locales.crx b/chrome/test/data/extensions/unpacker/has_default_missing_locales.crx
new file mode 100644
index 0000000..8d2808e
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/has_default_missing_locales.crx
diff --git a/chrome/test/data/extensions/unpacker/has_default_missing_locales/manifest.json b/chrome/test/data/extensions/unpacker/has_default_missing_locales/manifest.json
new file mode 100644
index 0000000..e572fc2
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/has_default_missing_locales/manifest.json
@@ -0,0 +1,6 @@
+{
+  "description": "Cannot have default_locale but skip _locales",
+  "name": "has_default_missing_locales",
+  "default_locale": "en_US",
+  "version": "1.0"
+}
diff --git a/chrome/test/data/extensions/unpacker/invalid_default_locale.crx b/chrome/test/data/extensions/unpacker/invalid_default_locale.crx
new file mode 100644
index 0000000..8a426c9
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/invalid_default_locale.crx
diff --git a/chrome/test/data/extensions/unpacker/invalid_default_locale/manifest.json b/chrome/test/data/extensions/unpacker/invalid_default_locale/manifest.json
new file mode 100644
index 0000000..ecf7d82
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/invalid_default_locale/manifest.json
@@ -0,0 +1,6 @@
+{
+  "description": "Default locale has to be string and can't be empty",
+  "name": "invalid_default_locale",
+  "default_locale": 5,
+  "version": "1.0"
+}
diff --git a/chrome/test/data/extensions/unpacker/invalid_messages_file.crx b/chrome/test/data/extensions/unpacker/invalid_messages_file.crx
new file mode 100644
index 0000000..15691d4
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/invalid_messages_file.crx
diff --git a/chrome/test/data/extensions/unpacker/invalid_messages_file/_locales/en_US/messages.json b/chrome/test/data/extensions/unpacker/invalid_messages_file/_locales/en_US/messages.json
new file mode 100644
index 0000000..a992f8f
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/invalid_messages_file/_locales/en_US/messages.json
@@ -0,0 +1,3 @@
+{
+  "eh:
+}
diff --git a/chrome/test/data/extensions/unpacker/invalid_messages_file/manifest.json b/chrome/test/data/extensions/unpacker/invalid_messages_file/manifest.json
new file mode 100644
index 0000000..7a4b9ef
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/invalid_messages_file/manifest.json
@@ -0,0 +1,6 @@
+{
+  "description": "Fail if messages.json is not valid (check JSON syntax only)",
+  "name": "invalid_messages_file",
+  "default_locale": "en_US",
+  "version": "1.0"
+}
diff --git a/chrome/test/data/extensions/unpacker/missing_default_data.crx b/chrome/test/data/extensions/unpacker/missing_default_data.crx
new file mode 100644
index 0000000..eeb76fe
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/missing_default_data.crx
diff --git a/chrome/test/data/extensions/unpacker/missing_default_data/_locales/en_US/messages.json b/chrome/test/data/extensions/unpacker/missing_default_data/_locales/en_US/messages.json
new file mode 100644
index 0000000..b5b53c6
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/missing_default_data/_locales/en_US/messages.json
@@ -0,0 +1,5 @@
+{
+  "eh": {
+    "message": "this is valid catalog"
+  }
+}
diff --git a/chrome/test/data/extensions/unpacker/missing_default_data/manifest.json b/chrome/test/data/extensions/unpacker/missing_default_data/manifest.json
new file mode 100644
index 0000000..03ecc4a
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/missing_default_data/manifest.json
@@ -0,0 +1,6 @@
+{
+  "description": "Data for default_locale has to be present",
+  "name": "missing_default_data",
+  "default_locale": "sr",
+  "version": "1.0"
+}
diff --git a/chrome/test/data/extensions/unpacker/missing_default_has_locales.crx b/chrome/test/data/extensions/unpacker/missing_default_has_locales.crx
new file mode 100644
index 0000000..0bf345d
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/missing_default_has_locales.crx
diff --git a/chrome/test/data/extensions/unpacker/missing_default_has_locales/manifest.json b/chrome/test/data/extensions/unpacker/missing_default_has_locales/manifest.json
new file mode 100644
index 0000000..13a5d4b
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/missing_default_has_locales/manifest.json
@@ -0,0 +1,5 @@
+{
+  "description": "If _locales is present, default_locale has to be defined too.",
+  "name": "missing_default_has_locales",
+  "version": "1.0"
+}
diff --git a/chrome/test/data/extensions/unpacker/missing_messages_file.crx b/chrome/test/data/extensions/unpacker/missing_messages_file.crx
new file mode 100644
index 0000000..4ca3634
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/missing_messages_file.crx
diff --git a/chrome/test/data/extensions/unpacker/missing_messages_file/manifest.json b/chrome/test/data/extensions/unpacker/missing_messages_file/manifest.json
new file mode 100644
index 0000000..a3ccf4b
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/missing_messages_file/manifest.json
@@ -0,0 +1,6 @@
+{
+  "description": "Each locale has to have messages.json file",
+  "name": "missing_messages_file",
+  "default_locale": "en_US",
+  "version": "1.0"
+}
diff --git a/chrome/test/data/extensions/unpacker/no_l10n.crx b/chrome/test/data/extensions/unpacker/no_l10n.crx
new file mode 100644
index 0000000..d9edd9e
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/no_l10n.crx
diff --git a/chrome/test/data/extensions/unpacker/no_l10n/manifest.json b/chrome/test/data/extensions/unpacker/no_l10n/manifest.json
new file mode 100644
index 0000000..8ba809f
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/no_l10n/manifest.json
@@ -0,0 +1,5 @@
+{
+  "description": "This extension is not localized.",
+  "name": "no_l10n",
+  "version": "1.0"
+}
diff --git a/chrome/test/data/extensions/unpacker/no_locale_data.crx b/chrome/test/data/extensions/unpacker/no_locale_data.crx
new file mode 100644
index 0000000..30a8f40
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/no_locale_data.crx
diff --git a/chrome/test/data/extensions/unpacker/no_locale_data/manifest.json b/chrome/test/data/extensions/unpacker/no_locale_data/manifest.json
new file mode 100644
index 0000000..c4d68b4
--- /dev/null
+++ b/chrome/test/data/extensions/unpacker/no_locale_data/manifest.json
@@ -0,0 +1,6 @@
+{
+  "description": "_locales can't be empty",
+  "name": "no_locale_data",
+  "default_locale": "en_US",
+  "version": "1.0"
+}