diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-20 23:06:19 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-20 23:06:19 +0000 |
| commit | 36b9a6ba9d3b3768a1862371ebe9a911ad48d5b1 (patch) | |
| tree | be7491fad42db90898b9b267d43b3d35c44c2d0a /chrome/test | |
| parent | 6c244119e226e5b7e4b17895b69d23bc9c0ef59a (diff) | |
| download | chromium_src-36b9a6ba9d3b3768a1862371ebe9a911ad48d5b1.zip chromium_src-36b9a6ba9d3b3768a1862371ebe9a911ad48d5b1.tar.gz chromium_src-36b9a6ba9d3b3768a1862371ebe9a911ad48d5b1.tar.bz2 | |
Disable the stop button when the user is hovering it and the page finishes loading, so we don't look like we stay loading forever. This change only does this for Mac and Windows, as GTK is going to be trickier.
This also fixes a pair of other bugs on Windows and Linux:
* Because we were setting the timer after telling the browser to reload, and the browser was calling us back synchronously, the timer had no effect.
* Because the timer firing changed modes with |force| set to true, if the page finished loading before the timer fired, the timer would flip the button back to reload.
BUG=46981
TEST=Hover the reload button and hit F5. When the page finishes loading, the stop button should become disabled. Mousing away should change it to an enabled reload button.
Review URL: http://codereview.chromium.org/3198005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56925 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test')
| -rw-r--r-- | chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak | bin | 1185713 -> 1186313 bytes |
1 files changed, 0 insertions, 0 deletions
diff --git a/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak b/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak Binary files differindex 9d8251b..67ea5c6 100644 --- a/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak +++ b/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak |