diff options
| author | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-10 22:58:47 +0000 |
|---|---|---|
| committer | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-10 22:58:47 +0000 |
| commit | 9246de382277a2700c0d1e9f1305591c31a316d0 (patch) | |
| tree | a47efd981eb62d307b81610e0a342aa3a7984de1 /chrome/test | |
| parent | 8f205b08783b5e5c196d2f86b3a86bcc2bc4b5b7 (diff) | |
| download | chromium_src-9246de382277a2700c0d1e9f1305591c31a316d0.zip chromium_src-9246de382277a2700c0d1e9f1305591c31a316d0.tar.gz chromium_src-9246de382277a2700c0d1e9f1305591c31a316d0.tar.bz2 | |
DownloadItem::NeedsRename should not return true for dangerous downloads.
Dangerous downloads always have different target_name from its full_path.BaseName(). Returning true from NeedsRename() wrongly makes DownloadManager::DownloadRenamedToFinalName() to call ContinueDownloadFinished() while it's not finished yet.
Renamed DownloadItem::NeedsRename() to NeedsRenameForSafeDownload() to avoid further confusion.
BUG=62398
TEST=downloads.DownloadsTest.testNoUnsafeDownloadsOnRestart
Review URL: http://codereview.chromium.org/4660007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65721 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test')
| -rw-r--r-- | chrome/test/functional/PYAUTO_TESTS | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/chrome/test/functional/PYAUTO_TESTS b/chrome/test/functional/PYAUTO_TESTS index 91b13bc..5f4d2a1 100644 --- a/chrome/test/functional/PYAUTO_TESTS +++ b/chrome/test/functional/PYAUTO_TESTS @@ -31,8 +31,6 @@ 'cookies', 'crash_reporter', 'downloads', - # crbug.com/62398. Also look in the chromeos section while removing this. - '-downloads.DownloadsTest.testNoUnsafeDownloadsOnRestart', 'find_in_page', # Turkish I problem. crbug.com/60638 '-find_in_page.FindMatchTests.testLocalizationAndCaseOrder', @@ -108,9 +106,7 @@ '-prefs.PrefsTest.testSessionRestoreURLs', '-prefs.PrefsTest.testSessionRestore', '-translate.TranslateTest.testSessionRestore', - # Uncomment the next line when the suppression for bug 62398 (above) - # is removed. - # '-downloads.DownloadsTest.testNoUnsafeDownloadsOnRestart', + '-downloads.DownloadsTest.testNoUnsafeDownloadsOnRestart', '-downloads.DownloadsTest.testZip', '-downloads.DownloadsTest.testZipInIncognito', '-downloads.DownloadsTest.testCrazyFilenames', |