diff options
| author | gbillock@chromium.org <gbillock@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-15 22:33:10 +0000 |
|---|---|---|
| committer | gbillock@chromium.org <gbillock@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-15 22:33:10 +0000 |
| commit | dc65b35c0805d3fd4359f4ed81dae84e08a71253 (patch) | |
| tree | 89aae375ca6de87edc11fb818fdec9dbcad26fed /chrome/test | |
| parent | 943ae7fc7dbc5139e0d40c8b42c8959556f67c06 (diff) | |
| download | chromium_src-dc65b35c0805d3fd4359f4ed81dae84e08a71253.zip chromium_src-dc65b35c0805d3fd4359f4ed81dae84e08a71253.tar.gz chromium_src-dc65b35c0805d3fd4359f4ed81dae84e08a71253.tar.bz2 | |
Remove WaitForNewTab -- replace usage with WindowedNotificationObserver.
R=phajdan.jr@chromium.org
BUG=26948
Review URL: https://chromiumcodereview.appspot.com/11819039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176992 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test')
| -rw-r--r-- | chrome/test/base/ui_test_utils.cc | 7 | ||||
| -rw-r--r-- | chrome/test/base/ui_test_utils.h | 4 |
2 files changed, 0 insertions, 11 deletions
diff --git a/chrome/test/base/ui_test_utils.cc b/chrome/test/base/ui_test_utils.cc index a49b1d1..79de29a 100644 --- a/chrome/test/base/ui_test_utils.cc +++ b/chrome/test/base/ui_test_utils.cc @@ -200,13 +200,6 @@ void WaitForNavigations(NavigationController* controller, content::GetQuitTaskForRunLoop(&run_loop)); } -void WaitForNewTab(Browser* browser) { - content::WindowedNotificationObserver observer( - chrome::NOTIFICATION_TAB_ADDED, - content::Source<content::WebContentsDelegate>(browser)); - observer.Wait(); -} - Browser* WaitForBrowserNotInSet(std::set<Browser*> excluded_browsers) { Browser* new_browser = GetBrowserNotInSet(excluded_browsers); if (new_browser == NULL) { diff --git a/chrome/test/base/ui_test_utils.h b/chrome/test/base/ui_test_utils.h index e08ed7d..6bb7955 100644 --- a/chrome/test/base/ui_test_utils.h +++ b/chrome/test/base/ui_test_utils.h @@ -74,10 +74,6 @@ enum BrowserTestWaitFlags { // Puts the current tab title in |title|. Returns true on success. bool GetCurrentTabTitle(const Browser* browser, string16* title); -// Waits for a new tab to be added to |browser|. TODO(gbillock): remove this -// race hazard. Use WindowedNotificationObserver instead. -void WaitForNewTab(Browser* browser); - // Opens |url| in an incognito browser window with the incognito profile of // |profile|, blocking until the navigation finishes. This will create a new // browser if a browser with the incognito profile does not exist. Returns the |