diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-23 22:27:10 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-23 22:27:10 +0000 |
| commit | c53add011c152049587f9d3f78158b87b93692ad (patch) | |
| tree | a907701e51725f7fece571fd6ae2c670c0b74439 /chrome/tools/build | |
| parent | c753026b2ba6a722bd6c90505cabb91ab4873d86 (diff) | |
| download | chromium_src-c53add011c152049587f9d3f78158b87b93692ad.zip chromium_src-c53add011c152049587f9d3f78158b87b93692ad.tar.gz chromium_src-c53add011c152049587f9d3f78158b87b93692ad.tar.bz2 | |
Minor code issues found by Clang.
Mostly that "extern const ... = ...;" is not legal.
You need two lines to make a non-static const declaration.
Review URL: http://codereview.chromium.org/1739005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45502 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/tools/build')
| -rwxr-xr-x | chrome/tools/build/make_version_cc.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/tools/build/make_version_cc.py b/chrome/tools/build/make_version_cc.py index 2797595..d25d8d4 100755 --- a/chrome/tools/build/make_version_cc.py +++ b/chrome/tools/build/make_version_cc.py @@ -18,9 +18,11 @@ def main(me, args): contents = '''// automatically generated by %s +#include "chrome/common/chrome_constants.h" + namespace chrome { -extern const char kChromeVersion[] = "%s"; +const char kChromeVersion[] = "%s"; } // namespace chrome ''' % (me, version) |