diff options
| author | bartfab@chromium.org <bartfab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-04 19:24:44 +0000 |
|---|---|---|
| committer | bartfab@chromium.org <bartfab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-04 19:24:44 +0000 |
| commit | 6481d32aee16215aba7eae70ff71be264f50a934 (patch) | |
| tree | 8a4928e5fafc58533c4992cb793636bec73d3e82 /chrome/tools/extract_actions.py | |
| parent | bd0c591f6a62347533eeb0d4eb29b2f376239272 (diff) | |
| download | chromium_src-6481d32aee16215aba7eae70ff71be264f50a934.zip chromium_src-6481d32aee16215aba7eae70ff71be264f50a934.tar.gz chromium_src-6481d32aee16215aba7eae70ff71be264f50a934.tar.bz2 | |
Clean up copy-and-pasted code in prefs UI classes
This CL makes all prefs UI classes inherit from a common ancestor,
consolidating previously copy-and-pasted code. As an additional cleanup,
support for checkboxes controlling a non-Boolean pref is retired as no
such checkboxes exist in Chrome's code.
BUG=104955
Review URL: https://chromiumcodereview.appspot.com/10908061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154793 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/tools/extract_actions.py')
| -rwxr-xr-x | chrome/tools/extract_actions.py | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/chrome/tools/extract_actions.py b/chrome/tools/extract_actions.py index 1a6c8c1..c040ef2 100755 --- a/chrome/tools/extract_actions.py +++ b/chrome/tools/extract_actions.py @@ -284,10 +284,7 @@ class WebUIActionsParser(HTMLParser): is_boolean = ('dataType' in attrs and attrs['dataType'] == 'boolean') if 'type' in attrs and attrs['type'] in ('checkbox', 'radio'): if attrs['type'] == 'checkbox': - # Checkboxes are boolean by default. However, their 'value-type' can - # instead be set to 'integer'. - if 'value-type' not in attrs or attrs['value-type'] in ['', 'boolean']: - is_boolean = True + is_boolean = True else: # Radio buttons are boolean if and only if their values are 'true' or # 'false'. |