diff options
author | maruel@google.com <maruel@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-10 17:39:46 +0000 |
---|---|---|
committer | maruel@google.com <maruel@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-10 17:39:46 +0000 |
commit | 72d1e597c85fbf6b45756e3c753696370c48c042 (patch) | |
tree | d01609d62295e34aa3a5721d4109f815d0fd23ad /chrome/tools | |
parent | 9475d1d189c03a0626c4855b38f6004bfe7c5bb8 (diff) | |
download | chromium_src-72d1e597c85fbf6b45756e3c753696370c48c042.zip chromium_src-72d1e597c85fbf6b45756e3c753696370c48c042.tar.gz chromium_src-72d1e597c85fbf6b45756e3c753696370c48c042.tar.bz2 |
Slight code change to make some global variables const.
Fix >80 cols lines.
Review URL: http://codereview.chromium.org/42013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11342 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/tools')
-rwxr-xr-x | chrome/tools/build/win/dependencies.py | 12 | ||||
-rw-r--r-- | chrome/tools/crash_service/crash_service.h | 7 | ||||
-rw-r--r-- | chrome/tools/profiles/generate_profile.cc | 4 |
3 files changed, 12 insertions, 11 deletions
diff --git a/chrome/tools/build/win/dependencies.py b/chrome/tools/build/win/dependencies.py index 06ce64c..353c89c 100755 --- a/chrome/tools/build/win/dependencies.py +++ b/chrome/tools/build/win/dependencies.py @@ -157,11 +157,12 @@ def VerifyDependents(pe_name, dependents, delay_loaded, list_file, verbose): except: raise Error("Failed to load " + list_file) - # The dependency files have dependencies in two section - dependents and delay_loaded - # Also various distributions of Chromium can have different dependencies. So first - # we read generic dependencies ("dependents" and "delay_loaded"). If distribution - # specific dependencies exist (i.e. "dependents_google_chrome" and - # "delay_loaded_google_chrome") we use those instead. + # The dependency files have dependencies in two section - dependents and + # delay_loaded. Also various distributions of Chromium can have different + # dependencies. So first we read generic dependencies ("dependents" and + # "delay_loaded"). If distribution specific dependencies exist + # (i.e. "dependents_google_chrome" and "delay_loaded_google_chrome") we use + # those instead. distribution = DIST_DEFAULT if DIST_ENV_VAR in os.environ.keys(): distribution = os.environ[DIST_ENV_VAR].lower() @@ -222,4 +223,3 @@ if '__main__' == __name__: if len(args) != 2: option_parser.error("Incorrect number of arguments") sys.exit(main(options, args)) - diff --git a/chrome/tools/crash_service/crash_service.h b/chrome/tools/crash_service/crash_service.h index 0edee38..0c022bd 100644 --- a/chrome/tools/crash_service/crash_service.h +++ b/chrome/tools/crash_service/crash_service.h @@ -80,9 +80,10 @@ class CrashService { static void OnClientConnected(void* context, const google_breakpad::ClientInfo* client_info); - static void OnClientDumpRequest(void* context, - const google_breakpad::ClientInfo* client_info, - const std::wstring* file_path); + static void OnClientDumpRequest( + void* context, + const google_breakpad::ClientInfo* client_info, + const std::wstring* file_path); static void OnClientExited(void* context, const google_breakpad::ClientInfo* client_info); diff --git a/chrome/tools/profiles/generate_profile.cc b/chrome/tools/profiles/generate_profile.cc index 6e99e45..bd75b31 100644 --- a/chrome/tools/profiles/generate_profile.cc +++ b/chrome/tools/profiles/generate_profile.cc @@ -120,8 +120,8 @@ void InsertURLBatch(const std::wstring& profile_dir, int page_id, PageTransition::Type transition = PageTransition::TYPED; const int end_page_id = page_id + batch_size; for (; page_id < end_page_id; ++page_id) { - // Randomly decide whether this new URL simulates following a link or whether - // it's a jump to a new URL. + // Randomly decide whether this new URL simulates following a link or + // whether it's a jump to a new URL. if (!previous_url.is_empty() && RandomFloat() < kFollowLinkProbability) { transition = PageTransition::LINK; } else { |