diff options
| author | sebmarchand@chromium.org <sebmarchand@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-16 23:15:31 +0000 |
|---|---|---|
| committer | sebmarchand@chromium.org <sebmarchand@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-16 23:15:31 +0000 |
| commit | f88026d7354af316b74475f60c7674b1491a8d4d (patch) | |
| tree | d52fffa4aba43763a2d4a1065e39d3e05fba4ee9 /chrome/tools | |
| parent | 755d7ae3e1c8b54c4430783e96843130975f446f (diff) | |
| download | chromium_src-f88026d7354af316b74475f60c7674b1491a8d4d.zip chromium_src-f88026d7354af316b74475f60c7674b1491a8d4d.tar.gz chromium_src-f88026d7354af316b74475f60c7674b1491a8d4d.tar.bz2 | |
Don't augment the PDB for the SyzyASan builds.
The 'no-augment-pdb' flag indicates that the relinker should not augment the PDB with roundtrip decomposition info... Those info are needed in order to be able to profile an syzygy-optimized build, but there's no real point in profiling a SyzyASan build... Also it make the pdb growth by ~20%, and this get us really close (and sometime over) to a 1GB pdb, which you can't use for debugging with the current version of our binaries... This has been fixed in our codebase, but until we've pushed some new binaries we shouldn't augment the pdb if we want to be able to debug the instrumented builds.
R=chrisha@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/23245005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218114 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/tools')
| -rwxr-xr-x | chrome/tools/build/win/syzygy_instrument.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/tools/build/win/syzygy_instrument.py b/chrome/tools/build/win/syzygy_instrument.py index 2454da7..75eaf2d 100755 --- a/chrome/tools/build/win/syzygy_instrument.py +++ b/chrome/tools/build/win/syzygy_instrument.py @@ -78,6 +78,9 @@ def _InstrumentBinary(syzygy_dir, mode, executable, symbol, dst_dir, '--output-pdb=%s' % os.path.abspath( os.path.join(dst_dir, os.path.basename(symbol)))] + if mode == "asan": + cmd.append('--no-augment-pdb') + # If a filter was specified then pass it on to the instrumenter. if filter_file: cmd.append('--filter=%s' % os.path.abspath(filter_file)) |