diff options
| author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-06 19:19:05 +0000 |
|---|---|---|
| committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-06 19:19:05 +0000 |
| commit | 7237402696b827997b0a1a340a44bdc994ed1403 (patch) | |
| tree | 48e488b07cc79ccd3d218647dc4b5a0bcf92280d /chrome/views/dialog_client_view.cc | |
| parent | 5fd3aa4f25bb6c56dcd3069e98cf8f97c709bead (diff) | |
| download | chromium_src-7237402696b827997b0a1a340a44bdc994ed1403.zip chromium_src-7237402696b827997b0a1a340a44bdc994ed1403.tar.gz chromium_src-7237402696b827997b0a1a340a44bdc994ed1403.tar.bz2 | |
Test to see if we can reduce some crashes by deferring delegate destruction until WM_NCDESTROY. This involves adding a specific method to allow delegates to destroy themselves to WindowDelegate, and moving all delete this calls into implementations of that method (to allow delegates to still respond to WM_DESTROY which is legit).
Review URL: http://codereview.chromium.org/40192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11132 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/views/dialog_client_view.cc')
| -rw-r--r-- | chrome/views/dialog_client_view.cc | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/chrome/views/dialog_client_view.cc b/chrome/views/dialog_client_view.cc index 6a9977a..c32b17c 100644 --- a/chrome/views/dialog_client_view.cc +++ b/chrome/views/dialog_client_view.cc @@ -309,11 +309,6 @@ bool DialogClientView::AcceleratorPressed(const Accelerator& accelerator) { // DialogClientView, NativeButton::Listener implementation: void DialogClientView::ButtonPressed(NativeButton* sender) { - // We NULL check the delegate here since the buttons can receive WM_COMMAND - // messages even after they (and the window containing us) are destroyed. - if (!GetDialogDelegate()) - return; - if (sender == ok_button_) { AcceptWindow(); } else if (sender == cancel_button_) { |