diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-31 22:19:43 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-31 22:19:43 +0000 |
| commit | 9c8108d9356604eec57bf3c880f1580eb41fd1c3 (patch) | |
| tree | 57c45ff318a11d96f6604906c326ba9fe531c6c4 /chrome/views/message_box_view.h | |
| parent | 2346f78737731d1c4456a950b2e5123ea6f33fbc (diff) | |
| download | chromium_src-9c8108d9356604eec57bf3c880f1580eb41fd1c3.zip chromium_src-9c8108d9356604eec57bf3c880f1580eb41fd1c3.tar.gz chromium_src-9c8108d9356604eec57bf3c880f1580eb41fd1c3.tar.bz2 | |
Some code in MessageBoxView was focusing the first focusable element in the view, overidding the focus set from the DialogDelegate.
We now only rely on the dialog delegate.
Also changed dialog delegate so the default button is also the focused button.
BUG=98
TEST=Open a javascript alert then confirm dialog. A button should be focused. Open all dialogs in Chrome. A button should be focused by default.
Review URL: http://codereview.chromium.org/8786
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4334 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/views/message_box_view.h')
| -rw-r--r-- | chrome/views/message_box_view.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/chrome/views/message_box_view.h b/chrome/views/message_box_view.h index a15fa89..6ca5932 100644 --- a/chrome/views/message_box_view.h +++ b/chrome/views/message_box_view.h @@ -66,10 +66,6 @@ class MessageBoxView : public views::View { views::View* child); private: - // Called after ViewHierarchyChanged's call stack unwinds and returns to the - // message loop to focus the first focusable element in the dialog box. - void FocusFirstFocusableControl(); - // Sets up the layout manager and initializes the prompt field. This should // only be called once, from the constructor. void Init(int dialog_flags, const std::wstring& default_prompt); |