diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-27 22:02:15 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-27 22:02:15 +0000 |
| commit | 29e75de051f2dfb32e896b359e605e869f9db04e (patch) | |
| tree | 0e9a5a076c15ad22ca21d20ce9c15e4c78bc49e5 /chrome/views/non_client_view.h | |
| parent | 2beee8cce00b9e927917a0716b449379aba21cff (diff) | |
| download | chromium_src-29e75de051f2dfb32e896b359e605e869f9db04e.zip chromium_src-29e75de051f2dfb32e896b359e605e869f9db04e.tar.gz chromium_src-29e75de051f2dfb32e896b359e605e869f9db04e.tar.bz2 | |
Fix 8200: Pressing Esc should cancel dialogs, not commit.
When we create the OK & Cancel dialog buttons in
DialogClientView, we were registering OK as a handler
for Escape, even though the dialog had a Cancel button.
This is because we register for Esc if the member variable
|cancel_ button_| is NULL. Problem is, that member isn't
created until later on in that function.
We should be checking the |buttons| flags instead.
TEST=Open the Clear Browsing Data dialog, press Tab twice,
press Esc and make sure that the dialog closes and nothing
is cleared (from whatever checkbox was selected).
BUG=8200
Review URL: http://codereview.chromium.org/28267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10631 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/views/non_client_view.h')
0 files changed, 0 insertions, 0 deletions