Fixing a few minor issues found during static analysis of the Chromium codebase.

find_bar_controller.cc:

Unused local variable created.

hwnd_view.cc:

The local definition of parent overshadows param passed in.

google_update.cc:

Uninitialized member variable.

webframe_impl.cc:

The if was overly constrained. At the top of the function there is an if (reset) { ... return; } so we don't need to check for !reset in the next if statement. This functionality is covered by a ui_test, which passes with this change.

Review URL: http://codereview.chromium.org/42321

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11964 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 3 insertions, 3 deletions

diff --git a/chrome/views/controls/hwnd_view.cc b/chrome/views/controls/hwnd_view.cc
index a376c8b..cc9df6d 100644
--- a/chrome/views/controls/hwnd_view.cc
+++ b/chrome/views/controls/hwnd_view.cc
@@ -127,7 +127,7 @@ void HWNDView::UpdateHWNDBounds() {
     // it.
     ::SetWindowPos(hwnd_, 0, 0, 0, 0, 0,
                    SWP_HIDEWINDOW | SWP_NOSIZE | SWP_NOMOVE | SWP_NOZORDER |
-                   SWP_NOREDRAW | SWP_NOOWNERZORDER );
+                   SWP_NOREDRAW | SWP_NOOWNERZORDER);
   }
 }
 
@@ -150,9 +150,9 @@ void HWNDView::ViewHierarchyChanged(bool is_add, View *parent, View *child) {
   if (hwnd_) {
     Widget* widget = GetWidget();
     if (is_add && widget) {
-      HWND parent = ::GetParent(hwnd_);
+      HWND parent_hwnd = ::GetParent(hwnd_);
       HWND widget_hwnd = widget->GetNativeView();
-      if (parent != widget_hwnd) {
+      if (parent_hwnd != widget_hwnd) {
         ::SetParent(hwnd_, widget_hwnd);
       }
       if (IsVisibleInRootView())