diff options
| author | mad@chromium.org <mad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-12 14:46:17 +0000 |
|---|---|---|
| committer | mad@chromium.org <mad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-12 14:46:17 +0000 |
| commit | f21c613a0ab52b707f8a2effacda74c77f4448ea (patch) | |
| tree | 09051d286db764a71b97bc01f35765e607b4d20f /chrome/views | |
| parent | 822cfc93fe52974b904b7f184c5448dee5d281c5 (diff) | |
| download | chromium_src-f21c613a0ab52b707f8a2effacda74c77f4448ea.zip chromium_src-f21c613a0ab52b707f8a2effacda74c77f4448ea.tar.gz chromium_src-f21c613a0ab52b707f8a2effacda74c77f4448ea.tar.bz2 | |
This is an attempt at finding the reason for the page_cycler slowness caused by
the new resize corner. Local experiment led me to believe that it is WebKit
that is slower when we specify a resize corner area.
To validate this hypothesis, I always return an empty rect to WebKit, but I
still compute and push the rect to the render widget and I also draw the bitmap
even if this will cause it to be drawn on top of the scroll bars when there is
only one.
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9654 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/views')
| -rw-r--r-- | chrome/views/resize_corner.cc | 33 | ||||
| -rw-r--r-- | chrome/views/resize_corner.h | 28 | ||||
| -rw-r--r-- | chrome/views/views.vcproj | 8 |
3 files changed, 0 insertions, 69 deletions
diff --git a/chrome/views/resize_corner.cc b/chrome/views/resize_corner.cc deleted file mode 100644 index 97925ca..0000000 --- a/chrome/views/resize_corner.cc +++ /dev/null @@ -1,33 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "chrome/views/resize_corner.h" - -#include <vssym32.h> - -#include "base/gfx/native_theme.h" -#include "chrome/common/gfx/chrome_canvas.h" - -namespace views { - -ResizeCorner::ResizeCorner() { -} - -ResizeCorner::~ResizeCorner() { -} - -void ResizeCorner::Paint(ChromeCanvas* canvas) { - // Paint the little handle. - RECT widgetRect = { 0, 0, width(), height() }; - HDC hdc = canvas->beginPlatformPaint(); - gfx::NativeTheme::instance()->PaintStatusGripper(hdc, - SP_GRIPPER, - 0, - 0, - &widgetRect); - canvas->endPlatformPaint(); -} - -} // namespace views - diff --git a/chrome/views/resize_corner.h b/chrome/views/resize_corner.h deleted file mode 100644 index ed02216..0000000 --- a/chrome/views/resize_corner.h +++ /dev/null @@ -1,28 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef CHROME_VIEWS_RESIZE_CORNER_H__ -#define CHROME_VIEWS_RESIZE_CORNER_H__ - -#include "chrome/views/view.h" - -namespace views { - -// Simple drawing of a resize corner. Has no functionality. -class ResizeCorner : public View { - public: - ResizeCorner(); - virtual ~ResizeCorner(); - - // View - virtual void Paint(ChromeCanvas* canvas); - - private: - DISALLOW_EVIL_CONSTRUCTORS(ResizeCorner); -}; - -} // namespace views - -#endif // CHROME_VIEWS_RESIZE_CORNER_H__ - diff --git a/chrome/views/views.vcproj b/chrome/views/views.vcproj index 6d5ce3d..9656303 100644 --- a/chrome/views/views.vcproj +++ b/chrome/views/views.vcproj @@ -466,14 +466,6 @@ > </File> <File - RelativePath=".\resize_corner.cc" - > - </File> - <File - RelativePath=".\resize_corner.h" - > - </File> - <File RelativePath=".\root_view.cc" > </File> |
