Make the omnibox popup look nicer. Add dropshadow images (not final). Experiment with some effects.

Adds a positioner interface that allows the popup to size itself to the width of the edit view + the width of the star and go buttons. (Basically the toolbar needs to help the popup position itself).

No results yet!

Review URL: http://codereview.chromium.org/68011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13784 0039d316-1c4b-4281-b951-d872f2087c98

5 files changed, 10 insertions, 10 deletions

diff --git a/chrome/views/widget/widget.h b/chrome/views/widget/widget.h
index d1d0fff..40b153e 100644
--- a/chrome/views/widget/widget.h
+++ b/chrome/views/widget/widget.h
@@ -58,10 +58,10 @@ class Widget {
   virtual RootView* GetRootView() = 0;
 
   // Returns whether the Widget is visible to the user.
-  virtual bool IsVisible() = 0;
+  virtual bool IsVisible() const = 0;
 
   // Returns whether the Widget is the currently active window.
-  virtual bool IsActive() = 0;
+  virtual bool IsActive() const = 0;
 
   // Returns the TooltipManager for this Widget. If this Widget does not support
   // tooltips, NULL is returned.
diff --git a/chrome/views/widget/widget_gtk.cc b/chrome/views/widget/widget_gtk.cc
index 9356c85..3e51d77 100644
--- a/chrome/views/widget/widget_gtk.cc
+++ b/chrome/views/widget/widget_gtk.cc
@@ -145,11 +145,11 @@ RootView* WidgetGtk::GetRootView() {
   return root_view_.get();
 }
 
-bool WidgetGtk::IsVisible() {
+bool WidgetGtk::IsVisible() const {
   return GTK_WIDGET_VISIBLE(widget_);
 }
 
-bool WidgetGtk::IsActive() {
+bool WidgetGtk::IsActive() const {
   NOTIMPLEMENTED();
   return false;
 }
diff --git a/chrome/views/widget/widget_gtk.h b/chrome/views/widget/widget_gtk.h
index 9f3c813..aedac31 100644
--- a/chrome/views/widget/widget_gtk.h
+++ b/chrome/views/widget/widget_gtk.h
@@ -41,8 +41,8 @@ class WidgetGtk : public Widget {
   virtual gfx::NativeView GetNativeView() const;
   virtual void PaintNow(const gfx::Rect& update_rect);
   virtual RootView* GetRootView();
-  virtual bool IsVisible();
-  virtual bool IsActive();
+  virtual bool IsVisible() const;
+  virtual bool IsActive() const;
   virtual TooltipManager* GetTooltipManager();
   virtual bool GetAccelerator(int cmd_id, Accelerator* accelerator);
 
diff --git a/chrome/views/widget/widget_win.cc b/chrome/views/widget/widget_win.cc
index 7f64aea..ddf8db8 100644
--- a/chrome/views/widget/widget_win.cc
+++ b/chrome/views/widget/widget_win.cc
@@ -300,11 +300,11 @@ RootView* WidgetWin::GetRootView() {
   return root_view_.get();
 }
 
-bool WidgetWin::IsVisible() {
+bool WidgetWin::IsVisible() const {
   return !!::IsWindowVisible(GetNativeView());
 }
 
-bool WidgetWin::IsActive() {
+bool WidgetWin::IsActive() const {
   return win_util::IsWindowActive(GetNativeView());
 }
 
diff --git a/chrome/views/widget/widget_win.h b/chrome/views/widget/widget_win.h
index ce78103..264e9f9 100644
--- a/chrome/views/widget/widget_win.h
+++ b/chrome/views/widget/widget_win.h
@@ -234,8 +234,8 @@ class WidgetWin : public Widget,
   virtual gfx::NativeView GetNativeView() const;
   virtual void PaintNow(const gfx::Rect& update_rect);
   virtual RootView* GetRootView();
-  virtual bool IsVisible();
-  virtual bool IsActive();
+  virtual bool IsVisible() const;
+  virtual bool IsActive() const;
   virtual TooltipManager* GetTooltipManager();
 
   // Overridden from MessageLoop::Observer: