diff options
author | atwilson@chromium.org <atwilson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-05 06:29:08 +0000 |
---|---|---|
committer | atwilson@chromium.org <atwilson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-05 06:29:08 +0000 |
commit | bec1ed112990143fe30b6cae4624fdde3015efce (patch) | |
tree | 24ca36e4bc748f6a872decfaccd7f41cac60c4b3 /chrome/worker/webworkerclient_proxy.cc | |
parent | c38a0c74b4a29e6eecb99babf7c98045f05c1c56 (diff) | |
download | chromium_src-bec1ed112990143fe30b6cae4624fdde3015efce.zip chromium_src-bec1ed112990143fe30b6cae4624fdde3015efce.tar.gz chromium_src-bec1ed112990143fe30b6cae4624fdde3015efce.tar.bz2 |
Added beginnings of browser-process support for shared workers.
Refactored WebWorkerClientProxy into two classes - WebWorkerDispatcher which dispatches incoming IPCs for the worker, and WebWorkerClientProxy, which handles outgoing API calls from WebWorkerImpl. This allows WebWorkerClientProxy to be reused by WebSharedWorkerDispatcher.
BUG=26233
TEST=none (will enable layout tests when basic functionality available)
Review URL: http://codereview.chromium.org/351004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31077 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/worker/webworkerclient_proxy.cc')
-rw-r--r-- | chrome/worker/webworkerclient_proxy.cc | 76 |
1 files changed, 9 insertions, 67 deletions
diff --git a/chrome/worker/webworkerclient_proxy.cc b/chrome/worker/webworkerclient_proxy.cc index 9fe0870..baff23c 100644 --- a/chrome/worker/webworkerclient_proxy.cc +++ b/chrome/worker/webworkerclient_proxy.cc @@ -5,13 +5,12 @@ #include "chrome/worker/webworkerclient_proxy.h" #include "base/command_line.h" -#include "chrome/common/child_process.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/webmessageportchannel_impl.h" #include "chrome/common/worker_messages.h" #include "chrome/renderer/webworker_proxy.h" +#include "chrome/worker/webworker_stub_base.h" #include "chrome/worker/worker_thread.h" -#include "chrome/worker/nativewebworker_impl.h" #include "ipc/ipc_logging.h" #include "webkit/api/public/WebString.h" #include "webkit/api/public/WebURL.h" @@ -26,43 +25,14 @@ using WebKit::WebWorkerClient; // How long to wait for worker to finish after it's been told to terminate. #define kMaxTimeForRunawayWorkerMs 3000 -static bool UrlIsNativeWorker(const GURL& url) { - // If the renderer was not passed the switch to enable native workers, - // then the URL should be treated as a JavaScript worker. - if (!CommandLine::ForCurrentProcess()->HasSwitch( - switches::kEnableNativeWebWorkers)) { - return false; - } - // Based on the suffix, decide whether the url should be considered - // a NativeWebWorker (for .nexe) or a WebWorker (for anything else). - const std::string kNativeSuffix(".nexe"); - std::string worker_url = url.path(); - // Compute the start index of the suffix. - std::string::size_type suffix_index = - worker_url.length() - kNativeSuffix.length(); - std::string::size_type pos = worker_url.find(kNativeSuffix, suffix_index); - return (suffix_index == pos); -} - -WebWorkerClientProxy::WebWorkerClientProxy(const GURL& url, int route_id) - : url_(url), - route_id_(route_id), +WebWorkerClientProxy::WebWorkerClientProxy(int route_id, + WebWorkerStubBase* stub) + : route_id_(route_id), + stub_(stub), ALLOW_THIS_IN_INITIALIZER_LIST(kill_process_factory_(this)) { - if (UrlIsNativeWorker(url)) { - // Launch a native worker. - impl_ = NativeWebWorkerImpl::create(this); - } else { - // Launch a JavaScript worker. - impl_ = WebWorker::create(this); - } - WorkerThread::current()->AddRoute(route_id_, this); - ChildProcess::current()->AddRefProcess(); } WebWorkerClientProxy::~WebWorkerClientProxy() { - impl_->clientDestroyed(); - WorkerThread::current()->RemoveRoute(route_id_); - ChildProcess::current()->ReleaseProcess(); } void WebWorkerClientProxy::postMessageToWorkerObject( @@ -123,8 +93,9 @@ void WebWorkerClientProxy::reportPendingActivity(bool has_pending_activity) { void WebWorkerClientProxy::workerContextDestroyed() { Send(new WorkerHostMsg_WorkerContextDestroyed(route_id_)); - - delete this; + // Tell the stub that the worker has shutdown - frees this object. + if (stub_) + stub_->Shutdown(); } WebKit::WebWorker* WebWorkerClientProxy::createWorker( @@ -136,24 +107,7 @@ bool WebWorkerClientProxy::Send(IPC::Message* message) { return WorkerThread::current()->Send(message); } -void WebWorkerClientProxy::OnMessageReceived(const IPC::Message& message) { - if (!impl_) - return; - - IPC_BEGIN_MESSAGE_MAP(WebWorkerClientProxy, message) - IPC_MESSAGE_FORWARD(WorkerMsg_StartWorkerContext, impl_, - WebWorker::startWorkerContext) - IPC_MESSAGE_HANDLER(WorkerMsg_TerminateWorkerContext, - OnTerminateWorkerContext) - IPC_MESSAGE_HANDLER(WorkerMsg_PostMessage, OnPostMessage) - IPC_MESSAGE_FORWARD(WorkerMsg_WorkerObjectDestroyed, impl_, - WebWorker::workerObjectDestroyed) - IPC_END_MESSAGE_MAP() -} - -void WebWorkerClientProxy::OnTerminateWorkerContext() { - impl_->terminateWorkerContext(); - +void WebWorkerClientProxy::EnsureWorkerContextTerminates() { // Avoid a worker doing a while(1) from never exiting. if (CommandLine::ForCurrentProcess()->HasSwitch( switches::kWebWorkerShareProcesses)) { @@ -172,15 +126,3 @@ void WebWorkerClientProxy::OnTerminateWorkerContext() { kMaxTimeForRunawayWorkerMs); } -void WebWorkerClientProxy::OnPostMessage( - const string16& message, - const std::vector<int>& sent_message_port_ids, - const std::vector<int>& new_routing_ids) { - WebMessagePortChannelArray channels(sent_message_port_ids.size()); - for (size_t i = 0; i < sent_message_port_ids.size(); i++) { - channels[i] = new WebMessagePortChannelImpl( - new_routing_ids[i], sent_message_port_ids[i]); - } - - impl_->postMessageToWorkerContext(message, channels); -} |