diff options
author | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-08 20:06:33 +0000 |
---|---|---|
committer | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-08 20:06:33 +0000 |
commit | 1132436ee7d63e3f6391a3b4982c06e760fc5ca7 (patch) | |
tree | 3cfad32f35597bdd7b8d1ee0068f16e82cfc3586 /chrome | |
parent | b6f2b3d611de57b44f47be6a3d4c56bd7cd7a54a (diff) | |
download | chromium_src-1132436ee7d63e3f6391a3b4982c06e760fc5ca7.zip chromium_src-1132436ee7d63e3f6391a3b4982c06e760fc5ca7.tar.gz chromium_src-1132436ee7d63e3f6391a3b4982c06e760fc5ca7.tar.bz2 |
Remove more unneeded scaffolding.
Review URL: http://codereview.chromium.org/63129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13376 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r-- | chrome/browser/bookmarks/bookmark_utils.cc | 2 | ||||
-rw-r--r-- | chrome/browser/browser_shutdown.cc | 8 | ||||
-rw-r--r-- | chrome/browser/chrome_plugin_host.cc | 6 | ||||
-rw-r--r-- | chrome/browser/download/save_file_manager.cc | 7 | ||||
-rw-r--r-- | chrome/browser/navigation_controller_unittest.cc | 10 | ||||
-rw-r--r-- | chrome/browser/profile.cc | 13 | ||||
-rw-r--r-- | chrome/browser/profile_manager.cc | 6 | ||||
-rw-r--r-- | chrome/browser/renderer_host/resource_message_filter.h | 3 | ||||
-rw-r--r-- | chrome/browser/renderer_host/resource_request_details.h | 8 | ||||
-rw-r--r-- | chrome/browser/ssl/ssl_manager.cc | 4 | ||||
-rw-r--r-- | chrome/browser/ssl/ssl_policy.cc | 7 | ||||
-rw-r--r-- | chrome/browser/tab_contents/tab_contents_factory.cc | 5 | ||||
-rw-r--r-- | chrome/browser/tab_contents/web_contents.cc | 4 | ||||
-rw-r--r-- | chrome/common/temp_scaffolding_stubs.h | 11 | ||||
-rw-r--r-- | chrome/test/testing_profile.h | 11 |
15 files changed, 14 insertions, 91 deletions
diff --git a/chrome/browser/bookmarks/bookmark_utils.cc b/chrome/browser/bookmarks/bookmark_utils.cc index c210dad..cb36eee 100644 --- a/chrome/browser/bookmarks/bookmark_utils.cc +++ b/chrome/browser/bookmarks/bookmark_utils.cc @@ -14,6 +14,7 @@ #include "chrome/browser/history/query_parser.h" #include "chrome/browser/profile.h" #include "chrome/browser/tab_contents/page_navigator.h" +#include "chrome/browser/tab_contents/tab_contents.h" #include "chrome/common/drag_drop_types.h" #include "chrome/common/l10n_util.h" #include "chrome/common/notification_service.h" @@ -26,7 +27,6 @@ // TODO(port): Port these files. #if defined(OS_WIN) -#include "chrome/browser/tab_contents/tab_contents.h" #include "chrome/common/os_exchange_data.h" #else #include "chrome/common/temp_scaffolding_stubs.h" diff --git a/chrome/browser/browser_shutdown.cc b/chrome/browser/browser_shutdown.cc index 23aa42d..6c2e0fb 100644 --- a/chrome/browser/browser_shutdown.cc +++ b/chrome/browser/browser_shutdown.cc @@ -16,6 +16,7 @@ #include "chrome/browser/first_run.h" #include "chrome/browser/jankometer.h" #include "chrome/browser/metrics/metrics_service.h" +#include "chrome/browser/plugin_process_host.h" #include "chrome/browser/renderer_host/render_process_host.h" #include "chrome/browser/renderer_host/render_view_host.h" #include "chrome/browser/renderer_host/render_widget_host.h" @@ -27,13 +28,6 @@ #include "chrome/common/resource_bundle.h" #include "net/dns_global.h" -// TODO(port): Get rid of this section and finish porting. -#if defined(OS_WIN) -#include "chrome/browser/plugin_process_host.h" -#else -#include "chrome/common/temp_scaffolding_stubs.h" -#endif - using base::Time; using base::TimeDelta; diff --git a/chrome/browser/chrome_plugin_host.cc b/chrome/browser/chrome_plugin_host.cc index 4548a48..72a7309 100644 --- a/chrome/browser/chrome_plugin_host.cc +++ b/chrome/browser/chrome_plugin_host.cc @@ -43,12 +43,6 @@ #include "net/url_request/url_request_error_job.h" #include "skia/include/SkBitmap.h" -// TODO(port): Port these files. -#if defined(OS_WIN) -#include "chrome/browser/dom_ui/html_dialog_ui.h" -#else -#include "chrome/common/temp_scaffolding_stubs.h" -#endif using base::TimeDelta; diff --git a/chrome/browser/download/save_file_manager.cc b/chrome/browser/download/save_file_manager.cc index 9e8e885..4d1b2ad 100644 --- a/chrome/browser/download/save_file_manager.cc +++ b/chrome/browser/download/save_file_manager.cc @@ -14,6 +14,7 @@ #include "chrome/browser/download/save_file.h" #include "chrome/browser/download/save_package.h" #include "chrome/browser/renderer_host/resource_dispatcher_host.h" +#include "chrome/browser/tab_contents/tab_contents.h" #include "chrome/browser/tab_contents/tab_util.h" #include "chrome/browser/tab_contents/web_contents.h" #include "chrome/common/chrome_paths.h" @@ -24,12 +25,6 @@ #include "net/base/io_buffer.h" #include "net/url_request/url_request_context.h" -#if defined(OS_WIN) -// TODO(port): port these headers to posix. -#include "chrome/browser/tab_contents/tab_contents.h" -#elif defined(OS_POSIX) -#include "chrome/common/temp_scaffolding_stubs.h" -#endif SaveFileManager::SaveFileManager(MessageLoop* ui_loop, MessageLoop* io_loop, diff --git a/chrome/browser/navigation_controller_unittest.cc b/chrome/browser/navigation_controller_unittest.cc index 72d60bbf..3803cf5 100644 --- a/chrome/browser/navigation_controller_unittest.cc +++ b/chrome/browser/navigation_controller_unittest.cc @@ -13,6 +13,7 @@ #include "chrome/browser/sessions/session_types.h" #include "chrome/browser/tab_contents/navigation_controller.h" #include "chrome/browser/tab_contents/navigation_entry.h" +#include "chrome/browser/tab_contents/tab_contents.h" #include "chrome/browser/tab_contents/tab_contents_delegate.h" #include "chrome/browser/tab_contents/tab_contents_factory.h" #include "chrome/common/notification_registrar.h" @@ -26,13 +27,6 @@ #include "testing/gtest/include/gtest/gtest.h" #include "webkit/glue/webkit_glue.h" -// TODO(port): get rid of this section, finish porting. -#if defined(OS_WIN) -#include "chrome/browser/tab_contents/tab_contents.h" -#else -#include "chrome/common/temp_scaffolding_stubs.h" -#endif - using base::Time; namespace { @@ -1433,4 +1427,4 @@ TEST_F(NavigationControllerHistoryTest, NavigationPruning) { session_helper_.AssertNavigationEquals(nav, windows_[0]->tabs[0]->navigations[1]); } -*/
\ No newline at end of file +*/ diff --git a/chrome/browser/profile.cc b/chrome/browser/profile.cc index 5f6bb1e..268daea 100644 --- a/chrome/browser/profile.cc +++ b/chrome/browser/profile.cc @@ -21,11 +21,12 @@ #include "chrome/browser/net/chrome_url_request_context.h" #include "chrome/browser/profile_manager.h" #include "chrome/browser/renderer_host/render_process_host.h" +#include "chrome/browser/search_engines/template_url_fetcher.h" #include "chrome/browser/search_engines/template_url_model.h" -#include "chrome/browser/ssl/ssl_host_state.h" #include "chrome/browser/sessions/session_service.h" #include "chrome/browser/sessions/tab_restore_service.h" #include "chrome/browser/spellchecker.h" +#include "chrome/browser/ssl/ssl_host_state.h" #include "chrome/browser/visitedlink_master.h" #include "chrome/browser/webdata/web_data_service.h" #include "chrome/common/chrome_constants.h" @@ -36,16 +37,6 @@ #include "chrome/common/render_messages.h" #include "grit/locale_settings.h" -#if defined(OS_POSIX) -// TODO(port): get rid of this include. It's used just to provide declarations -// and stub definitions for classes we encouter during the porting effort. -#include "chrome/common/temp_scaffolding_stubs.h" -#endif - -// TODO(port): Get rid of this section and finish porting. -#if defined(OS_WIN) -#include "chrome/browser/search_engines/template_url_fetcher.h" -#endif using base::Time; using base::TimeDelta; diff --git a/chrome/browser/profile_manager.cc b/chrome/browser/profile_manager.cc index 82d7192..f3fa543 100644 --- a/chrome/browser/profile_manager.cc +++ b/chrome/browser/profile_manager.cc @@ -25,12 +25,6 @@ #include "net/url_request/url_request_job.h" #include "net/url_request/url_request_job_tracker.h" -#if defined(OS_POSIX) -// TODO(port): get rid of this include. It's used just to provide declarations -// and stub definitions for classes we encouter during the porting effort. -#include "chrome/common/temp_scaffolding_stubs.h" -#endif - // static void ProfileManager::RegisterUserPrefs(PrefService* prefs) { prefs->RegisterStringPref(prefs::kProfileName, L""); diff --git a/chrome/browser/renderer_host/resource_message_filter.h b/chrome/browser/renderer_host/resource_message_filter.h index b813872..19566be 100644 --- a/chrome/browser/renderer_host/resource_message_filter.h +++ b/chrome/browser/renderer_host/resource_message_filter.h @@ -27,9 +27,6 @@ #if defined(OS_WIN) #include <windows.h> -#else -// TODO(port): port ResourceDispatcherHost. -#include "chrome/common/temp_scaffolding_stubs.h" #endif class AppCacheDispatcherHost; diff --git a/chrome/browser/renderer_host/resource_request_details.h b/chrome/browser/renderer_host/resource_request_details.h index 0e0ac17..4209c7f 100644 --- a/chrome/browser/renderer_host/resource_request_details.h +++ b/chrome/browser/renderer_host/resource_request_details.h @@ -11,19 +11,13 @@ #include <string> +#include "chrome/browser/cert_store.h" #include "chrome/browser/renderer_host/resource_dispatcher_host.h" #include "googleurl/src/gurl.h" #include "net/url_request/url_request_status.h" class URLRequest; -#if defined(OS_WIN) -// TODO(port): Move header to the above section when CertStore has been ported. -#include "chrome/browser/cert_store.h" -#elif defined(OS_POSIX) -#include "chrome/common/temp_scaffolding_stubs.h" -#endif - // Details about a resource request notification. class ResourceRequestDetails { public: diff --git a/chrome/browser/ssl/ssl_manager.cc b/chrome/browser/ssl/ssl_manager.cc index 2d953eb..d848dca 100644 --- a/chrome/browser/ssl/ssl_manager.cc +++ b/chrome/browser/ssl/ssl_manager.cc @@ -13,9 +13,11 @@ #include "chrome/browser/ssl/ssl_error_info.h" #include "chrome/browser/ssl/ssl_host_state.h" #include "chrome/browser/ssl/ssl_policy.h" +#include "chrome/browser/tab_contents/infobar_delegate.h" #include "chrome/browser/tab_contents/navigation_controller.h" #include "chrome/browser/tab_contents/navigation_entry.h" #include "chrome/browser/tab_contents/provisional_load_details.h" +#include "chrome/browser/tab_contents/tab_contents.h" #include "chrome/browser/tab_contents/tab_util.h" #include "chrome/browser/tab_contents/web_contents.h" #include "chrome/common/l10n_util.h" @@ -33,8 +35,6 @@ #if defined(OS_WIN) // TODO(port): Port these files. #include "chrome/browser/load_notification_details.h" -#include "chrome/browser/tab_contents/infobar_delegate.h" -#include "chrome/browser/tab_contents/tab_contents.h" #include "chrome/views/controls/link.h" #else #include "chrome/common/temp_scaffolding_stubs.h" diff --git a/chrome/browser/ssl/ssl_policy.cc b/chrome/browser/ssl/ssl_policy.cc index 5edef80a..3cb5975 100644 --- a/chrome/browser/ssl/ssl_policy.cc +++ b/chrome/browser/ssl/ssl_policy.cc @@ -10,6 +10,7 @@ #include "chrome/browser/cert_store.h" #include "chrome/browser/renderer_host/render_view_host.h" #include "chrome/browser/ssl/ssl_error_info.h" +#include "chrome/browser/tab_contents/tab_contents.h" #include "chrome/browser/tab_contents/navigation_entry.h" #include "chrome/browser/tab_contents/web_contents.h" #include "chrome/common/jstemplate_builder.h" @@ -27,12 +28,6 @@ #include "net/base/ssl_info.h" #include "webkit/glue/resource_type.h" -#if defined(OS_WIN) -// TODO(port): port these files. -#include "chrome/browser/tab_contents/tab_contents.h" -#elif defined(OS_POSIX) -#include "chrome/common/temp_scaffolding_stubs.h" -#endif using WebKit::WebConsoleMessage; diff --git a/chrome/browser/tab_contents/tab_contents_factory.cc b/chrome/browser/tab_contents/tab_contents_factory.cc index 3a9feca..cbe5a68 100644 --- a/chrome/browser/tab_contents/tab_contents_factory.cc +++ b/chrome/browser/tab_contents/tab_contents_factory.cc @@ -15,11 +15,6 @@ #include "chrome/common/url_constants.h" #include "net/base/net_util.h" -#if defined(OS_WIN) -// TODO(port): port these headers to posix. -#elif defined(OS_POSIX) -#include "chrome/common/temp_scaffolding_stubs.h" -#endif typedef std::map<TabContentsType, TabContentsFactory*> TabContentsFactoryMap; static TabContentsFactoryMap* g_extra_types; // Only allocated if needed. diff --git a/chrome/browser/tab_contents/web_contents.cc b/chrome/browser/tab_contents/web_contents.cc index 9cd5550..dbe335b 100644 --- a/chrome/browser/tab_contents/web_contents.cc +++ b/chrome/browser/tab_contents/web_contents.cc @@ -18,6 +18,7 @@ #include "chrome/browser/dom_ui/dom_ui.h" #include "chrome/browser/dom_ui/dom_ui_factory.h" #include "chrome/browser/download/download_manager.h" +#include "chrome/browser/download/download_request_manager.h" #include "chrome/browser/gears_integration.h" #include "chrome/browser/google_util.h" #include "chrome/browser/jsmessage_box_handler.h" @@ -30,6 +31,7 @@ #include "chrome/browser/renderer_host/render_view_host.h" #include "chrome/browser/renderer_host/render_widget_host_view.h" #include "chrome/browser/renderer_host/web_cache_manager.h" +#include "chrome/browser/search_engines/template_url_fetcher.h" #include "chrome/browser/search_engines/template_url_model.h" #include "chrome/browser/tab_contents/navigation_entry.h" #include "chrome/browser/tab_contents/provisional_load_details.h" @@ -50,11 +52,9 @@ #if defined(OS_WIN) // TODO(port): fill these in as we flesh out the implementation of this class -#include "chrome/browser/download/download_request_manager.h" #include "chrome/browser/modal_html_dialog_delegate.h" #include "chrome/browser/plugin_service.h" #include "chrome/browser/printing/print_job.h" -#include "chrome/browser/search_engines/template_url_fetcher.h" #include "chrome/browser/views/hung_renderer_view.h" // TODO(brettw) delete me. #include "chrome/common/resource_bundle.h" #endif diff --git a/chrome/common/temp_scaffolding_stubs.h b/chrome/common/temp_scaffolding_stubs.h index bdfa69d..59f4d30 100644 --- a/chrome/common/temp_scaffolding_stubs.h +++ b/chrome/common/temp_scaffolding_stubs.h @@ -473,17 +473,6 @@ class WindowSizer { //--------------------------------------------------------------------------- // These stubs are for Profile -class TemplateURLFetcher { - public: - explicit TemplateURLFetcher(Profile* profile) { } - bool Init(Profile* profile) { - NOTIMPLEMENTED(); - return true; - } - void ScheduleDownload(const std::wstring&, const GURL&, const GURL&, - const gfx::NativeView, bool) { NOTIMPLEMENTED(); } -}; - namespace base { class SharedMemory; } diff --git a/chrome/test/testing_profile.h b/chrome/test/testing_profile.h index 758b70f..416d0db 100644 --- a/chrome/test/testing_profile.h +++ b/chrome/test/testing_profile.h @@ -11,21 +11,12 @@ #include "base/file_util.h" #include "chrome/browser/bookmarks/bookmark_model.h" #include "chrome/browser/browser_prefs.h" +#include "chrome/browser/history/history.h" #include "chrome/browser/profile.h" #include "chrome/browser/search_engines/template_url_model.h" #include "chrome/browser/sessions/session_service.h" #include "chrome/common/pref_service.h" -#if defined(OS_POSIX) -// TODO(port): get rid of this include. It's used just to provide declarations -// and stub definitions for classes we encouter during the porting effort. -#include "chrome/common/temp_scaffolding_stubs.h" -#endif - -// TODO(port): Get rid of this section and finish porting. -#if defined(OS_WIN) -#include "chrome/browser/history/history.h" -#endif class TestingProfile : public Profile { public: |