Update tooltips according to Roma. I ended up calling "Unpin" "Don't

keep on this page" since all the other suggestions are pretty bad as
they are.

BUG=None

TEST=The tooltips should have been updated


Review URL: http://codereview.chromium.org/155532

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20671 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 26 insertions, 12 deletions

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index c5813bf..e281eaa 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -3522,15 +3522,27 @@ each locale. -->
       </message>
       <message name="IDS_NEW_TAB_REMOVE_THUMBNAIL_TOOLTIP"
          desc="Tooltip text for the button that removes/blacklists the thumbnail. Once removed the thumbnail will not show up on the new tab page again.">
-        Remove
+        Don't show on this page
       </message>
       <message name="IDS_NEW_TAB_PIN_THUMBNAIL_TOOLTIP"
          desc="Tooltip text for the button that pins the thumbnail. Once pinned the thumbnail will always be shown on the new tab page and it will alwyas be shown in the same position.">
-        Pin
+        Keep on this page
       </message>
       <message name="IDS_NEW_TAB_UNPIN_THUMBNAIL_TOOLTIP"
          desc="Tooltip text for the button that unpins the thumbnail. Once unpinned the thumbnail might not be displayed on the new tab page any more.">
-        Unpin
+        Don't keep on this page
+      </message>
+      <message name="IDS_NEW_TAB_SHOW_HIDE_THUMBNAIL_TOOLTIP"
+         desc="Tooltip text for the button that shows and hides the thumbnail.">
+        Thumbnail view
+      </message>
+      <message name="IDS_NEW_TAB_SHOW_HIDE_LIST_TOOLTIP"
+         desc="Tooltip text for the button that shows and hides the list view.">
+        List view
+      </message>
+      <message name="IDS_NEW_TAB_PAGE_DISPLAY_TOOLTIP"
+         desc="Tooltip text for the button that shows the menu that hides and shows different sections on the new tab page.">
+        Change page layout
       </message>
 
       <!-- SafeBrowsing -->
diff --git a/chrome/browser/dom_ui/new_tab_ui.cc b/chrome/browser/dom_ui/new_tab_ui.cc
index 3a53b24..a807e47 100644
--- a/chrome/browser/dom_ui/new_tab_ui.cc
+++ b/chrome/browser/dom_ui/new_tab_ui.cc
@@ -335,7 +335,12 @@ void NewTabHTMLSource::StartDataRequest(const std::string& path,
       l10n_util::GetString(IDS_NEW_TAB_PIN_THUMBNAIL_TOOLTIP));
   localized_strings.SetString(L"unpinthumbnailtooltip",
       l10n_util::GetString(IDS_NEW_TAB_UNPIN_THUMBNAIL_TOOLTIP));
-
+  localized_strings.SetString(L"showhidethumbnailtooltip",
+      l10n_util::GetString(IDS_NEW_TAB_SHOW_HIDE_THUMBNAIL_TOOLTIP));
+  localized_strings.SetString(L"showhidelisttooltip",
+      l10n_util::GetString(IDS_NEW_TAB_SHOW_HIDE_LIST_TOOLTIP));
+  localized_strings.SetString(L"pagedisplaytooltip",
+      l10n_util::GetString(IDS_NEW_TAB_PAGE_DISPLAY_TOOLTIP));
 
   SetFontAndTextDirection(&localized_strings);
 
diff --git a/chrome/browser/resources/new_new_tab.html b/chrome/browser/resources/new_new_tab.html
index 086553f..cd7b707 100644
--- a/chrome/browser/resources/new_new_tab.html
+++ b/chrome/browser/resources/new_new_tab.html
@@ -57,9 +57,11 @@ logEvent('log start');
 
   <div id="view-toolbar"
       ><input type=checkbox id="thumb-checkbox" checked
-              i18n-values="title:hidethumbnails"
-      ><input type=checkbox id="list-checkbox" i18n-values="title:showlist"
-      ><input type="button" id="option-button"></div>
+              i18n-values="title:showhidethumbnailtooltip"
+      ><input type=checkbox id="list-checkbox"
+              i18n-values="title:showhidelisttooltip"
+      ><input type="button" id="option-button"
+              i18n-values="title:pagedisplaytooltip"></div>
 
   <div id="option-menu" class="window-menu">
     <div section="THUMB" show="true" i18n-content="showthumbnails"
diff --git a/chrome/browser/resources/new_new_tab.js b/chrome/browser/resources/new_new_tab.js
index e0b7648..5bebc13 100644
--- a/chrome/browser/resources/new_new_tab.js
+++ b/chrome/browser/resources/new_new_tab.js
@@ -447,11 +447,6 @@ var mostVisited = {
       thumbCheckbox.checked = false;
       listCheckbox.checked = false;
     }
-
-    thumbCheckbox.title = localStrings.getString(
-        shownSections & Section.THUMB ? 'hidethumbnails' : 'showthumbnails');
-    listCheckbox.title = localStrings.getString(
-        shownSections & Section.LIST ? 'hidelist' : 'showlist');
   },
 
   dirty_: false,