diff options
| author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-22 13:35:49 +0000 |
|---|---|---|
| committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-22 13:35:49 +0000 |
| commit | 11f40349ae8b6a644399d7b609a3c702873ddc3b (patch) | |
| tree | 5143f91c042f713d09c488ce652d16e3625dc32b /chrome | |
| parent | df89c555395b0f0585dbe56cb6ddbf1029c1e9ab (diff) | |
| download | chromium_src-11f40349ae8b6a644399d7b609a3c702873ddc3b.zip chromium_src-11f40349ae8b6a644399d7b609a3c702873ddc3b.tar.gz chromium_src-11f40349ae8b6a644399d7b609a3c702873ddc3b.tar.bz2 | |
Clean-up style issues in net:: related to X.509 data-types, eliminating unnecessary includes and marking platform-specific implementations as such. Also clearly document that CertPrincipal::Matches() is not suitable for security-relevant name checks.
In addition, because x509_cert_types.h no longer includes base/singleton.h, fix all the classes that broke because they weren't including what they used.
BUG=none
TEST=existing
Review URL: http://codereview.chromium.org/5162001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66941 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/dom_ui/constrained_html_ui.cc | 1 | ||||
| -rw-r--r-- | chrome/browser/dom_ui/slideshow_ui.cc | 1 | ||||
| -rw-r--r-- | chrome/browser/extensions/extensions_ui.cc | 1 | ||||
| -rw-r--r-- | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc | 1 | ||||
| -rw-r--r-- | chrome/browser/tab_contents_wrapper.cc | 1 | ||||
| -rw-r--r-- | chrome/browser/ui/views/html_dialog_view_browsertest.cc | 1 |
6 files changed, 6 insertions, 0 deletions
diff --git a/chrome/browser/dom_ui/constrained_html_ui.cc b/chrome/browser/dom_ui/constrained_html_ui.cc index e715977..d15644c 100644 --- a/chrome/browser/dom_ui/constrained_html_ui.cc +++ b/chrome/browser/dom_ui/constrained_html_ui.cc @@ -4,6 +4,7 @@ #include "chrome/browser/dom_ui/constrained_html_ui.h" +#include "base/singleton.h" #include "chrome/browser/dom_ui/dom_ui_util.h" #include "chrome/browser/dom_ui/html_dialog_ui.h" #include "chrome/browser/renderer_host/render_view_host.h" diff --git a/chrome/browser/dom_ui/slideshow_ui.cc b/chrome/browser/dom_ui/slideshow_ui.cc index 10dfe36..277ea21 100644 --- a/chrome/browser/dom_ui/slideshow_ui.cc +++ b/chrome/browser/dom_ui/slideshow_ui.cc @@ -8,6 +8,7 @@ #include "base/callback.h" #include "base/message_loop.h" #include "base/path_service.h" +#include "base/singleton.h" #include "base/string_piece.h" #include "base/string_util.h" #include "base/thread.h" diff --git a/chrome/browser/extensions/extensions_ui.cc b/chrome/browser/extensions/extensions_ui.cc index cf78bec..d3006cf 100644 --- a/chrome/browser/extensions/extensions_ui.cc +++ b/chrome/browser/extensions/extensions_ui.cc @@ -9,6 +9,7 @@ #include "base/base64.h" #include "base/callback.h" #include "base/file_util.h" +#include "base/singleton.h" #include "base/string_number_conversions.h" #include "base/string_util.h" #include "base/utf_string_conversions.h" diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc index d158b11..243195f 100644 --- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc +++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc @@ -11,6 +11,7 @@ #include "app/l10n_util.h" #include "app/resource_bundle.h" #include "base/i18n/rtl.h" +#include "base/singleton.h" #include "base/string_number_conversions.h" #include "base/utf_string_conversions.h" #include "base/values.h" diff --git a/chrome/browser/tab_contents_wrapper.cc b/chrome/browser/tab_contents_wrapper.cc index 707e240..d1f0a2fb 100644 --- a/chrome/browser/tab_contents_wrapper.cc +++ b/chrome/browser/tab_contents_wrapper.cc @@ -4,6 +4,7 @@ #include "chrome/browser/tab_contents_wrapper.h" +#include "base/singleton.h" #include "chrome/browser/password_manager/password_manager.h" #include "chrome/browser/password_manager_delegate_impl.h" #include "chrome/browser/tab_contents/tab_contents.h" diff --git a/chrome/browser/ui/views/html_dialog_view_browsertest.cc b/chrome/browser/ui/views/html_dialog_view_browsertest.cc index a2bcd35..baacb95 100644 --- a/chrome/browser/ui/views/html_dialog_view_browsertest.cc +++ b/chrome/browser/ui/views/html_dialog_view_browsertest.cc @@ -6,6 +6,7 @@ #include "base/file_path.h" #include "base/message_loop.h" +#include "base/singleton.h" #include "chrome/browser/browser_thread.h" #include "chrome/browser/dom_ui/html_dialog_ui.h" #include "chrome/browser/tab_contents/tab_contents.h" |