summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authoravi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-01 16:02:20 +0000
committeravi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-01 16:02:20 +0000
commit3abbed000fefd2f846da29a5c14683bf32ff1867 (patch)
tree9aa204b4ccc3eb1b4c4e2f4cf2fd10b5e4a2abd9 /chrome
parentf7d1f758a9f21fe3165a11552074bbed99b676cf (diff)
downloadchromium_src-3abbed000fefd2f846da29a5c14683bf32ff1867.zip
chromium_src-3abbed000fefd2f846da29a5c14683bf32ff1867.tar.gz
chromium_src-3abbed000fefd2f846da29a5c14683bf32ff1867.tar.bz2
Add OVERRIDE to wide swaths of WebUI.
BUG=none TEST=none Review URL: http://codereview.chromium.org/7541022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94906 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/browser/browser_signin.cc21
-rw-r--r--chrome/browser/extensions/extensions_ui.h18
-rw-r--r--chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.h4
-rw-r--r--chrome/browser/ui/login/login_prompt_ui.cc21
-rw-r--r--chrome/browser/ui/views/select_file_dialog.cc2
-rw-r--r--chrome/browser/ui/webui/active_downloads_ui.cc10
-rw-r--r--chrome/browser/ui/webui/bookmarks_ui.h4
-rw-r--r--chrome/browser/ui/webui/bug_report_ui.cc4
-rw-r--r--chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc6
-rw-r--r--chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc4
-rw-r--r--chrome/browser/ui/webui/chromeos/login/oobe_ui.h19
-rw-r--r--chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc8
-rw-r--r--chrome/browser/ui/webui/chromeos/register_page_ui.cc4
-rw-r--r--chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc8
-rw-r--r--chrome/browser/ui/webui/chromeos/system_info_ui.cc4
-rw-r--r--chrome/browser/ui/webui/constrained_html_ui.h2
-rw-r--r--chrome/browser/ui/webui/crashes_ui.cc6
-rw-r--r--chrome/browser/ui/webui/devtools_ui.h2
-rw-r--r--chrome/browser/ui/webui/downloads_dom_handler.h8
-rw-r--r--chrome/browser/ui/webui/flags_ui.cc2
-rw-r--r--chrome/browser/ui/webui/gpu_internals_ui.cc18
-rw-r--r--chrome/browser/ui/webui/history2_ui.h6
-rw-r--r--chrome/browser/ui/webui/history_ui.cc4
-rw-r--r--chrome/browser/ui/webui/history_ui.h6
-rw-r--r--chrome/browser/ui/webui/html_dialog_ui.h2
-rw-r--r--chrome/browser/ui/webui/keyboard_ui.h4
-rw-r--r--chrome/browser/ui/webui/media/media_internals_handler.h4
-rw-r--r--chrome/browser/ui/webui/net_internals_ui.cc6
-rw-r--r--chrome/browser/ui/webui/new_profile_handler.h2
-rw-r--r--chrome/browser/ui/webui/ntp/app_launcher_handler.h14
-rw-r--r--chrome/browser/ui/webui/ntp/bookmarks_handler.h4
-rw-r--r--chrome/browser/ui/webui/ntp/favicon_webui_handler.h2
-rw-r--r--chrome/browser/ui/webui/ntp/foreign_session_handler.h2
-rw-r--r--chrome/browser/ui/webui/ntp/most_visited_handler.h6
-rw-r--r--chrome/browser/ui/webui/ntp/new_tab_page_handler.h2
-rw-r--r--chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h6
-rw-r--r--chrome/browser/ui/webui/ntp/new_tab_ui.cc2
-rw-r--r--chrome/browser/ui/webui/ntp/new_tab_ui.h8
-rw-r--r--chrome/browser/ui/webui/ntp/ntp_login_handler.h6
-rw-r--r--chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.h6
-rw-r--r--chrome/browser/ui/webui/ntp/shown_sections_handler.h4
-rw-r--r--chrome/browser/ui/webui/options/options_ui.h4
-rw-r--r--chrome/browser/ui/webui/plugins_ui.cc10
-rw-r--r--chrome/browser/ui/webui/print_preview_handler.h10
-rw-r--r--chrome/browser/ui/webui/quota_internals_ui.h2
-rw-r--r--chrome/browser/ui/webui/sessions_ui.cc4
-rw-r--r--chrome/browser/ui/webui/textfields_ui.h2
-rw-r--r--chrome/browser/ui/webui/web_ui_test_handler.h2
-rw-r--r--chrome/browser/ui/webui/workers_ui.cc2
49 files changed, 157 insertions, 150 deletions
diff --git a/chrome/browser/browser_signin.cc b/chrome/browser/browser_signin.cc
index 8f4bbd61..2882bb5 100644
--- a/chrome/browser/browser_signin.cc
+++ b/chrome/browser/browser_signin.cc
@@ -79,37 +79,38 @@ class BrowserSigninHtml : public HtmlDialogUIDelegate,
virtual ~BrowserSigninHtml() {}
// HtmlDialogUIDelegate implementation
- virtual bool IsDialogModal() const {
+ virtual bool IsDialogModal() const OVERRIDE {
return false;
};
- virtual std::wstring GetDialogTitle() const {
+ virtual std::wstring GetDialogTitle() const OVERRIDE {
return L"";
}
- virtual GURL GetDialogContentURL() const {
+ virtual GURL GetDialogContentURL() const OVERRIDE {
return GURL("chrome://dialog/signin");
}
virtual void GetWebUIMessageHandlers(
- std::vector<WebUIMessageHandler*>* handlers) const {
+ std::vector<WebUIMessageHandler*>* handlers) const OVERRIDE {
const WebUIMessageHandler* handler = this;
handlers->push_back(const_cast<WebUIMessageHandler*>(handler));
}
- virtual void GetDialogSize(gfx::Size* size) const {
+ virtual void GetDialogSize(gfx::Size* size) const OVERRIDE {
size->set_width(600);
size->set_height(300);
}
- virtual std::string GetDialogArgs() const {
+ virtual std::string GetDialogArgs() const OVERRIDE {
return UTF16ToASCII(login_message_);
}
- virtual void OnDialogClosed(const std::string& json_retval) {
+ virtual void OnDialogClosed(const std::string& json_retval) OVERRIDE {
closed_ = true;
signin_->Cancel();
}
- virtual void OnCloseContents(TabContents* source, bool* out_close_dialog) {
+ virtual void OnCloseContents(TabContents* source,
+ bool* out_close_dialog) OVERRIDE {
}
- virtual bool ShouldShowDialogTitle() const { return true; }
+ virtual bool ShouldShowDialogTitle() const OVERRIDE { return true; }
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// Refreshes the UI, such as after an authentication error.
void ReloadUI();
diff --git a/chrome/browser/extensions/extensions_ui.h b/chrome/browser/extensions/extensions_ui.h
index 8d130c4..37e27c7 100644
--- a/chrome/browser/extensions/extensions_ui.h
+++ b/chrome/browser/extensions/extensions_ui.h
@@ -56,7 +56,7 @@ class ExtensionsDOMHandler : public WebUIMessageHandler,
virtual ~ExtensionsDOMHandler();
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// Extension Detail JSON Struct for page. (static for ease of testing).
// Note: service can be NULL in unit tests.
@@ -69,13 +69,13 @@ class ExtensionsDOMHandler : public WebUIMessageHandler,
// ExtensionPackJob::Client
virtual void OnPackSuccess(const FilePath& crx_file,
- const FilePath& key_file);
+ const FilePath& key_file) OVERRIDE;
- virtual void OnPackFailure(const std::string& error);
+ virtual void OnPackFailure(const std::string& error) OVERRIDE;
// ExtensionUninstallDialog::Delegate:
- virtual void ExtensionDialogAccepted();
- virtual void ExtensionDialogCanceled();
+ virtual void ExtensionDialogAccepted() OVERRIDE;
+ virtual void ExtensionDialogCanceled() OVERRIDE;
private:
// Callback for "requestExtensionsData" message.
@@ -134,15 +134,15 @@ class ExtensionsDOMHandler : public WebUIMessageHandler,
// SelectFileDialog::Listener
virtual void FileSelected(const FilePath& path,
- int index, void* params);
+ int index, void* params) OVERRIDE;
virtual void MultiFilesSelected(
- const std::vector<FilePath>& files, void* params);
- virtual void FileSelectionCanceled(void* params) {}
+ const std::vector<FilePath>& files, void* params) OVERRIDE;
+ virtual void FileSelectionCanceled(void* params) OVERRIDE {}
// NotificationObserver
virtual void Observe(int type,
const NotificationSource& source,
- const NotificationDetails& details);
+ const NotificationDetails& details) OVERRIDE;
// Helper that lists the current active html pages for an extension.
std::vector<ExtensionPage> GetActivePagesForExtension(
diff --git a/chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.h b/chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.h
index 064d508..9e18804 100644
--- a/chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.h
+++ b/chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.h
@@ -20,11 +20,11 @@ class CloudPrintSetupMessageHandler : public WebUIMessageHandler {
virtual ~CloudPrintSetupMessageHandler() {}
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
protected:
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// Callbacks from the page.
void HandleSubmitAuth(const ListValue* args);
diff --git a/chrome/browser/ui/login/login_prompt_ui.cc b/chrome/browser/ui/login/login_prompt_ui.cc
index 3306ff2..8c8440a 100644
--- a/chrome/browser/ui/login/login_prompt_ui.cc
+++ b/chrome/browser/ui/login/login_prompt_ui.cc
@@ -82,43 +82,44 @@ class LoginHandlerHtmlDelegate : public HtmlDialogUIDelegate,
}
// HtmlDialogUIDelegate methods:
- virtual bool IsDialogModal() const {
+ virtual bool IsDialogModal() const OVERRIDE {
return true;
}
- virtual std::wstring GetDialogTitle() const {
+ virtual std::wstring GetDialogTitle() const OVERRIDE {
return UTF16ToWide(l10n_util::GetStringUTF16(IDS_LOGIN_DIALOG_TITLE));
}
- virtual GURL GetDialogContentURL() const {
+ virtual GURL GetDialogContentURL() const OVERRIDE {
return GURL(chrome::kChromeUIHttpAuthURL);
}
virtual void GetWebUIMessageHandlers(
- std::vector<WebUIMessageHandler*>* handlers) const {
+ std::vector<WebUIMessageHandler*>* handlers) const OVERRIDE {
const WebUIMessageHandler* handler = this;
handlers->push_back(const_cast<WebUIMessageHandler*>(handler));
}
- virtual void GetDialogSize(gfx::Size* size) const {
+ virtual void GetDialogSize(gfx::Size* size) const OVERRIDE {
size->set_width(kDialogWidth);
size->set_height(kDialogHeight);
}
- virtual std::string GetDialogArgs() const {
+ virtual std::string GetDialogArgs() const OVERRIDE {
return explanation_;
}
- virtual void OnDialogClosed(const std::string& json_retval);
+ virtual void OnDialogClosed(const std::string& json_retval) OVERRIDE;
- virtual void OnCloseContents(TabContents* source, bool* out_close_dialog) {}
+ virtual void OnCloseContents(TabContents* source,
+ bool* out_close_dialog) OVERRIDE {}
- virtual bool ShouldShowDialogTitle() const {
+ virtual bool ShouldShowDialogTitle() const OVERRIDE {
return true;
}
// WebUIMessageHandler method:
- virtual void RegisterMessages() {
+ virtual void RegisterMessages() OVERRIDE {
web_ui_->RegisterMessageCallback(
"GetAutofill",
NewCallback(this, &LoginHandlerHtmlDelegate::GetAutofill));
diff --git a/chrome/browser/ui/views/select_file_dialog.cc b/chrome/browser/ui/views/select_file_dialog.cc
index 907832c..905ac2f 100644
--- a/chrome/browser/ui/views/select_file_dialog.cc
+++ b/chrome/browser/ui/views/select_file_dialog.cc
@@ -124,7 +124,7 @@ class SelectFileDialogImpl : public SelectFileDialog {
explicit FileBrowseDelegateHandler(FileBrowseDelegate* delegate);
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// Callback for the "setDialogTitle" message.
void HandleSetDialogTitle(const ListValue* args);
diff --git a/chrome/browser/ui/webui/active_downloads_ui.cc b/chrome/browser/ui/webui/active_downloads_ui.cc
index 59a6db7..a6faa09 100644
--- a/chrome/browser/ui/webui/active_downloads_ui.cc
+++ b/chrome/browser/ui/webui/active_downloads_ui.cc
@@ -156,15 +156,15 @@ class ActiveDownloadsHandler
void Init();
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
// DownloadItem::Observer interface.
- virtual void OnDownloadUpdated(DownloadItem* item);
- virtual void OnDownloadOpened(DownloadItem* item) { }
+ virtual void OnDownloadUpdated(DownloadItem* item) OVERRIDE;
+ virtual void OnDownloadOpened(DownloadItem* item) OVERRIDE { }
// DownloadManager::Observer interface.
- virtual void ModelChanged();
+ virtual void ModelChanged() OVERRIDE;
// WebUI Callbacks.
void HandleGetDownloads(const ListValue* args);
diff --git a/chrome/browser/ui/webui/bookmarks_ui.h b/chrome/browser/ui/webui/bookmarks_ui.h
index a871e5e5..b7295aa 100644
--- a/chrome/browser/ui/webui/bookmarks_ui.h
+++ b/chrome/browser/ui/webui/bookmarks_ui.h
@@ -23,8 +23,8 @@ class BookmarksUIHTMLSource : public ChromeURLDataManager::DataSource {
// the path we registered.
virtual void StartDataRequest(const std::string& path,
bool is_incognito,
- int request_id);
- virtual std::string GetMimeType(const std::string& path) const;
+ int request_id) OVERRIDE;
+ virtual std::string GetMimeType(const std::string& path) const OVERRIDE;
private:
DISALLOW_COPY_AND_ASSIGN(BookmarksUIHTMLSource);
diff --git a/chrome/browser/ui/webui/bug_report_ui.cc b/chrome/browser/ui/webui/bug_report_ui.cc
index c29af14..2e90b31 100644
--- a/chrome/browser/ui/webui/bug_report_ui.cc
+++ b/chrome/browser/ui/webui/bug_report_ui.cc
@@ -197,8 +197,8 @@ class BugReportHandler : public WebUIMessageHandler,
base::StringPiece Init();
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
private:
void HandleGetDialogDefaults(const ListValue* args);
diff --git a/chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc b/chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc
index 4f98584..243221d 100644
--- a/chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc
@@ -70,11 +70,11 @@ class ChooseMobileNetworkHandler
virtual ~ChooseMobileNetworkHandler();
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// NetworkDeviceObserver implementation.
- virtual void OnNetworkDeviceFoundNetworks(NetworkLibrary* cros,
- const NetworkDevice* device);
+ virtual void OnNetworkDeviceFoundNetworks(
+ NetworkLibrary* cros, const NetworkDevice* device) OVERRIDE;
private:
// Handlers for JS WebUI messages.
diff --git a/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc b/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
index f94ca8d..51000d2 100644
--- a/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
@@ -207,8 +207,8 @@ class KeyboardOverlayHandler
virtual ~KeyboardOverlayHandler();
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
private:
// Called when the page requires the input method ID corresponding to the
diff --git a/chrome/browser/ui/webui/chromeos/login/oobe_ui.h b/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
index 2f9a96f..7a5132d 100644
--- a/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
+++ b/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
@@ -31,15 +31,16 @@ class OobeUI : public OobeDisplay,
explicit OobeUI(TabContents* contents);
// OobeDisplay implementation:
- virtual void ShowScreen(WizardScreen* screen);
- virtual void HideScreen(WizardScreen* screen);
- virtual UpdateScreenActor* GetUpdateScreenActor();
- virtual NetworkScreenActor* GetNetworkScreenActor();
- virtual EulaScreenActor* GetEulaScreenActor();
- virtual EnterpriseEnrollmentScreenActor* GetEnterpriseEnrollmentScreenActor();
- virtual UserImageScreenActor* GetUserImageScreenActor();
- virtual ViewScreenDelegate* GetRegistrationScreenActor();
- virtual ViewScreenDelegate* GetHTMLPageScreenActor();
+ virtual void ShowScreen(WizardScreen* screen) OVERRIDE;
+ virtual void HideScreen(WizardScreen* screen) OVERRIDE;
+ virtual UpdateScreenActor* GetUpdateScreenActor() OVERRIDE;
+ virtual NetworkScreenActor* GetNetworkScreenActor() OVERRIDE;
+ virtual EulaScreenActor* GetEulaScreenActor() OVERRIDE;
+ virtual EnterpriseEnrollmentScreenActor* GetEnterpriseEnrollmentScreenActor()
+ OVERRIDE;
+ virtual UserImageScreenActor* GetUserImageScreenActor() OVERRIDE;
+ virtual ViewScreenDelegate* GetRegistrationScreenActor() OVERRIDE;
+ virtual ViewScreenDelegate* GetHTMLPageScreenActor() OVERRIDE;
// Collects localized strings from the owned handlers.
void GetLocalizedStrings(base::DictionaryValue* localized_strings);
diff --git a/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc b/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
index 30b8bef..9bde86e 100644
--- a/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
@@ -165,14 +165,14 @@ class MobileSetupHandler
void Init(TabContents* contents);
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
// NetworkLibrary::NetworkManagerObserver implementation.
- virtual void OnNetworkManagerChanged(chromeos::NetworkLibrary* obj);
+ virtual void OnNetworkManagerChanged(chromeos::NetworkLibrary* obj) OVERRIDE;
// NetworkLibrary::NetworkObserver implementation.
virtual void OnNetworkChanged(chromeos::NetworkLibrary* obj,
- const chromeos::Network* network);
+ const chromeos::Network* network) OVERRIDE;
private:
typedef enum PlanActivationState {
diff --git a/chrome/browser/ui/webui/chromeos/register_page_ui.cc b/chrome/browser/ui/webui/chromeos/register_page_ui.cc
index 5e1a439..14480c8 100644
--- a/chrome/browser/ui/webui/chromeos/register_page_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/register_page_ui.cc
@@ -118,8 +118,8 @@ class RegisterPageHandler : public WebUIMessageHandler,
void Init();
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
private:
// Handlers for JS WebUI messages.
diff --git a/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc b/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc
index 0dfd028..7cea5a8 100644
--- a/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc
@@ -93,16 +93,16 @@ class SimUnlockHandler : public WebUIMessageHandler,
void Init(TabContents* contents);
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
// NetworkLibrary::NetworkDeviceObserver implementation.
virtual void OnNetworkDeviceChanged(NetworkLibrary* cros,
- const NetworkDevice* device);
+ const NetworkDevice* device) OVERRIDE;
// NetworkLibrary::PinOperationObserver implementation.
virtual void OnPinOperationCompleted(NetworkLibrary* cros,
- PinOperationError error);
+ PinOperationError error) OVERRIDE;
private:
// Should keep this state enum in sync with similar one in JS code.
diff --git a/chrome/browser/ui/webui/chromeos/system_info_ui.cc b/chrome/browser/ui/webui/chromeos/system_info_ui.cc
index 4128e5f..872e987 100644
--- a/chrome/browser/ui/webui/chromeos/system_info_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/system_info_ui.cc
@@ -68,8 +68,8 @@ class SystemInfoHandler : public WebUIMessageHandler,
virtual ~SystemInfoHandler();
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
private:
DISALLOW_COPY_AND_ASSIGN(SystemInfoHandler);
diff --git a/chrome/browser/ui/webui/constrained_html_ui.h b/chrome/browser/ui/webui/constrained_html_ui.h
index 58c2058..3141f50 100644
--- a/chrome/browser/ui/webui/constrained_html_ui.h
+++ b/chrome/browser/ui/webui/constrained_html_ui.h
@@ -36,7 +36,7 @@ class ConstrainedHtmlUI : public ChromeWebUI {
explicit ConstrainedHtmlUI(TabContents* contents);
virtual ~ConstrainedHtmlUI();
- virtual void RenderViewCreated(RenderViewHost* render_view_host);
+ virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE;
// Create a constrained HTML dialog. The actual object that gets created
// is a ConstrainedHtmlUIDelegate, which later triggers construction of a
diff --git a/chrome/browser/ui/webui/crashes_ui.cc b/chrome/browser/ui/webui/crashes_ui.cc
index 5bb00a8..f148828 100644
--- a/chrome/browser/ui/webui/crashes_ui.cc
+++ b/chrome/browser/ui/webui/crashes_ui.cc
@@ -68,11 +68,11 @@ class CrashesDOMHandler : public WebUIMessageHandler,
virtual ~CrashesDOMHandler();
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
// CrashUploadList::Delegate implemenation.
- virtual void OnCrashListAvailable();
+ virtual void OnCrashListAvailable() OVERRIDE;
private:
// Asynchronously fetches the list of crashes. Called from JS.
diff --git a/chrome/browser/ui/webui/devtools_ui.h b/chrome/browser/ui/webui/devtools_ui.h
index 0bfa46a..4cd07b8 100644
--- a/chrome/browser/ui/webui/devtools_ui.h
+++ b/chrome/browser/ui/webui/devtools_ui.h
@@ -17,7 +17,7 @@ class DevToolsUI : public ChromeWebUI {
explicit DevToolsUI(TabContents* contents);
// WebUI
- virtual void RenderViewCreated(RenderViewHost* render_view_host);
+ virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE;
private:
DISALLOW_COPY_AND_ASSIGN(DevToolsUI);
diff --git a/chrome/browser/ui/webui/downloads_dom_handler.h b/chrome/browser/ui/webui/downloads_dom_handler.h
index d407b66..2045eef 100644
--- a/chrome/browser/ui/webui/downloads_dom_handler.h
+++ b/chrome/browser/ui/webui/downloads_dom_handler.h
@@ -29,14 +29,14 @@ class DownloadsDOMHandler : public WebUIMessageHandler,
void Init();
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// DownloadItem::Observer interface
- virtual void OnDownloadUpdated(DownloadItem* download);
- virtual void OnDownloadOpened(DownloadItem* download) { }
+ virtual void OnDownloadUpdated(DownloadItem* download) OVERRIDE;
+ virtual void OnDownloadOpened(DownloadItem* download) OVERRIDE { }
// DownloadManager::Observer interface
- virtual void ModelChanged();
+ virtual void ModelChanged() OVERRIDE;
// Callback for the "getDownloads" message.
void HandleGetDownloads(const base::ListValue* args);
diff --git a/chrome/browser/ui/webui/flags_ui.cc b/chrome/browser/ui/webui/flags_ui.cc
index b9ed86a..acdd1aa 100644
--- a/chrome/browser/ui/webui/flags_ui.cc
+++ b/chrome/browser/ui/webui/flags_ui.cc
@@ -87,7 +87,7 @@ class FlagsDOMHandler : public WebUIMessageHandler {
virtual ~FlagsDOMHandler() {}
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// Callback for the "requestFlagsExperiments" message.
void HandleRequestFlagsExperiments(const ListValue* args);
diff --git a/chrome/browser/ui/webui/gpu_internals_ui.cc b/chrome/browser/ui/webui/gpu_internals_ui.cc
index a6c8d79..8088c55 100644
--- a/chrome/browser/ui/webui/gpu_internals_ui.cc
+++ b/chrome/browser/ui/webui/gpu_internals_ui.cc
@@ -73,10 +73,10 @@ class GpuMessageHandler
virtual ~GpuMessageHandler();
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
- // Mesages
+ // Messages
void OnBeginTracing(const ListValue* list);
void OnEndTracingAsync(const ListValue* list);
void OnBrowserBridgeInitialized(const ListValue* list);
@@ -90,8 +90,10 @@ class GpuMessageHandler
Value* OnRequestLogMessages(const ListValue* list);
// SelectFileDialog::Listener implementation
- virtual void FileSelected(const FilePath& path, int index, void* params);
- virtual void FileSelectionCanceled(void* params);
+ virtual void FileSelected(const FilePath& path,
+ int index,
+ void* params) OVERRIDE;
+ virtual void FileSelectionCanceled(void* params) OVERRIDE;
// Callbacks.
void OnGpuInfoUpdate();
@@ -99,9 +101,9 @@ class GpuMessageHandler
void SaveTraceFileComplete();
// TraceSubscriber implementation.
- virtual void OnEndTracingComplete();
- virtual void OnTraceDataCollected(const std::string& json_events);
- virtual void OnTraceBufferPercentFullReply(float percent_full);
+ virtual void OnEndTracingComplete() OVERRIDE;
+ virtual void OnTraceDataCollected(const std::string& json_events) OVERRIDE;
+ virtual void OnTraceBufferPercentFullReply(float percent_full) OVERRIDE;
// Executes the javascript function |function_name| in the renderer, passing
// it the argument |value|.
diff --git a/chrome/browser/ui/webui/history2_ui.h b/chrome/browser/ui/webui/history2_ui.h
index cdc8c26..ca2fa55 100644
--- a/chrome/browser/ui/webui/history2_ui.h
+++ b/chrome/browser/ui/webui/history2_ui.h
@@ -46,8 +46,8 @@ class BrowsingHistoryHandler2 : public WebUIMessageHandler,
virtual ~BrowsingHistoryHandler2();
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
// Callback for the "getHistory" message.
void HandleGetHistory(const base::ListValue* args);
@@ -64,7 +64,7 @@ class BrowsingHistoryHandler2 : public WebUIMessageHandler,
// NotificationObserver implementation.
virtual void Observe(int type,
const NotificationSource& source,
- const NotificationDetails& details);
+ const NotificationDetails& details) OVERRIDE;
private:
// Callback from the history system when the history list is available.
diff --git a/chrome/browser/ui/webui/history_ui.cc b/chrome/browser/ui/webui/history_ui.cc
index 9fa45b7..4019b18 100644
--- a/chrome/browser/ui/webui/history_ui.cc
+++ b/chrome/browser/ui/webui/history_ui.cc
@@ -63,9 +63,9 @@ class HistoryUIHTMLSource : public ChromeWebUIDataSource {
// the path we registered.
virtual void StartDataRequest(const std::string& path,
bool is_incognito,
- int request_id);
+ int request_id) OVERRIDE;
- virtual std::string GetMimeType(const std::string& path) const;
+ virtual std::string GetMimeType(const std::string& path) const OVERRIDE;
private:
~HistoryUIHTMLSource();
diff --git a/chrome/browser/ui/webui/history_ui.h b/chrome/browser/ui/webui/history_ui.h
index 4f8197f..fd36429 100644
--- a/chrome/browser/ui/webui/history_ui.h
+++ b/chrome/browser/ui/webui/history_ui.h
@@ -25,8 +25,8 @@ class BrowsingHistoryHandler : public WebUIMessageHandler,
virtual ~BrowsingHistoryHandler();
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
// Callback for the "getHistory" message.
void HandleGetHistory(const base::ListValue* args);
@@ -43,7 +43,7 @@ class BrowsingHistoryHandler : public WebUIMessageHandler,
// NotificationObserver implementation.
virtual void Observe(int type,
const NotificationSource& source,
- const NotificationDetails& details);
+ const NotificationDetails& details) OVERRIDE;
private:
// Callback from the history system when the history list is available.
diff --git a/chrome/browser/ui/webui/html_dialog_ui.h b/chrome/browser/ui/webui/html_dialog_ui.h
index eb34963..de3b52c 100644
--- a/chrome/browser/ui/webui/html_dialog_ui.h
+++ b/chrome/browser/ui/webui/html_dialog_ui.h
@@ -107,7 +107,7 @@ class HtmlDialogUI : public ChromeWebUI {
private:
// WebUI
- virtual void RenderViewCreated(RenderViewHost* render_view_host);
+ virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE;
// JS message handler.
void OnDialogClosed(const base::ListValue* args);
diff --git a/chrome/browser/ui/webui/keyboard_ui.h b/chrome/browser/ui/webui/keyboard_ui.h
index b2d42c8..18be90d 100644
--- a/chrome/browser/ui/webui/keyboard_ui.h
+++ b/chrome/browser/ui/webui/keyboard_ui.h
@@ -26,8 +26,8 @@ class KeyboardUI : public ChromeWebUI {
// Overrides from DataSource
virtual void StartDataRequest(const std::string& path,
bool is_incognito,
- int request_id);
- virtual std::string GetMimeType(const std::string&) const;
+ int request_id) OVERRIDE;
+ virtual std::string GetMimeType(const std::string&) const OVERRIDE;
private:
virtual ~KeyboardHTMLSource() {}
diff --git a/chrome/browser/ui/webui/media/media_internals_handler.h b/chrome/browser/ui/webui/media/media_internals_handler.h
index c275766..e9bdb00 100644
--- a/chrome/browser/ui/webui/media/media_internals_handler.h
+++ b/chrome/browser/ui/webui/media/media_internals_handler.h
@@ -22,8 +22,8 @@ class MediaInternalsMessageHandler : public WebUIMessageHandler {
virtual ~MediaInternalsMessageHandler();
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
// Javascript message handlers.
void OnGetEverything(const base::ListValue* list);
diff --git a/chrome/browser/ui/webui/net_internals_ui.cc b/chrome/browser/ui/webui/net_internals_ui.cc
index 154343c..548b50c 100644
--- a/chrome/browser/ui/webui/net_internals_ui.cc
+++ b/chrome/browser/ui/webui/net_internals_ui.cc
@@ -160,8 +160,8 @@ class NetInternalsMessageHandler
virtual ~NetInternalsMessageHandler();
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
// Calls g_browser.receive in the renderer, passing in |command| and |arg|.
// Takes ownership of |arg|. If the renderer is displaying a log file, the
@@ -171,7 +171,7 @@ class NetInternalsMessageHandler
// NotificationObserver implementation.
virtual void Observe(int type,
const NotificationSource& source,
- const NotificationDetails& details);
+ const NotificationDetails& details) OVERRIDE;
// Javascript message handlers.
void OnRendererReady(const ListValue* list);
diff --git a/chrome/browser/ui/webui/new_profile_handler.h b/chrome/browser/ui/webui/new_profile_handler.h
index f4518c0..fc94ff9 100644
--- a/chrome/browser/ui/webui/new_profile_handler.h
+++ b/chrome/browser/ui/webui/new_profile_handler.h
@@ -20,7 +20,7 @@ class NewProfileHandler : public WebUIMessageHandler {
NewProfileHandler();
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// Callback for the "create" message - finishes creating a profile.
void HandleCreate(const base::ListValue* args);
diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.h b/chrome/browser/ui/webui/ntp/app_launcher_handler.h
index 68ed8dc..7d6305c 100644
--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.h
+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.h
@@ -50,13 +50,13 @@ class AppLauncherHandler : public WebUIMessageHandler,
static bool HandlePing(Profile* profile, const std::string& path);
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
// NotificationObserver
virtual void Observe(int type,
const NotificationSource& source,
- const NotificationDetails& details);
+ const NotificationDetails& details) OVERRIDE;
// Populate the given dictionary with all installed app info.
void FillAppDictionary(base::DictionaryValue* value);
@@ -125,12 +125,12 @@ class AppLauncherHandler : public WebUIMessageHandler,
void PromptToEnableApp(const std::string& extension_id);
// ExtensionUninstallDialog::Delegate:
- virtual void ExtensionDialogAccepted();
- virtual void ExtensionDialogCanceled();
+ virtual void ExtensionDialogAccepted() OVERRIDE;
+ virtual void ExtensionDialogCanceled() OVERRIDE;
// ExtensionInstallUI::Delegate:
- virtual void InstallUIProceed();
- virtual void InstallUIAbort(bool user_initiated);
+ virtual void InstallUIProceed() OVERRIDE;
+ virtual void InstallUIAbort(bool user_initiated) OVERRIDE;
// Returns the ExtensionUninstallDialog object for this class, creating it if
// needed.
diff --git a/chrome/browser/ui/webui/ntp/bookmarks_handler.h b/chrome/browser/ui/webui/ntp/bookmarks_handler.h
index 6fa0128..91d5205 100644
--- a/chrome/browser/ui/webui/ntp/bookmarks_handler.h
+++ b/chrome/browser/ui/webui/ntp/bookmarks_handler.h
@@ -17,12 +17,12 @@ class BookmarksHandler : public WebUIMessageHandler,
virtual ~BookmarksHandler();
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// NotificationObserver
virtual void Observe(int type,
const NotificationSource& source,
- const NotificationDetails& details);
+ const NotificationDetails& details) OVERRIDE;
private:
DISALLOW_COPY_AND_ASSIGN(BookmarksHandler);
diff --git a/chrome/browser/ui/webui/ntp/favicon_webui_handler.h b/chrome/browser/ui/webui/ntp/favicon_webui_handler.h
index 30c40f0..08c906f 100644
--- a/chrome/browser/ui/webui/ntp/favicon_webui_handler.h
+++ b/chrome/browser/ui/webui/ntp/favicon_webui_handler.h
@@ -26,7 +26,7 @@ class FaviconWebUIHandler : public WebUIMessageHandler {
virtual ~FaviconWebUIHandler();
// WebUIMessageHandler
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
void HandleGetFaviconDominantColor(const base::ListValue* args);
diff --git a/chrome/browser/ui/webui/ntp/foreign_session_handler.h b/chrome/browser/ui/webui/ntp/foreign_session_handler.h
index 0bb190e..2846eae 100644
--- a/chrome/browser/ui/webui/ntp/foreign_session_handler.h
+++ b/chrome/browser/ui/webui/ntp/foreign_session_handler.h
@@ -32,7 +32,7 @@ class ForeignSessionHandler : public WebUIMessageHandler,
// Determines how ForeignSessionHandler will interact with the new tab page.
virtual void Observe(int type,
const NotificationSource& source,
- const NotificationDetails& details);
+ const NotificationDetails& details) OVERRIDE;
// Returns a pointer to the current session model associator or NULL.
SessionModelAssociator* GetModelAssociator();
diff --git a/chrome/browser/ui/webui/ntp/most_visited_handler.h b/chrome/browser/ui/webui/ntp/most_visited_handler.h
index adc8afb..dfef887 100644
--- a/chrome/browser/ui/webui/ntp/most_visited_handler.h
+++ b/chrome/browser/ui/webui/ntp/most_visited_handler.h
@@ -42,8 +42,8 @@ class MostVisitedHandler : public WebUIMessageHandler,
virtual ~MostVisitedHandler();
// WebUIMessageHandler override and implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
// Callback for the "getMostVisited" message.
void HandleGetMostVisited(const base::ListValue* args);
@@ -66,7 +66,7 @@ class MostVisitedHandler : public WebUIMessageHandler,
// NotificationObserver implementation.
virtual void Observe(int type,
const NotificationSource& source,
- const NotificationDetails& details);
+ const NotificationDetails& details) OVERRIDE;
const std::vector<GURL>& most_visited_urls() const {
return most_visited_urls_;
diff --git a/chrome/browser/ui/webui/ntp/new_tab_page_handler.h b/chrome/browser/ui/webui/ntp/new_tab_page_handler.h
index ba2566a..9cfa1588 100644
--- a/chrome/browser/ui/webui/ntp/new_tab_page_handler.h
+++ b/chrome/browser/ui/webui/ntp/new_tab_page_handler.h
@@ -19,7 +19,7 @@ class NewTabPageHandler : public WebUIMessageHandler {
virtual ~NewTabPageHandler() {}
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// Callback for "closePromo".
void HandleClosePromo(const ListValue* args);
diff --git a/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h b/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h
index 2edc464..9ebb02f 100644
--- a/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h
+++ b/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h
@@ -25,8 +25,8 @@ class NewTabPageSyncHandler : public WebUIMessageHandler,
virtual ~NewTabPageSyncHandler();
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
// Callback for "GetSyncMessage".
void HandleGetSyncMessage(const base::ListValue* args);
@@ -34,7 +34,7 @@ class NewTabPageSyncHandler : public WebUIMessageHandler,
void HandleSyncLinkClicked(const base::ListValue* args);
// ProfileSyncServiceObserver
- virtual void OnStateChanged();
+ virtual void OnStateChanged() OVERRIDE;
private:
enum MessageType {
diff --git a/chrome/browser/ui/webui/ntp/new_tab_ui.cc b/chrome/browser/ui/webui/ntp/new_tab_ui.cc
index 4bd36ac..bd1e852 100644
--- a/chrome/browser/ui/webui/ntp/new_tab_ui.cc
+++ b/chrome/browser/ui/webui/ntp/new_tab_ui.cc
@@ -85,7 +85,7 @@ class MetricsHandler : public WebUIMessageHandler {
virtual ~MetricsHandler() {}
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// Callback which records a user action.
void HandleRecordAction(const ListValue* args);
diff --git a/chrome/browser/ui/webui/ntp/new_tab_ui.h b/chrome/browser/ui/webui/ntp/new_tab_ui.h
index 670f206..af1cc47 100644
--- a/chrome/browser/ui/webui/ntp/new_tab_ui.h
+++ b/chrome/browser/ui/webui/ntp/new_tab_ui.h
@@ -30,8 +30,8 @@ class NewTabUI : public ChromeWebUI,
// Override WebUI methods so we can hook up the paint timer to the render
// view host.
- virtual void RenderViewCreated(RenderViewHost* render_view_host);
- virtual void RenderViewReused(RenderViewHost* render_view_host);
+ virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE;
+ virtual void RenderViewReused(RenderViewHost* render_view_host) OVERRIDE;
static void RegisterUserPrefs(PrefService* prefs);
static void MigrateUserPrefs(PrefService* prefs, int old_pref_version,
@@ -58,9 +58,9 @@ class NewTabUI : public ChromeWebUI,
// the path we registered.
virtual void StartDataRequest(const std::string& path,
bool is_incognito,
- int request_id);
+ int request_id) OVERRIDE;
- virtual std::string GetMimeType(const std::string&) const;
+ virtual std::string GetMimeType(const std::string&) const OVERRIDE;
virtual bool ShouldReplaceExistingSource() const;
diff --git a/chrome/browser/ui/webui/ntp/ntp_login_handler.h b/chrome/browser/ui/webui/ntp/ntp_login_handler.h
index 5811f40..ba8695f 100644
--- a/chrome/browser/ui/webui/ntp/ntp_login_handler.h
+++ b/chrome/browser/ui/webui/ntp/ntp_login_handler.h
@@ -19,15 +19,15 @@ class NTPLoginHandler : public WebUIMessageHandler,
NTPLoginHandler();
virtual ~NTPLoginHandler();
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
// WebUIMessageHandler interface
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// NotificationObserver interface
virtual void Observe(int type,
const NotificationSource& source,
- const NotificationDetails& details);
+ const NotificationDetails& details) OVERRIDE;
private:
// Called from JS when the NTP is loaded.
diff --git a/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.h b/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.h
index 00e2777..3fe981a 100644
--- a/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.h
+++ b/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.h
@@ -19,7 +19,7 @@ class RecentlyClosedTabsHandler : public WebUIMessageHandler,
virtual ~RecentlyClosedTabsHandler();
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// Callback for the "reopenTab" message. Rewrites the history of the
// currently displayed tab to be the one in TabRestoreService with a
@@ -32,11 +32,11 @@ class RecentlyClosedTabsHandler : public WebUIMessageHandler,
// Observer callback for TabRestoreServiceObserver. Sends data on
// recently closed tabs to the javascript side of this page to
// display to the user.
- virtual void TabRestoreServiceChanged(TabRestoreService* service);
+ virtual void TabRestoreServiceChanged(TabRestoreService* service) OVERRIDE;
// Observer callback to notice when our associated TabRestoreService
// is destroyed.
- virtual void TabRestoreServiceDestroyed(TabRestoreService* service);
+ virtual void TabRestoreServiceDestroyed(TabRestoreService* service) OVERRIDE;
// Converts a list of TabRestoreService entries to the JSON format required
// by the NTP and adds them to the given list value.
diff --git a/chrome/browser/ui/webui/ntp/shown_sections_handler.h b/chrome/browser/ui/webui/ntp/shown_sections_handler.h
index e7a957e..af99c1f 100644
--- a/chrome/browser/ui/webui/ntp/shown_sections_handler.h
+++ b/chrome/browser/ui/webui/ntp/shown_sections_handler.h
@@ -50,12 +50,12 @@ class ShownSectionsHandler : public WebUIMessageHandler,
static void SetShownSection(PrefService* prefs, Section section);
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// NotificationObserver implementation.
virtual void Observe(int type,
const NotificationSource& source,
- const NotificationDetails& details);
+ const NotificationDetails& details) OVERRIDE;
// Callback for "setShownSections" message.
void HandleSetShownSections(const base::ListValue* args);
diff --git a/chrome/browser/ui/webui/options/options_ui.h b/chrome/browser/ui/webui/options/options_ui.h
index d4a27f8..53b0ec3 100644
--- a/chrome/browser/ui/webui/options/options_ui.h
+++ b/chrome/browser/ui/webui/options/options_ui.h
@@ -41,12 +41,12 @@ class OptionsPageUIHandler : public WebUIMessageHandler,
virtual void Uninitialize() {}
// WebUIMessageHandler implementation.
- virtual void RegisterMessages() {}
+ virtual void RegisterMessages() OVERRIDE {}
// NotificationObserver implementation.
virtual void Observe(int type,
const NotificationSource& source,
- const NotificationDetails& details) {}
+ const NotificationDetails& details) OVERRIDE {}
void UserMetricsRecordAction(const UserMetricsAction& action);
diff --git a/chrome/browser/ui/webui/plugins_ui.cc b/chrome/browser/ui/webui/plugins_ui.cc
index f97e82b..d7ab1b0 100644
--- a/chrome/browser/ui/webui/plugins_ui.cc
+++ b/chrome/browser/ui/webui/plugins_ui.cc
@@ -101,8 +101,8 @@ class PluginsDOMHandler : public WebUIMessageHandler,
virtual ~PluginsDOMHandler() {}
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
// Callback for the "requestPluginsData" message.
void HandleRequestPluginsData(const ListValue* args);
@@ -117,9 +117,9 @@ class PluginsDOMHandler : public WebUIMessageHandler,
void HandleGetShowDetails(const ListValue* args);
// NotificationObserver method overrides
- void Observe(int type,
- const NotificationSource& source,
- const NotificationDetails& details);
+ virtual void Observe(int type,
+ const NotificationSource& source,
+ const NotificationDetails& details) OVERRIDE;
private:
// This extra wrapper is used to ensure we don't leak the ListValue* pointer
diff --git a/chrome/browser/ui/webui/print_preview_handler.h b/chrome/browser/ui/webui/print_preview_handler.h
index 779b460..1a354e4 100644
--- a/chrome/browser/ui/webui/print_preview_handler.h
+++ b/chrome/browser/ui/webui/print_preview_handler.h
@@ -36,14 +36,16 @@ class PrintPreviewHandler : public WebUIMessageHandler,
virtual ~PrintPreviewHandler();
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// SelectFileDialog::Listener implementation.
- virtual void FileSelected(const FilePath& path, int index, void* params);
- virtual void FileSelectionCanceled(void* params);
+ virtual void FileSelected(const FilePath& path,
+ int index,
+ void* params) OVERRIDE;
+ virtual void FileSelectionCanceled(void* params) OVERRIDE;
// PrintViewManagerObserver implementation.
- virtual void OnPrintDialogShown();
+ virtual void OnPrintDialogShown() OVERRIDE;
// Displays a modal dialog, prompting the user to select a file.
void SelectFile(const FilePath& default_path);
diff --git a/chrome/browser/ui/webui/quota_internals_ui.h b/chrome/browser/ui/webui/quota_internals_ui.h
index d954fdb..d805b2b 100644
--- a/chrome/browser/ui/webui/quota_internals_ui.h
+++ b/chrome/browser/ui/webui/quota_internals_ui.h
@@ -29,7 +29,7 @@ class QuotaInternalsHTMLSource : public ChromeWebUIDataSource {
virtual void StartDataRequest(const std::string& path,
bool is_incognito,
int request_id) OVERRIDE;
- virtual std::string GetMimeType(const std::string& path) const;
+ virtual std::string GetMimeType(const std::string& path) const OVERRIDE;
private:
virtual ~QuotaInternalsHTMLSource() {}
diff --git a/chrome/browser/ui/webui/sessions_ui.cc b/chrome/browser/ui/webui/sessions_ui.cc
index 7d78573..e9e0e0c 100644
--- a/chrome/browser/ui/webui/sessions_ui.cc
+++ b/chrome/browser/ui/webui/sessions_ui.cc
@@ -62,8 +62,8 @@ class SessionsDOMHandler : public WebUIMessageHandler {
virtual ~SessionsDOMHandler();
// WebUIMessageHandler implementation.
- virtual WebUIMessageHandler* Attach(WebUI* web_ui);
- virtual void RegisterMessages();
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
+ virtual void RegisterMessages() OVERRIDE;
private:
// Asynchronously fetches the session list. Called from JS.
diff --git a/chrome/browser/ui/webui/textfields_ui.h b/chrome/browser/ui/webui/textfields_ui.h
index d00ae2b..4d56093 100644
--- a/chrome/browser/ui/webui/textfields_ui.h
+++ b/chrome/browser/ui/webui/textfields_ui.h
@@ -49,7 +49,7 @@ class TextfieldsDOMHandler : public WebUIMessageHandler {
virtual void HandleTextfieldValue(const base::ListValue* args);
protected:
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
private:
DISALLOW_COPY_AND_ASSIGN(TextfieldsDOMHandler);
diff --git a/chrome/browser/ui/webui/web_ui_test_handler.h b/chrome/browser/ui/webui/web_ui_test_handler.h
index 185e69b..b5b2251f 100644
--- a/chrome/browser/ui/webui/web_ui_test_handler.h
+++ b/chrome/browser/ui/webui/web_ui_test_handler.h
@@ -21,7 +21,7 @@ class WebUITestHandler : public WebUIMessageHandler,
private:
// WebUIMessageHandler overrides.
// Add test handlers to the current WebUI object.
- virtual void RegisterMessages() {}
+ virtual void RegisterMessages() OVERRIDE {}
// From NotificationObserver.
virtual void Observe(int type,
diff --git a/chrome/browser/ui/webui/workers_ui.cc b/chrome/browser/ui/webui/workers_ui.cc
index 3c538eb..a471422 100644
--- a/chrome/browser/ui/webui/workers_ui.cc
+++ b/chrome/browser/ui/webui/workers_ui.cc
@@ -111,7 +111,7 @@ class WorkersDOMHandler : public WebUIMessageHandler {
private:
// WebUIMessageHandler implementation.
- virtual void RegisterMessages();
+ virtual void RegisterMessages() OVERRIDE;
// Callback for "openDevTools" message.
void HandleOpenDevTools(const ListValue* args);