diff options
| author | beng@google.com <beng@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-08 18:01:31 +0000 |
|---|---|---|
| committer | beng@google.com <beng@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-08 18:01:31 +0000 |
| commit | 650a1a76e2efb22ecf35fc26ee9db7371b1ef5b2 (patch) | |
| tree | 6de31ba086cbc0f5f659591eeefe0d0bfe9926a7 /chrome | |
| parent | 49fda735afc5f31c3036191efb20f72576aff8a9 (diff) | |
| download | chromium_src-650a1a76e2efb22ecf35fc26ee9db7371b1ef5b2.zip chromium_src-650a1a76e2efb22ecf35fc26ee9db7371b1ef5b2.tar.gz chromium_src-650a1a76e2efb22ecf35fc26ee9db7371b1ef5b2.tar.bz2 | |
A couple of quick TODO and other cleanups.
B=1031854
Review URL: http://codereview.chromium.org/1624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1850 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
4 files changed, 1 insertions, 13 deletions
diff --git a/chrome/browser/views/frame/aero_glass_frame.cc b/chrome/browser/views/frame/aero_glass_frame.cc index ba24e60..2ebbea4 100644 --- a/chrome/browser/views/frame/aero_glass_frame.cc +++ b/chrome/browser/views/frame/aero_glass_frame.cc @@ -63,10 +63,6 @@ gfx::Rect AeroGlassFrame::GetWindowBoundsForClientBounds( return gfx::Rect(rect); } -void AeroGlassFrame::SizeToContents(const gfx::Rect& contents_bounds) { - // TODO(beng): implement me. -} - gfx::Rect AeroGlassFrame::GetBoundsForTabStrip(TabStrip* tabstrip) const { return GetAeroGlassNonClientView()->GetBoundsForTabStrip(tabstrip); } @@ -80,7 +76,6 @@ ChromeViews::Window* AeroGlassFrame::GetWindow() { void AeroGlassFrame::UpdateWindowIcon() { Window::UpdateWindowIcon(); - // TODO(beng): do something in the non-client view when this builds on Vista. } /////////////////////////////////////////////////////////////////////////////// diff --git a/chrome/browser/views/frame/aero_glass_frame.h b/chrome/browser/views/frame/aero_glass_frame.h index ca109cc..0f8ba97 100644 --- a/chrome/browser/views/frame/aero_glass_frame.h +++ b/chrome/browser/views/frame/aero_glass_frame.h @@ -33,7 +33,7 @@ class AeroGlassFrame : public BrowserFrame, // Overridden from BrowserFrame: virtual gfx::Rect GetWindowBoundsForClientBounds( const gfx::Rect& client_bounds); - virtual void SizeToContents(const gfx::Rect& contents_bounds); + virtual void SizeToContents(const gfx::Rect& contents_bounds) {} virtual gfx::Rect GetBoundsForTabStrip(TabStrip* tabstrip) const; virtual ChromeViews::Window* GetWindow(); diff --git a/chrome/browser/views/frame/aero_glass_non_client_view.cc b/chrome/browser/views/frame/aero_glass_non_client_view.cc index 4648484..a9d0aa0 100644 --- a/chrome/browser/views/frame/aero_glass_non_client_view.cc +++ b/chrome/browser/views/frame/aero_glass_non_client_view.cc @@ -226,11 +226,6 @@ void AeroGlassNonClientView::Paint(ChromeCanvas* canvas) { PaintToolbarBackground(canvas); PaintClientEdge(canvas); } - - // TODO(beng): remove this - gfx::Rect contents_bounds = browser_view_->GetClientAreaBounds(); - canvas->FillRectInt(SK_ColorGRAY, contents_bounds.x(), contents_bounds.y(), - contents_bounds.width(), contents_bounds.height()); } void AeroGlassNonClientView::Layout() { diff --git a/chrome/browser/views/frame/opaque_non_client_view.cc b/chrome/browser/views/frame/opaque_non_client_view.cc index be7b36a..eaa2af1 100644 --- a/chrome/browser/views/frame/opaque_non_client_view.cc +++ b/chrome/browser/views/frame/opaque_non_client_view.cc @@ -453,8 +453,6 @@ OpaqueNonClientView::~OpaqueNonClientView() { gfx::Rect OpaqueNonClientView::GetWindowBoundsForClientBounds( const gfx::Rect& client_bounds) { int top_height = CalculateNonClientTopHeight(); - // TODO(beng): support popups. - //top_height += browser_view_->GetToolbarHeightForPopup(); int window_x = std::max(0, client_bounds.x() - kWindowHorizontalBorderSize); int window_y = std::max(0, client_bounds.y() - top_height); int window_w = client_bounds.width() + (2 * kWindowHorizontalBorderSize); |