summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authorrafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-12-23 02:24:58 +0000
committerrafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-12-23 02:24:58 +0000
commit6ab764bdbed6489c5eaf5f50923bce20bcf6c854 (patch)
tree6bae1c8ce825799ecc299407173f12b68db55b2e /chrome
parent6794ec581c6a33e1f600d3eae65c276bd7d1a0ed (diff)
downloadchromium_src-6ab764bdbed6489c5eaf5f50923bce20bcf6c854.zip
chromium_src-6ab764bdbed6489c5eaf5f50923bce20bcf6c854.tar.gz
chromium_src-6ab764bdbed6489c5eaf5f50923bce20bcf6c854.tar.bz2
Revert "Disallow chrome.tabs.executeScript from injecting code into gallery"
This reverts commit 699f771db23a92c9966fd9af92f0c69886d58136. TBR=rvargas Review URL: http://codereview.chromium.org/516005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35201 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/browser/extensions/execute_code_in_tab_function.cc11
-rw-r--r--chrome/browser/extensions/extension_tabs_module_constants.cc2
-rw-r--r--chrome/browser/extensions/extension_tabs_module_constants.h1
-rw-r--r--chrome/renderer/render_view.cc8
4 files changed, 0 insertions, 22 deletions
diff --git a/chrome/browser/extensions/execute_code_in_tab_function.cc b/chrome/browser/extensions/execute_code_in_tab_function.cc
index 3d15458..5dc6690 100644
--- a/chrome/browser/extensions/execute_code_in_tab_function.cc
+++ b/chrome/browser/extensions/execute_code_in_tab_function.cc
@@ -11,7 +11,6 @@
#include "chrome/browser/extensions/file_reader.h"
#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/common/extensions/extension.h"
-#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/extension_error_utils.h"
namespace keys = extension_tabs_module_constants;
@@ -69,16 +68,6 @@ bool ExecuteCodeInTabFunction::RunImpl() {
DCHECK(browser);
DCHECK(contents);
- // Disallow executeScript when the target contents is a gallery page.
- // This mirrors a check in UserScriptSlave::InjectScripts
- // NOTE: This can give the wrong answer due to race conditions, but it is OK,
- // we check again in the renderer.
- if (contents->GetURL().host() ==
- GURL(extension_urls::kGalleryBrowsePrefix).host()) {
- error_ = keys::kCannotScriptGalleryError;
- return false;
- }
-
// NOTE: This can give the wrong answer due to race conditions, but it is OK,
// we check again in the renderer.
if (!GetExtension()->CanAccessHost(contents->GetURL())) {
diff --git a/chrome/browser/extensions/extension_tabs_module_constants.cc b/chrome/browser/extensions/extension_tabs_module_constants.cc
index 0d21460..a3fc48d 100644
--- a/chrome/browser/extensions/extension_tabs_module_constants.cc
+++ b/chrome/browser/extensions/extension_tabs_module_constants.cc
@@ -44,8 +44,6 @@ const char kInternalVisibleTabCaptureError[] =
const char kNotImplementedError[] = "This call is not yet implemented";
const char kCannotAccessPageError[] = "Cannot access contents of url \"*\". "
"Extension manifest must request permission to access this host.";
-const char kCannotScriptGalleryError[] = "The extensions gallery cannot be "
- "scripted.";
const char kSupportedInWindowsOnlyError[] = "Supported in Windows only";
const char kNoCodeOrFileToExecuteError[] = "No source code or file specified.";
diff --git a/chrome/browser/extensions/extension_tabs_module_constants.h b/chrome/browser/extensions/extension_tabs_module_constants.h
index a8bf1ac..6e0967d 100644
--- a/chrome/browser/extensions/extension_tabs_module_constants.h
+++ b/chrome/browser/extensions/extension_tabs_module_constants.h
@@ -48,7 +48,6 @@ extern const char kInvalidUrlError[];
extern const char kInternalVisibleTabCaptureError[];
extern const char kNotImplementedError[];
extern const char kCannotAccessPageError[];
-extern const char kCannotScriptGalleryError[];
extern const char kSupportedInWindowsOnlyError[];
extern const char kNoCodeOrFileToExecuteError[];
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index eda13e57..6313755 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -26,7 +26,6 @@
#include "chrome/common/child_process_logging.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/chrome_constants.h"
-#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/jstemplate_builder.h"
#include "chrome/common/page_zoom.h"
#include "chrome/common/plugin_messages.h"
@@ -3842,13 +3841,6 @@ void RenderView::OnExecuteCode(const ViewMsg_ExecuteCode_Params& params) {
void RenderView::ExecuteCodeImpl(WebFrame* frame,
const ViewMsg_ExecuteCode_Params& params) {
- // Don't execute scripts in gallery pages.
- GURL frame_url = GURL(frame->url());
- if (frame_url.host() == GURL(extension_urls::kGalleryBrowsePrefix).host()) {
- Send(new ViewMsg_ExecuteCodeFinished(routing_id_, request_id, true));
- return;
- }
-
std::vector<WebFrame*> frame_vector;
frame_vector.push_back(frame);
if (params.all_frames)