diff options
| author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-30 17:42:38 +0000 |
|---|---|---|
| committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-30 17:42:38 +0000 |
| commit | 7de8b59cd42e9bd59dd6cf541514ea79b1d2e70a (patch) | |
| tree | 22e9d7d14a937f3046882d80e129d79a57812f95 /chrome | |
| parent | fe30d76fe491d8c1b2ba19dc4e6185ca2295c67e (diff) | |
| download | chromium_src-7de8b59cd42e9bd59dd6cf541514ea79b1d2e70a.zip chromium_src-7de8b59cd42e9bd59dd6cf541514ea79b1d2e70a.tar.gz chromium_src-7de8b59cd42e9bd59dd6cf541514ea79b1d2e70a.tar.bz2 | |
Tentative fix for the Clang mac build.
The Clang mac build does not compile the EXPECT_EQ(false, blah...
statements. I'm not sure why, and it doesn't reproduce on my Linux box,
but hopefully this should green the bot. In any case, I believe
EXPECT_FALSE is the preferred style.
TEST=unit_tests
BUG=none
Review URL: http://codereview.chromium.org/5329008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67718 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/content_settings/host_content_settings_map_unittest.cc | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/chrome/browser/content_settings/host_content_settings_map_unittest.cc b/chrome/browser/content_settings/host_content_settings_map_unittest.cc index 223b08f..5f6bf5c 100644 --- a/chrome/browser/content_settings/host_content_settings_map_unittest.cc +++ b/chrome/browser/content_settings/host_content_settings_map_unittest.cc @@ -995,24 +995,21 @@ TEST_F(HostContentSettingsMapTest, ResetToDefaultsWhenManaged) { prefs->SetUserPref(prefs::kBlockThirdPartyCookies, Value::CreateBooleanValue(true)); - EXPECT_EQ(true, - host_content_settings_map->IsBlockThirdPartyCookiesManaged()); - EXPECT_EQ(true, host_content_settings_map->BlockThirdPartyCookies()); + EXPECT_TRUE(host_content_settings_map->IsBlockThirdPartyCookiesManaged()); + EXPECT_TRUE(host_content_settings_map->BlockThirdPartyCookies()); // Reset to the default value (false). host_content_settings_map->ResetToDefaults(); // Since the preference BlockThirdPartyCookies is managed the // HostContentSettingsMap should still return the managed value which is true. - EXPECT_EQ(true, - host_content_settings_map->IsBlockThirdPartyCookiesManaged()); - EXPECT_EQ(true, host_content_settings_map->BlockThirdPartyCookies()); + EXPECT_TRUE(host_content_settings_map->IsBlockThirdPartyCookiesManaged()); + EXPECT_TRUE(host_content_settings_map->BlockThirdPartyCookies()); // After unsetting the managed value for the preference BlockThirdPartyCookies // the default value should be returned now. prefs->RemoveManagedPref(prefs::kBlockThirdPartyCookies); - EXPECT_EQ(false, - host_content_settings_map->IsBlockThirdPartyCookiesManaged()); - EXPECT_EQ(false, host_content_settings_map->BlockThirdPartyCookies()); + EXPECT_FALSE(host_content_settings_map->IsBlockThirdPartyCookiesManaged()); + EXPECT_FALSE(host_content_settings_map->BlockThirdPartyCookies()); } } // namespace |