summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authorandybons@chromium.org <andybons@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-08 22:01:38 +0000
committerandybons@chromium.org <andybons@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-08 22:01:38 +0000
commita233a64c05fa151f0a9d1eff6839962d23d82b17 (patch)
treedacb0db9b48ac0b1472fc21b97498241343078db /chrome
parenta5b60ce4f55bd0c36c4b1f9c5710b1f5da2ec64b (diff)
downloadchromium_src-a233a64c05fa151f0a9d1eff6839962d23d82b17.zip
chromium_src-a233a64c05fa151f0a9d1eff6839962d23d82b17.tar.gz
chromium_src-a233a64c05fa151f0a9d1eff6839962d23d82b17.tar.bz2
[Mac] Add metrics to record when a bookmark is DnD'd in the bookmarks bar.
BUG=54690 TEST=none Review URL: http://codereview.chromium.org/3290015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58879 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/browser/cocoa/bookmark_bar_controller.h1
-rw-r--r--chrome/browser/cocoa/bookmark_bar_folder_view.mm2
-rw-r--r--chrome/browser/cocoa/bookmark_bar_view.mm2
-rw-r--r--chrome/browser/cocoa/bookmark_button.mm7
4 files changed, 11 insertions, 1 deletions
diff --git a/chrome/browser/cocoa/bookmark_bar_controller.h b/chrome/browser/cocoa/bookmark_bar_controller.h
index 587cac8..020e8cf 100644
--- a/chrome/browser/cocoa/bookmark_bar_controller.h
+++ b/chrome/browser/cocoa/bookmark_bar_controller.h
@@ -31,7 +31,6 @@ class BookmarkNode;
class Browser;
class GURL;
class PrefService;
-class Profile;
class TabContents;
@class ToolbarController;
@protocol ViewResizer;
diff --git a/chrome/browser/cocoa/bookmark_bar_folder_view.mm b/chrome/browser/cocoa/bookmark_bar_folder_view.mm
index d7fd23f..89d9d2a 100644
--- a/chrome/browser/cocoa/bookmark_bar_folder_view.mm
+++ b/chrome/browser/cocoa/bookmark_bar_folder_view.mm
@@ -6,6 +6,7 @@
#include "chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.h"
#import "chrome/browser/cocoa/bookmark_bar_controller.h"
#import "chrome/browser/cocoa/bookmark_folder_target.h"
+#include "chrome/browser/metrics/user_metrics.h"
#import "third_party/mozilla/NSPasteboard+Utils.h"
@implementation BookmarkBarFolderView
@@ -182,6 +183,7 @@
doDrag = [[self controller] dragButton:button
to:[info draggingLocation]
copy:copy];
+ UserMetrics::RecordAction(UserMetricsAction("BookmarkBarFolder_DragEnd"));
}
return doDrag;
}
diff --git a/chrome/browser/cocoa/bookmark_bar_view.mm b/chrome/browser/cocoa/bookmark_bar_view.mm
index 63e3c3c..ffc8441 100644
--- a/chrome/browser/cocoa/bookmark_bar_view.mm
+++ b/chrome/browser/cocoa/bookmark_bar_view.mm
@@ -10,6 +10,7 @@
#import "chrome/browser/cocoa/bookmark_folder_target.h"
#import "chrome/browser/cocoa/themed_window.h"
#import "chrome/browser/cocoa/view_id_util.h"
+#include "chrome/browser/metrics/user_metrics.h"
#import "chrome/browser/themes/browser_theme_provider.h"
#import "third_party/mozilla/NSPasteboard+Utils.h"
@@ -226,6 +227,7 @@
rtn = [controller_ dragButton:button
to:[info draggingLocation]
copy:copy];
+ UserMetrics::RecordAction(UserMetricsAction("BookmarkBar_DragEnd"));
}
return rtn;
}
diff --git a/chrome/browser/cocoa/bookmark_button.mm b/chrome/browser/cocoa/bookmark_button.mm
index b5f9b86..1a72bda 100644
--- a/chrome/browser/cocoa/bookmark_button.mm
+++ b/chrome/browser/cocoa/bookmark_button.mm
@@ -9,6 +9,7 @@
#import "chrome/browser/cocoa/bookmark_button_cell.h"
#import "chrome/browser/cocoa/browser_window_controller.h"
#import "chrome/browser/cocoa/view_id_util.h"
+#include "chrome/browser/metrics/user_metrics.h"
// The opacity of the bookmark button drag image.
static const CGFloat kDragImageOpacity = 0.7;
@@ -106,6 +107,12 @@ NSString* const kBookmarkPulseFlagKey = @"BookmarkPulseFlagKey";
withAnimation:NO
delay:NO];
}
+ const BookmarkNode* node = [self bookmarkNode];
+ const BookmarkNode* parent = node ? node->GetParent() : NULL;
+ BOOL isWithinFolder = parent && parent->type() == BookmarkNode::FOLDER;
+ UserMetrics::RecordAction(UserMetricsAction(
+ isWithinFolder ? "BookmarkBarFolder_DragStart" :
+ "BookmarkBar_DragStart"));
CGFloat yAt = [self bounds].size.height;
NSSize dragOffset = NSMakeSize(0.0, 0.0);