diff options
author | robertshield@google.com <robertshield@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-14 16:58:29 +0000 |
---|---|---|
committer | robertshield@google.com <robertshield@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-14 16:58:29 +0000 |
commit | 140af009d3d76623b106ee3e5e554d770af0e3c5 (patch) | |
tree | 84ae7d489c7384bea645df5e7d05a081e959591a /chrome | |
parent | 41fe98bb5c0955a12d48527308e359ae577f09bc (diff) | |
download | chromium_src-140af009d3d76623b106ee3e5e554d770af0e3c5.zip chromium_src-140af009d3d76623b106ee3e5e554d770af0e3c5.tar.gz chromium_src-140af009d3d76623b106ee3e5e554d770af0e3c5.tar.bz2 |
Noticed a crash in BrowserRenderProcessHost::SendUserScriptsUpdate due to using channel_->send() directly (instead of BrowserRenderProcessHost::Send() which checks whether channel_ is created).
It looks like this can happen during BrowserRenderProcessHost creation since the brph signs up for notifications at construction but only creates channel_ in its Init() method.
BUG=http://b/15384
Review URL: http://codereview.chromium.org/155498
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20627 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r-- | chrome/browser/renderer_host/browser_render_process_host.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/renderer_host/browser_render_process_host.cc b/chrome/browser/renderer_host/browser_render_process_host.cc index 067fd26..9c435d3 100644 --- a/chrome/browser/renderer_host/browser_render_process_host.cc +++ b/chrome/browser/renderer_host/browser_render_process_host.cc @@ -578,7 +578,7 @@ void BrowserRenderProcessHost::InitVisitedLinks() { DCHECK(r); if (base::SharedMemory::IsHandleValid(handle_for_process)) { - channel_->Send(new ViewMsg_VisitedLink_NewTable(handle_for_process)); + Send(new ViewMsg_VisitedLink_NewTable(handle_for_process)); } } @@ -613,7 +613,7 @@ void BrowserRenderProcessHost::SendUserScriptsUpdate( } if (base::SharedMemory::IsHandleValid(handle_for_process)) { - channel_->Send(new ViewMsg_UserScripts_UpdatedScripts(handle_for_process)); + Send(new ViewMsg_UserScripts_UpdatedScripts(handle_for_process)); } } |