diff options
| author | pfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-28 14:52:00 +0000 |
|---|---|---|
| committer | pfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-28 14:52:00 +0000 |
| commit | 46d77a16ff5c6617e665ab5ac58217f1f8d0c4cd (patch) | |
| tree | ef435537fef44a403d58fc844c784637efd969af /chrome | |
| parent | 67d849de2961bbca55798091ee65bbd25fbc8e69 (diff) | |
| download | chromium_src-46d77a16ff5c6617e665ab5ac58217f1f8d0c4cd.zip chromium_src-46d77a16ff5c6617e665ab5ac58217f1f8d0c4cd.tar.gz chromium_src-46d77a16ff5c6617e665ab5ac58217f1f8d0c4cd.tar.bz2 | |
DevTools: Inspect Element doesn't select element in the Elements Panel when tools are docked.
Original CL: http://http://codereview.chromium.org/2856066/show
Review URL: http://codereview.chromium.org/3058020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53940 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/debugger/devtools_manager.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/browser/debugger/devtools_manager.cc b/chrome/browser/debugger/devtools_manager.cc index 6b958cc..f632cbc 100644 --- a/chrome/browser/debugger/devtools_manager.cc +++ b/chrome/browser/debugger/devtools_manager.cc @@ -162,10 +162,12 @@ void DevToolsManager::RuntimeFeatureStateChanged(RenderViewHost* inspected_rvh, void DevToolsManager::InspectElement(RenderViewHost* inspected_rvh, int x, int y) { - OpenDevToolsWindow(inspected_rvh); IPC::Message* m = new DevToolsAgentMsg_InspectElement(x, y); m->set_routing_id(inspected_rvh->routing_id()); inspected_rvh->Send(m); + // TODO(loislo): we should initiate DevTools window opening from within
+ // renderer. Otherwise, we still can hit a race condition here.
+ OpenDevToolsWindow(inspected_rvh); } void DevToolsManager::ClientHostClosing(DevToolsClientHost* host) { |