diff options
| author | rtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-16 01:26:25 +0000 |
|---|---|---|
| committer | rtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-16 01:26:25 +0000 |
| commit | 9b54971cfb69b55293b096b6e7b2bfda2fb0c57e (patch) | |
| tree | 10fc33f62f3261d59a76d130f2797a15cb4a1d62 /chrome | |
| parent | e4155a7a1fbfb2724f1ee88437ef6723043bb87f (diff) | |
| download | chromium_src-9b54971cfb69b55293b096b6e7b2bfda2fb0c57e.zip chromium_src-9b54971cfb69b55293b096b6e7b2bfda2fb0c57e.tar.gz chromium_src-9b54971cfb69b55293b096b6e7b2bfda2fb0c57e.tar.bz2 | |
Added CHECK for buffer_ and xml_wrapper_ to be not NULL
before accessing them.
BUG=64813
TEST=see bug
Review URL: http://codereview.chromium.org/6273006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71564 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/common/metrics_helpers.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/common/metrics_helpers.cc b/chrome/common/metrics_helpers.cc index c452937..644df78 100644 --- a/chrome/common/metrics_helpers.cc +++ b/chrome/common/metrics_helpers.cc @@ -52,7 +52,7 @@ class MetricsLogBase::XmlWrapper { buffer_(NULL), writer_(NULL) { buffer_ = xmlBufferCreate(); - DCHECK(buffer_); + CHECK(buffer_); #if defined(OS_CHROMEOS) writer_ = xmlNewTextWriterDoc(&doc_, /* compression */ 0); @@ -151,6 +151,8 @@ void MetricsLogBase::CloseLog() { int MetricsLogBase::GetEncodedLogSize() { DCHECK(locked_); + CHECK(xml_wrapper_); + CHECK(xml_wrapper_->buffer()); return xml_wrapper_->buffer()->use; } |