diff options
| author | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-17 22:04:06 +0000 |
|---|---|---|
| committer | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-17 22:04:06 +0000 |
| commit | a1db384f26f8c660e835c05e7e9d3153f4ad4f6f (patch) | |
| tree | 21ac9672a63b8f6dc737977915f0b1191a738b6d /chrome | |
| parent | 1de1aa61414b1769e5e3dcda683ed10ab96de06e (diff) | |
| download | chromium_src-a1db384f26f8c660e835c05e7e9d3153f4ad4f6f.zip chromium_src-a1db384f26f8c660e835c05e7e9d3153f4ad4f6f.tar.gz chromium_src-a1db384f26f8c660e835c05e7e9d3153f4ad4f6f.tar.bz2 | |
Fix for issue 2362: On-demand update hang with "Checking for update..."
We have been restructuring the message loop code lately and the MessageLoop on the file thread is not dispatching messages as it was before. I have changed the file thread to start with type MessageLoop::TYPE_IO, which pumps messages in such a way that Google Update can communicate back to us.
I'm not sure what the best way to test this is but I ran the UI tests and the unit tests and they all pass.
Review URL: http://codereview.chromium.org/2918
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2334 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/browser_process_impl.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc index ac27985..24a3098 100644 --- a/chrome/browser/browser_process_impl.cc +++ b/chrome/browser/browser_process_impl.cc @@ -284,7 +284,9 @@ void BrowserProcessImpl::CreateFileThread() { scoped_ptr<base::Thread> thread( new BrowserProcessSubThread(ChromeThread::FILE)); - if (!thread->Start()) + base::Thread::Options options; + options.message_loop_type = MessageLoop::TYPE_UI; + if (!thread->StartWithOptions(options)) return; file_thread_.swap(thread); } |