diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-18 18:37:40 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-18 18:37:40 +0000 |
| commit | afbfc9ab6fb54dec13118da04f9f2a8046f121c8 (patch) | |
| tree | e18d0a0b61fdc92c81f1c8aed8af6b319f118b3f /chrome | |
| parent | ce04cfd039819bf90c1a1144b282d5f310631131 (diff) | |
| download | chromium_src-afbfc9ab6fb54dec13118da04f9f2a8046f121c8.zip chromium_src-afbfc9ab6fb54dec13118da04f9f2a8046f121c8.tar.gz chromium_src-afbfc9ab6fb54dec13118da04f9f2a8046f121c8.tar.bz2 | |
Re-enable CrashRecoveryBrowserTest.* with additional logging
to help with debugging flakiness issues.
BUG=29331, 57158, 69637
TEST=browser_tests
Review URL: http://codereview.chromium.org/6246006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71673 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/crash_recovery_browsertest.cc | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/chrome/browser/crash_recovery_browsertest.cc b/chrome/browser/crash_recovery_browsertest.cc index 0d84cad..190e798 100644 --- a/chrome/browser/crash_recovery_browsertest.cc +++ b/chrome/browser/crash_recovery_browsertest.cc @@ -17,8 +17,10 @@ namespace { void SimulateRendererCrash(Browser* browser) { browser->OpenURL(GURL(chrome::kAboutCrashURL), GURL(), CURRENT_TAB, PageTransition::TYPED); + LOG(ERROR) << "SimulateRendererCrash, before WaitForNotification"; ui_test_utils::WaitForNotification( NotificationType::TAB_CONTENTS_DISCONNECTED); + LOG(ERROR) << "SimulateRendererCrash, after WaitForNotification"; } } // namespace @@ -28,7 +30,7 @@ class CrashRecoveryBrowserTest : public InProcessBrowserTest { // Test that reload works after a crash. // Disabled, http://crbug.com/29331, http://crbug.com/69637. -IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, DISABLED_Reload) { +IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, Reload) { // The title of the active tab should change each time this URL is loaded. GURL url( "data:text/html,<script>document.title=new Date().valueOf()</script>"); @@ -41,7 +43,9 @@ IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, DISABLED_Reload) { &title_before_crash)); SimulateRendererCrash(browser()); browser()->Reload(CURRENT_TAB); + LOG(ERROR) << "Before WaitForNavigationInCurrentTab"; ASSERT_TRUE(ui_test_utils::WaitForNavigationInCurrentTab(browser())); + LOG(ERROR) << "After WaitForNavigationInCurrentTab"; ASSERT_TRUE(ui_test_utils::GetCurrentTabTitle(browser(), &title_after_crash)); EXPECT_NE(title_before_crash, title_after_crash); @@ -52,7 +56,7 @@ IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, DISABLED_Reload) { // ID of the RenderProcessHost was stale, so the NavigationEntry in the new tab // was not committed. This prevents regression of that bug. // http://crbug.com/57158 - Times out sometimes on all platforms. -IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, DISABLED_LoadInNewTab) { +IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, LoadInNewTab) { const FilePath::CharType* kTitle2File = FILE_PATH_LITERAL("title2.html"); ui_test_utils::NavigateToURL(browser(), @@ -66,7 +70,9 @@ IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, DISABLED_LoadInNewTab) { &title_before_crash)); SimulateRendererCrash(browser()); browser()->Reload(CURRENT_TAB); + LOG(ERROR) << "Before WaitForNavigationInCurrentTab"; ASSERT_TRUE(ui_test_utils::WaitForNavigationInCurrentTab(browser())); + LOG(ERROR) << "After WaitForNavigationInCurrentTab"; ASSERT_TRUE(ui_test_utils::GetCurrentTabTitle(browser(), &title_after_crash)); EXPECT_EQ(title_before_crash, title_after_crash); |