summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authorjcivelli@chromium.org <jcivelli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-04 00:39:07 +0000
committerjcivelli@chromium.org <jcivelli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-04 00:39:07 +0000
commitbb837f9287259862c94155cc59cfc9e1bdfe1258 (patch)
treef23a7dabe56a4b4c9288ea022f65c090a4fc536b /chrome
parentd19e63d5bd3a61fc46bae0c527731c79abb94957 (diff)
downloadchromium_src-bb837f9287259862c94155cc59cfc9e1bdfe1258.zip
chromium_src-bb837f9287259862c94155cc59cfc9e1bdfe1258.tar.gz
chromium_src-bb837f9287259862c94155cc59cfc9e1bdfe1258.tar.bz2
Revert 76825 - Refactor Views accessibility.
BUG=none TEST=none Review URL: http://codereview.chromium.org/6581010 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/6612035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76844 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/browser/accessibility/browser_views_accessibility_browsertest.cc13
-rw-r--r--chrome/browser/autocomplete/autocomplete_accessibility.cc6
-rw-r--r--chrome/browser/autocomplete/autocomplete_edit_view_views.cc6
-rw-r--r--chrome/browser/autocomplete/autocomplete_edit_view_views.h1
-rw-r--r--chrome/browser/autocomplete/autocomplete_edit_view_win.cc14
-rw-r--r--chrome/browser/download/download_browsertest.cc4
-rw-r--r--chrome/browser/renderer_host/render_widget_host_view_win.cc16
-rw-r--r--chrome/browser/ui/views/accessibility_event_router_views.cc38
-rw-r--r--chrome/browser/ui/views/accessibility_event_router_views.h4
-rw-r--r--chrome/browser/ui/views/accessibility_event_router_views_unittest.cc2
-rw-r--r--chrome/browser/ui/views/accessible_pane_view.cc5
-rw-r--r--chrome/browser/ui/views/accessible_pane_view.h17
-rw-r--r--chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc5
-rw-r--r--chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h13
-rw-r--r--chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc21
-rw-r--r--chrome/browser/ui/views/bookmarks/bookmark_bar_view.h40
-rw-r--r--chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc3
-rw-r--r--chrome/browser/ui/views/browser_actions_container.cc20
-rw-r--r--chrome/browser/ui/views/browser_actions_container.h5
-rw-r--r--chrome/browser/ui/views/chrome_views_delegate.cc2
-rw-r--r--chrome/browser/ui/views/chrome_views_delegate.h3
-rw-r--r--chrome/browser/ui/views/download_item_view.cc31
-rw-r--r--chrome/browser/ui/views/download_item_view.h6
-rw-r--r--chrome/browser/ui/views/first_run_search_engine_view.cc11
-rw-r--r--chrome/browser/ui/views/first_run_search_engine_view.h27
-rw-r--r--chrome/browser/ui/views/frame/browser_root_view.cc10
-rw-r--r--chrome/browser/ui/views/frame/browser_root_view.h16
-rw-r--r--chrome/browser/ui/views/frame/browser_view.cc12
-rw-r--r--chrome/browser/ui/views/frame/browser_view.h12
-rw-r--r--chrome/browser/ui/views/frame/opaque_browser_frame_view.cc6
-rw-r--r--chrome/browser/ui/views/frame/opaque_browser_frame_view.h32
-rw-r--r--chrome/browser/ui/views/infobars/infobar_container.cc7
-rw-r--r--chrome/browser/ui/views/infobars/infobar_container.h8
-rw-r--r--chrome/browser/ui/views/infobars/infobar_view.cc20
-rw-r--r--chrome/browser/ui/views/infobars/infobar_view.h19
-rw-r--r--chrome/browser/ui/views/location_bar/location_bar_view.cc10
-rw-r--r--chrome/browser/ui/views/location_bar/location_bar_view.h2
-rw-r--r--chrome/browser/ui/views/location_bar/page_action_image_view.cc7
-rw-r--r--chrome/browser/ui/views/location_bar/page_action_image_view.h18
-rw-r--r--chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc6
-rw-r--r--chrome/browser/ui/views/location_bar/page_action_with_badge_view.h5
-rw-r--r--chrome/browser/ui/views/location_bar/star_view.cc10
-rw-r--r--chrome/browser/ui/views/location_bar/star_view.h18
-rw-r--r--chrome/browser/ui/views/options/general_page_view.cc5
-rw-r--r--chrome/browser/ui/views/options/options_group_view.cc11
-rw-r--r--chrome/browser/ui/views/options/options_group_view.h6
-rw-r--r--chrome/browser/ui/views/options/options_page_view.cc5
-rw-r--r--chrome/browser/ui/views/options/options_page_view.h4
-rw-r--r--chrome/browser/ui/views/options/options_window_view.cc29
-rw-r--r--chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc6
-rw-r--r--chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.h2
-rw-r--r--chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc7
-rw-r--r--chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.h2
-rw-r--r--chrome/browser/ui/views/tab_contents/tab_contents_container.cc5
-rw-r--r--chrome/browser/ui/views/tab_contents/tab_contents_container_native.h8
-rw-r--r--chrome/browser/ui/views/tab_contents/tab_contents_container_views.h4
-rw-r--r--chrome/browser/ui/views/tabs/base_tab.cc13
-rw-r--r--chrome/browser/ui/views/tabs/base_tab.h27
-rw-r--r--chrome/browser/ui/views/tabs/tab_strip.cc6
-rw-r--r--chrome/browser/ui/views/tabs/tab_strip.h39
-rw-r--r--chrome/browser/ui/views/toolbar_view.cc6
-rw-r--r--chrome/browser/ui/views/toolbar_view.h48
-rw-r--r--chrome/browser/ui/views/wrench_menu.cc1
63 files changed, 358 insertions, 407 deletions
diff --git a/chrome/browser/accessibility/browser_views_accessibility_browsertest.cc b/chrome/browser/accessibility/browser_views_accessibility_browsertest.cc
index a498c36..40c60cb5d 100644
--- a/chrome/browser/accessibility/browser_views_accessibility_browsertest.cc
+++ b/chrome/browser/accessibility/browser_views_accessibility_browsertest.cc
@@ -17,9 +17,8 @@
#include "chrome/test/ui_test_utils.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
-#include "ui/base/accessibility/accessibility_types.h"
#include "ui/base/l10n/l10n_util.h"
-#include "views/accessibility/native_view_accessibility_win.h"
+#include "views/accessibility/view_accessibility.h"
#include "views/widget/root_view.h"
#include "views/widget/widget_win.h"
#include "views/window/window.h"
@@ -29,7 +28,7 @@ namespace {
VARIANT id_self = {VT_I4, CHILDID_SELF};
// Dummy class to force creation of ATL module, needed by COM to instantiate
-// NativeViewAccessibilityWin.
+// ViewAccessibility.
class TestAtlModule : public CAtlDllModuleT<TestAtlModule> {};
TestAtlModule test_atl_module_;
@@ -87,9 +86,7 @@ class BrowserViewsAccessibilityTest : public InProcessBrowserTest {
ASSERT_TRUE(NULL != view);
TestAccessibilityInfo(
- views::NativeViewAccessibilityWin::GetAccessibleForView(view),
- name,
- role);
+ ViewAccessibility::GetAccessibleForView(view), name, role);
}
@@ -256,8 +253,8 @@ IN_PROC_BROWSER_TEST_F(BrowserViewsAccessibilityTest,
EXPECT_STREQ(
aboutChromeWindow->GetDelegate()->GetWindowTitle().c_str(),
UTF16ToWide(l10n_util::GetStringUTF16(IDS_ABOUT_CHROME_TITLE)).c_str());
- EXPECT_EQ(aboutChromeWindow->GetDelegate()->GetAccessibleRole(),
- ui::AccessibilityTypes::ROLE_DIALOG);
+ EXPECT_EQ(aboutChromeWindow->GetDelegate()->accessible_role(),
+ AccessibilityTypes::ROLE_DIALOG);
// Also test the accessibility object directly.
IAccessible* acc_obj = NULL;
diff --git a/chrome/browser/autocomplete/autocomplete_accessibility.cc b/chrome/browser/autocomplete/autocomplete_accessibility.cc
index 48b59bf..05cc6c0 100644
--- a/chrome/browser/autocomplete/autocomplete_accessibility.cc
+++ b/chrome/browser/autocomplete/autocomplete_accessibility.cc
@@ -8,7 +8,7 @@
#include "chrome/browser/autocomplete/autocomplete_edit_view_win.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
-#include "views/accessibility/native_view_accessibility_win.h"
+#include "views/accessibility/view_accessibility.h"
#include "views/view.h"
HRESULT AutocompleteAccessibility::Initialize(
@@ -59,8 +59,8 @@ STDMETHODIMP AutocompleteAccessibility::get_accParent(IDispatch** disp_parent) {
}
// Retrieve the IDispatch interface for the parent view.
- *disp_parent = views::NativeViewAccessibilityWin::GetAccessibleForView(
- edit_box_->parent_view());
+ *disp_parent =
+ ViewAccessibility::GetAccessibleForView(edit_box_->parent_view());
// Increment the reference count for the retrieved interface.
(*disp_parent)->AddRef();
return S_OK;
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_views.cc b/chrome/browser/autocomplete/autocomplete_edit_view_views.cc
index aa302e7..355d192 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_view_views.cc
+++ b/chrome/browser/autocomplete/autocomplete_edit_view_views.cc
@@ -20,7 +20,6 @@
#include "googleurl/src/gurl.h"
#include "grit/generated_resources.h"
#include "net/base/escape.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/dragdrop/drag_drop_types.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/font.h"
@@ -272,11 +271,6 @@ void AutocompleteEditViewViews::Layout() {
height() - insets.height());
}
-void AutocompleteEditViewViews::GetAccessibleState(
- ui::AccessibleViewState* state) {
- state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_LOCATION);
-}
-
////////////////////////////////////////////////////////////////////////////////
// AutocompleteEditViewViews, AutocopmleteEditView implementation:
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_views.h b/chrome/browser/autocomplete/autocomplete_edit_view_views.h
index fbc8b31..f58915b 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_view_views.h
+++ b/chrome/browser/autocomplete/autocomplete_edit_view_views.h
@@ -67,7 +67,6 @@ class AutocompleteEditViewViews : public views::View,
// Implements views::View
virtual bool OnMousePressed(const views::MouseEvent& event);
virtual void Layout();
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
// Implement the AutocompleteEditView interface.
virtual AutocompleteEditModel* model();
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_win.cc b/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
index a4b4475..26fd11d 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
+++ b/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
@@ -735,10 +735,8 @@ void AutocompleteEditViewWin::ClosePopup() {
void AutocompleteEditViewWin::SetFocus() {
::SetFocus(m_hWnd);
- parent_view_->GetWidget()->NotifyAccessibilityEvent(
- parent_view_,
- ui::AccessibilityTypes::EVENT_FOCUS,
- false);
+ parent_view_->
+ NotifyAccessibilityEvent(AccessibilityTypes::EVENT_FOCUS, false);
}
IAccessible* AutocompleteEditViewWin::GetIAccessible() {
@@ -908,12 +906,12 @@ bool AutocompleteEditViewWin::OnAfterPossibleChangeInternal(
if (text_differs) {
// Note that a TEXT_CHANGED event implies that the cursor/selection
// probably changed too, so we don't need to send both.
- parent_view_->GetWidget()->NotifyAccessibilityEvent(
- parent_view_, ui::AccessibilityTypes::EVENT_TEXT_CHANGED, true);
+ parent_view_->NotifyAccessibilityEvent(
+ AccessibilityTypes::EVENT_TEXT_CHANGED);
} else if (selection_differs) {
// Notify assistive technology that the cursor or selection changed.
- parent_view_->GetWidget()->NotifyAccessibilityEvent(
- parent_view_, ui::AccessibilityTypes::EVENT_SELECTION_CHANGED, true);
+ parent_view_->NotifyAccessibilityEvent(
+ AccessibilityTypes::EVENT_SELECTION_CHANGED);
} else if (delete_at_end_pressed_) {
controller_->OnChanged();
}
diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc
index c3f1ec6..5e522f7 100644
--- a/chrome/browser/download/download_browsertest.cc
+++ b/chrome/browser/download/download_browsertest.cc
@@ -388,8 +388,8 @@ class DownloadTest : public InProcessBrowserTest {
// - Add a member function to the |DownloadShelf| interface class, that
// indicates how many members it has.
// - Add a member function to |DownloadShelf| to get the status text
- // of a given member (for example, via the name in |DownloadItemView|'s
- // GetAccessibleState() member function), by index.
+ // of a given member (for example, via |DownloadItemView|'s
+ // GetAccessibleName() member function), by index.
// - Iterate over browser->window()->GetDownloadShelf()'s members
// to see if any match the status text we want. Start with the last one.
diff --git a/chrome/browser/renderer_host/render_widget_host_view_win.cc b/chrome/browser/renderer_host/render_widget_host_view_win.cc
index 2bb8c48..2a81d33 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_win.cc
+++ b/chrome/browser/renderer_host/render_widget_host_view_win.cc
@@ -42,7 +42,7 @@
#include "ui/gfx/canvas_skia.h"
#include "ui/gfx/gdi_util.h"
#include "ui/gfx/rect.h"
-#include "views/accessibility/native_view_accessibility_win.h"
+#include "views/accessibility/view_accessibility.h"
#include "views/focus/focus_manager.h"
#include "views/focus/focus_util_win.h"
// Included for views::kReflectedMessage - TODO(beng): move this to win_util.h!
@@ -587,10 +587,9 @@ void RenderWidgetHostViewWin::Show() {
// Save away our HWND in the parent window as a property so that the
// accessibility code can find it.
- accessibility_prop_.reset(new ViewProp(
- GetParent(),
- views::kViewsNativeHostPropForAccessibility,
- m_hWnd));
+ accessibility_prop_.reset(new ViewProp(GetParent(),
+ kViewsNativeHostPropForAccessibility,
+ m_hWnd));
DidBecomeSelected();
}
@@ -865,10 +864,9 @@ LRESULT RenderWidgetHostViewWin::OnCreate(CREATESTRUCT* create_struct) {
static_cast<RenderWidgetHostView*>(this)));
// Save away our HWND in the parent window as a property so that the
// accessibility code can find it.
- accessibility_prop_.reset(new ViewProp(
- GetParent(),
- views::kViewsNativeHostPropForAccessibility,
- m_hWnd));
+ accessibility_prop_.reset(new ViewProp(GetParent(),
+ kViewsNativeHostPropForAccessibility,
+ m_hWnd));
return 0;
}
diff --git a/chrome/browser/ui/views/accessibility_event_router_views.cc b/chrome/browser/ui/views/accessibility_event_router_views.cc
index 5986d92..b296cac 100644
--- a/chrome/browser/ui/views/accessibility_event_router_views.cc
+++ b/chrome/browser/ui/views/accessibility_event_router_views.cc
@@ -13,7 +13,7 @@
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
#include "chrome/common/notification_type.h"
-#include "ui/base/accessibility/accessible_view_state.h"
+#include "views/accessibility/accessibility_types.h"
#include "views/controls/button/custom_button.h"
#include "views/controls/button/menu_button.h"
#include "views/controls/button/native_button.h"
@@ -43,38 +43,38 @@ AccessibilityEventRouterViews* AccessibilityEventRouterViews::GetInstance() {
}
void AccessibilityEventRouterViews::HandleAccessibilityEvent(
- views::View* view, ui::AccessibilityTypes::Event event_type) {
+ views::View* view, AccessibilityTypes::Event event_type) {
if (!ExtensionAccessibilityEventRouter::GetInstance()->
IsAccessibilityEnabled()) {
return;
}
switch (event_type) {
- case ui::AccessibilityTypes::EVENT_FOCUS:
+ case AccessibilityTypes::EVENT_FOCUS:
DispatchAccessibilityNotification(
view, NotificationType::ACCESSIBILITY_CONTROL_FOCUSED);
break;
- case ui::AccessibilityTypes::EVENT_MENUSTART:
- case ui::AccessibilityTypes::EVENT_MENUPOPUPSTART:
+ case AccessibilityTypes::EVENT_MENUSTART:
+ case AccessibilityTypes::EVENT_MENUPOPUPSTART:
DispatchAccessibilityNotification(
view, NotificationType::ACCESSIBILITY_MENU_OPENED);
break;
- case ui::AccessibilityTypes::EVENT_MENUEND:
- case ui::AccessibilityTypes::EVENT_MENUPOPUPEND:
+ case AccessibilityTypes::EVENT_MENUEND:
+ case AccessibilityTypes::EVENT_MENUPOPUPEND:
DispatchAccessibilityNotification(
view, NotificationType::ACCESSIBILITY_MENU_CLOSED);
break;
- case ui::AccessibilityTypes::EVENT_TEXT_CHANGED:
- case ui::AccessibilityTypes::EVENT_SELECTION_CHANGED:
+ case AccessibilityTypes::EVENT_TEXT_CHANGED:
+ case AccessibilityTypes::EVENT_SELECTION_CHANGED:
DispatchAccessibilityNotification(
view, NotificationType::ACCESSIBILITY_TEXT_CHANGED);
break;
- case ui::AccessibilityTypes::EVENT_VALUE_CHANGED:
+ case AccessibilityTypes::EVENT_VALUE_CHANGED:
DispatchAccessibilityNotification(
view, NotificationType::ACCESSIBILITY_CONTROL_ACTION);
break;
- case ui::AccessibilityTypes::EVENT_ALERT:
- case ui::AccessibilityTypes::EVENT_NAME_CHANGED:
+ case AccessibilityTypes::EVENT_ALERT:
+ case AccessibilityTypes::EVENT_NAME_CHANGED:
// TODO(dmazzoni): re-evaluate this list later and see
// if supporting any of these would be useful feature requests or
// they'd just be superfluous.
@@ -88,9 +88,9 @@ void AccessibilityEventRouterViews::HandleAccessibilityEvent(
//
std::string AccessibilityEventRouterViews::GetViewName(views::View* view) {
- ui::AccessibleViewState state;
- view->GetAccessibleState(&state);
- return UTF16ToUTF8(state.name);
+ string16 wname;
+ view->GetAccessibleName(&wname);
+ return UTF16ToUTF8(wname);
}
void AccessibilityEventRouterViews::DispatchAccessibilityNotification(
@@ -202,11 +202,9 @@ bool AccessibilityEventRouterViews::IsMenuEvent(
return true;
while (view) {
- ui::AccessibleViewState state;
- view->GetAccessibleState(&state);
- ui::AccessibilityTypes::Role role = state.role;
- if (role == ui::AccessibilityTypes::ROLE_MENUITEM ||
- role == ui::AccessibilityTypes::ROLE_MENUPOPUP) {
+ AccessibilityTypes::Role role = view->GetAccessibleRole();
+ if (role == AccessibilityTypes::ROLE_MENUITEM ||
+ role == AccessibilityTypes::ROLE_MENUPOPUP) {
return true;
}
view = view->parent();
diff --git a/chrome/browser/ui/views/accessibility_event_router_views.h b/chrome/browser/ui/views/accessibility_event_router_views.h
index 6dfdf78..77b256d 100644
--- a/chrome/browser/ui/views/accessibility_event_router_views.h
+++ b/chrome/browser/ui/views/accessibility_event_router_views.h
@@ -13,7 +13,7 @@
#include "base/singleton.h"
#include "base/task.h"
#include "chrome/browser/accessibility_events.h"
-#include "ui/base/accessibility/accessibility_types.h"
+#include "views/accessibility/accessibility_types.h"
class Profile;
namespace views {
@@ -54,7 +54,7 @@ class AccessibilityEventRouterViews {
// Handle an accessibility event generated by a view.
void HandleAccessibilityEvent(
- views::View* view, ui::AccessibilityTypes::Event event_type);
+ views::View* view, AccessibilityTypes::Event event_type);
private:
AccessibilityEventRouterViews();
diff --git a/chrome/browser/ui/views/accessibility_event_router_views_unittest.cc b/chrome/browser/ui/views/accessibility_event_router_views_unittest.cc
index 7fb4751..caecfbb 100644
--- a/chrome/browser/ui/views/accessibility_event_router_views_unittest.cc
+++ b/chrome/browser/ui/views/accessibility_event_router_views_unittest.cc
@@ -46,7 +46,7 @@ class AccessibilityViewsDelegate : public views::ViewsDelegate {
return false;
}
virtual void NotifyAccessibilityEvent(
- views::View* view, ui::AccessibilityTypes::Event event_type) {
+ views::View* view, AccessibilityTypes::Event event_type) {
AccessibilityEventRouterViews::GetInstance()->HandleAccessibilityEvent(
view, event_type);
}
diff --git a/chrome/browser/ui/views/accessible_pane_view.cc b/chrome/browser/ui/views/accessible_pane_view.cc
index 9dfa4a2..c6789bc 100644
--- a/chrome/browser/ui/views/accessible_pane_view.cc
+++ b/chrome/browser/ui/views/accessible_pane_view.cc
@@ -7,7 +7,6 @@
#include "chrome/browser/ui/views/accessible_pane_view.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "views/controls/button/menu_button.h"
#include "views/controls/native/native_view_host.h"
#include "views/focus/focus_search.h"
@@ -193,8 +192,8 @@ void AccessiblePaneView::SetVisible(bool flag) {
View::SetVisible(flag);
}
-void AccessiblePaneView::GetAccessibleState(ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_PANE;
+AccessibilityTypes::Role AccessiblePaneView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_PANE;
}
////////////////////////////////////////////////////////////////////////////////
diff --git a/chrome/browser/ui/views/accessible_pane_view.h b/chrome/browser/ui/views/accessible_pane_view.h
index 8f7d56c..349fc0d 100644
--- a/chrome/browser/ui/views/accessible_pane_view.h
+++ b/chrome/browser/ui/views/accessible_pane_view.h
@@ -41,20 +41,19 @@ class AccessiblePaneView : public views::View,
virtual bool SetPaneFocusAndFocusDefault(int view_storage_id);
// Overridden from views::View:
- virtual FocusTraversable* GetPaneFocusTraversable() OVERRIDE;
- virtual bool AcceleratorPressed(const views::Accelerator& accelerator)
- OVERRIDE;
- virtual void SetVisible(bool flag) OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual FocusTraversable* GetPaneFocusTraversable();
+ virtual bool AcceleratorPressed(const views::Accelerator& accelerator);
+ virtual void SetVisible(bool flag);
+ virtual AccessibilityTypes::Role GetAccessibleRole();
// Overridden from views::FocusChangeListener:
virtual void FocusWillChange(View* focused_before,
- View* focused_now) OVERRIDE;
+ View* focused_now);
// Overridden from views::FocusTraversable:
- virtual views::FocusSearch* GetFocusSearch() OVERRIDE;
- virtual FocusTraversable* GetFocusTraversableParent() OVERRIDE;
- virtual View* GetFocusTraversableParentView() OVERRIDE;
+ virtual views::FocusSearch* GetFocusSearch();
+ virtual FocusTraversable* GetFocusTraversableParent();
+ virtual View* GetFocusTraversableParentView();
protected:
// A subclass can override this to provide a default focusable child
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc
index 28c3a31..78f19ab 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc
@@ -86,9 +86,8 @@ void BookmarkBarInstructionsView::ViewHierarchyChanged(bool is_add,
UpdateColors();
}
-void BookmarkBarInstructionsView::GetAccessibleState(
- ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_GROUPING;
+AccessibilityTypes::Role BookmarkBarInstructionsView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_GROUPING;
}
void BookmarkBarInstructionsView::LinkActivated(views::Link* source,
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h
index 675df4a..3b6bf13 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h
@@ -6,7 +6,6 @@
#define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_INSTRUCTIONS_VIEW_H_
#pragma once
-#include "ui/base/accessibility/accessible_view_state.h"
#include "views/controls/link.h"
#include "views/view.h"
@@ -36,16 +35,16 @@ class BookmarkBarInstructionsView : public views::View,
explicit BookmarkBarInstructionsView(Delegate* delegate);
// View overrides.
- virtual gfx::Size GetPreferredSize() OVERRIDE;
- virtual void Layout() OVERRIDE;
- virtual void OnThemeChanged() OVERRIDE;
+ virtual gfx::Size GetPreferredSize();
+ virtual void Layout();
+ virtual void OnThemeChanged();
virtual void ViewHierarchyChanged(bool is_add,
views::View* parent,
- views::View* child) OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ views::View* child);
+ virtual AccessibilityTypes::Role GetAccessibleRole();
// LinkController.
- virtual void LinkActivated(views::Link* source, int event_flags) OVERRIDE;
+ virtual void LinkActivated(views::Link* source, int event_flags);
private:
void UpdateColors();
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
index d61b4ad..c1cb88d89 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
@@ -40,7 +40,6 @@
#include "grit/app_resources.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/animation/slide_animation.h"
#include "ui/base/dragdrop/os_exchange_data.h"
#include "ui/base/l10n/l10n_util.h"
@@ -298,7 +297,7 @@ class BookmarkBarView::ButtonSeparatorView : public views::View {
ButtonSeparatorView() {}
virtual ~ButtonSeparatorView() {}
- virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE {
+ virtual void OnPaint(gfx::Canvas* canvas) {
DetachableToolbarView::PaintVerticalDivider(
canvas, kSeparatorStartX, height(), 1,
DetachableToolbarView::kEdgeDividerColor,
@@ -306,15 +305,14 @@ class BookmarkBarView::ButtonSeparatorView : public views::View {
GetThemeProvider()->GetColor(BrowserThemeProvider::COLOR_TOOLBAR));
}
- virtual gfx::Size GetPreferredSize() OVERRIDE {
+ virtual gfx::Size GetPreferredSize() {
// We get the full height of the bookmark bar, so that the height returned
// here doesn't matter.
return gfx::Size(kSeparatorWidth, 1);
}
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE {
- state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_SEPARATOR);
- state->role = ui::AccessibilityTypes::ROLE_SEPARATOR;
+ virtual AccessibilityTypes::Role GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_SEPARATOR;
}
private:
@@ -677,9 +675,12 @@ void BookmarkBarView::ShowContextMenu(const gfx::Point& p,
ShowContextMenu(this, p, is_mouse_gesture);
}
-void BookmarkBarView::GetAccessibleState(ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_TOOLBAR;
- state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_BOOKMARKS);
+bool BookmarkBarView::IsAccessibleViewTraversable(views::View* view) {
+ return view != bookmarks_separator_view_ && view != instructions_;
+}
+
+AccessibilityTypes::Role BookmarkBarView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_TOOLBAR;
}
void BookmarkBarView::OnStateChanged() {
@@ -880,6 +881,8 @@ void BookmarkBarView::Init() {
AddChildView(other_bookmarked_button_);
bookmarks_separator_view_ = new ButtonSeparatorView();
+ bookmarks_separator_view_->SetAccessibleName(
+ l10n_util::GetStringUTF16(IDS_ACCNAME_SEPARATOR));
AddChildView(bookmarks_separator_view_);
instructions_ = new BookmarkBarInstructionsView(this);
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
index 214893c..5737e7c 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
@@ -109,36 +109,34 @@ class BookmarkBarView : public DetachableToolbarView,
infobar_visible_ = infobar_visible;
}
- virtual bool IsOnTop() const;
-
// DetachableToolbarView methods:
- virtual bool IsDetached() const OVERRIDE;
- virtual double GetAnimationValue() const OVERRIDE;
- virtual int GetToolbarOverlap() const OVERRIDE {
+ virtual bool IsDetached() const;
+ virtual bool IsOnTop() const;
+ virtual double GetAnimationValue() const;
+ virtual int GetToolbarOverlap() const {
return GetToolbarOverlap(false);
}
// View methods:
- virtual gfx::Size GetPreferredSize() OVERRIDE;
- virtual gfx::Size GetMinimumSize() OVERRIDE;
- virtual void Layout() OVERRIDE;
- virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child)
- OVERRIDE;
- virtual void PaintChildren(gfx::Canvas* canvas) OVERRIDE;
+ virtual gfx::Size GetPreferredSize();
+ virtual gfx::Size GetMinimumSize();
+ virtual void Layout();
+ virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child);
+ virtual void PaintChildren(gfx::Canvas* canvas);
virtual bool GetDropFormats(
int* formats,
- std::set<ui::OSExchangeData::CustomFormat>* custom_formats) OVERRIDE;
- virtual bool AreDropTypesRequired() OVERRIDE;
- virtual bool CanDrop(const ui::OSExchangeData& data) OVERRIDE;
- virtual void OnDragEntered(const views::DropTargetEvent& event) OVERRIDE;
- virtual int OnDragUpdated(const views::DropTargetEvent& event) OVERRIDE;
- virtual void OnDragExited() OVERRIDE;
- virtual int OnPerformDrop(const views::DropTargetEvent& event) OVERRIDE;
- virtual void ShowContextMenu(const gfx::Point& p, bool is_mouse_gesture)
- OVERRIDE;
+ std::set<ui::OSExchangeData::CustomFormat>* custom_formats);
+ virtual bool AreDropTypesRequired();
+ virtual bool CanDrop(const ui::OSExchangeData& data);
+ virtual void OnDragEntered(const views::DropTargetEvent& event);
+ virtual int OnDragUpdated(const views::DropTargetEvent& event);
+ virtual void OnDragExited();
+ virtual int OnPerformDrop(const views::DropTargetEvent& event);
+ virtual void ShowContextMenu(const gfx::Point& p, bool is_mouse_gesture);
// AccessiblePaneView methods:
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual bool IsAccessibleViewTraversable(views::View* view);
+ virtual AccessibilityTypes::Role GetAccessibleRole();
// ProfileSyncServiceObserver method.
virtual void OnStateChanged();
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
index 9bb6721..49ea7e2 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
@@ -18,7 +18,6 @@
#include "chrome/test/ui_test_utils.h"
#include "content/browser/tab_contents/page_navigator.h"
#include "grit/generated_resources.h"
-#include "ui/base/accessibility/accessibility_types.h"
#include "ui/base/clipboard/clipboard.h"
#include "ui/base/keycodes/keyboard_codes.h"
#include "views/controls/button/menu_button.h"
@@ -85,7 +84,7 @@ class ViewsDelegateImpl : public views::ViewsDelegate {
}
virtual void NotifyAccessibilityEvent(
- views::View* view, ui::AccessibilityTypes::Event event_type) {}
+ views::View* view, AccessibilityTypes::Event event_type) {}
#if defined(OS_WIN)
virtual HICON GetDefaultWindowIcon() const { return 0; }
diff --git a/chrome/browser/ui/views/browser_actions_container.cc b/chrome/browser/ui/views/browser_actions_container.cc
index d85548f..6870f65 100644
--- a/chrome/browser/ui/views/browser_actions_container.cc
+++ b/chrome/browser/ui/views/browser_actions_container.cc
@@ -33,7 +33,6 @@
#include "third_party/skia/include/core/SkBitmap.h"
#include "third_party/skia/include/core/SkTypeface.h"
#include "third_party/skia/include/effects/SkGradientShader.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/animation/slide_animation.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
@@ -171,6 +170,7 @@ void BrowserActionButton::UpdateState() {
if (name.empty())
name = UTF8ToUTF16(extension()->name());
SetTooltipText(UTF16ToWideHack(name));
+ SetAccessibleName(name);
parent()->SchedulePaint();
}
@@ -292,6 +292,8 @@ BrowserActionView::BrowserActionView(const Extension* extension,
button_->SetDragController(panel_);
AddChildView(button_);
button_->UpdateState();
+ SetAccessibleName(
+ l10n_util::GetStringUTF16(IDS_ACCNAME_EXTENSIONS_BROWSER_ACTION));
}
BrowserActionView::~BrowserActionView() {
@@ -317,10 +319,8 @@ gfx::Canvas* BrowserActionView::GetIconWithBadge() {
return canvas;
}
-void BrowserActionView::GetAccessibleState(ui::AccessibleViewState* state) {
- state->name = l10n_util::GetStringUTF16(
- IDS_ACCNAME_EXTENSIONS_BROWSER_ACTION);
- state->role = ui::AccessibilityTypes::ROLE_GROUPING;
+AccessibilityTypes::Role BrowserActionView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_GROUPING;
}
void BrowserActionView::Layout() {
@@ -372,6 +372,8 @@ BrowserActionsContainer::BrowserActionsContainer(Browser* browser,
resize_animation_.reset(new ui::SlideAnimation(this));
resize_area_ = new views::ResizeArea(this);
+ resize_area_->SetAccessibleName(
+ l10n_util::GetStringUTF16(IDS_ACCNAME_SEPARATOR));
AddChildView(resize_area_);
chevron_ = new views::MenuButton(NULL, std::wstring(), this, false);
@@ -381,6 +383,8 @@ BrowserActionsContainer::BrowserActionsContainer(Browser* browser,
l10n_util::GetStringUTF16(IDS_ACCNAME_EXTENSIONS_CHEVRON));
chevron_->SetVisible(false);
AddChildView(chevron_);
+
+ SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_EXTENSIONS));
}
BrowserActionsContainer::~BrowserActionsContainer() {
@@ -737,10 +741,8 @@ void BrowserActionsContainer::OnThemeChanged() {
LoadImages();
}
-void BrowserActionsContainer::GetAccessibleState(
- ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_GROUPING;
- state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_EXTENSIONS);
+AccessibilityTypes::Role BrowserActionsContainer::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_GROUPING;
}
void BrowserActionsContainer::RunMenu(View* source, const gfx::Point& pt) {
diff --git a/chrome/browser/ui/views/browser_actions_container.h b/chrome/browser/ui/views/browser_actions_container.h
index d803447..94c13139e 100644
--- a/chrome/browser/ui/views/browser_actions_container.h
+++ b/chrome/browser/ui/views/browser_actions_container.h
@@ -27,6 +27,7 @@
#include "views/view.h"
class Browser;
+class BrowserActionsContainer;
class BrowserActionOverflowMenuController;
class BrowserActionsContainer;
class Extension;
@@ -162,7 +163,7 @@ class BrowserActionView : public views::View {
gfx::Canvas* GetIconWithBadge();
// Accessibility accessors, overridden from View.
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual AccessibilityTypes::Role GetAccessibleRole();
private:
virtual void Layout();
@@ -330,7 +331,7 @@ class BrowserActionsContainer
virtual void OnDragExited();
virtual int OnPerformDrop(const views::DropTargetEvent& event);
virtual void OnThemeChanged();
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual AccessibilityTypes::Role GetAccessibleRole();
// Overridden from views::ViewMenuDelegate:
virtual void RunMenu(View* source, const gfx::Point& pt);
diff --git a/chrome/browser/ui/views/chrome_views_delegate.cc b/chrome/browser/ui/views/chrome_views_delegate.cc
index ecd9e92..3771682 100644
--- a/chrome/browser/ui/views/chrome_views_delegate.cc
+++ b/chrome/browser/ui/views/chrome_views_delegate.cc
@@ -114,7 +114,7 @@ bool ChromeViewsDelegate::GetSavedMaximizedState(
}
void ChromeViewsDelegate::NotifyAccessibilityEvent(
- views::View* view, ui::AccessibilityTypes::Event event_type) {
+ views::View* view, AccessibilityTypes::Event event_type) {
AccessibilityEventRouterViews::GetInstance()->HandleAccessibilityEvent(
view, event_type);
}
diff --git a/chrome/browser/ui/views/chrome_views_delegate.h b/chrome/browser/ui/views/chrome_views_delegate.h
index 952ae43..c48f07b 100644
--- a/chrome/browser/ui/views/chrome_views_delegate.h
+++ b/chrome/browser/ui/views/chrome_views_delegate.h
@@ -8,7 +8,6 @@
#include "base/basictypes.h"
#include "build/build_config.h"
-#include "ui/base/accessibility/accessibility_types.h"
#include "views/views_delegate.h"
namespace views {
@@ -33,7 +32,7 @@ class ChromeViewsDelegate : public views::ViewsDelegate {
const std::wstring& window_name,
bool* maximized) const;
virtual void NotifyAccessibilityEvent(
- views::View* view, ui::AccessibilityTypes::Event event_type);
+ views::View* view, AccessibilityTypes::Event event_type);
#if defined(OS_WIN)
virtual HICON GetDefaultWindowIcon() const;
#endif
diff --git a/chrome/browser/ui/views/download_item_view.cc b/chrome/browser/ui/views/download_item_view.cc
index eaafa09..1783b16 100644
--- a/chrome/browser/ui/views/download_item_view.cc
+++ b/chrome/browser/ui/views/download_item_view.cc
@@ -20,7 +20,6 @@
#include "chrome/browser/ui/views/download_shelf_view.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/animation/slide_animation.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
@@ -950,13 +949,15 @@ void DownloadItemView::ShowContextMenu(const gfx::Point& p,
}
}
-void DownloadItemView::GetAccessibleState(ui::AccessibleViewState* state) {
- state->name = accessible_name_;
- state->role = ui::AccessibilityTypes::ROLE_PUSHBUTTON;
+AccessibilityTypes::Role DownloadItemView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_PUSHBUTTON;
+}
+
+AccessibilityTypes::State DownloadItemView::GetAccessibleState() {
if (download_->safety_state() == DownloadItem::DANGEROUS) {
- state->state = ui::AccessibilityTypes::STATE_UNAVAILABLE;
+ return AccessibilityTypes::STATE_UNAVAILABLE;
} else {
- state->state = ui::AccessibilityTypes::STATE_HASPOPUP;
+ return AccessibilityTypes::STATE_HASPOPUP;
}
}
@@ -1078,6 +1079,9 @@ bool DownloadItemView::InDropDownButtonXCoordinateRange(int x) {
}
void DownloadItemView::UpdateAccessibleName() {
+ string16 current_name;
+ GetAccessibleName(&current_name);
+
string16 new_name;
if (download_->safety_state() == DownloadItem::DANGEROUS) {
new_name = WideToUTF16Hack(dangerous_download_label_->GetText());
@@ -1086,13 +1090,12 @@ void DownloadItemView::UpdateAccessibleName() {
download_->GetFileNameToReportUser().LossyDisplayName();
}
- // If the name has changed, notify assistive technology that the name
- // has changed so they can announce it immediately.
- if (new_name != accessible_name_) {
- accessible_name_ = new_name;
- if (GetWidget()) {
- GetWidget()->NotifyAccessibilityEvent(
- this, ui::AccessibilityTypes::EVENT_NAME_CHANGED, true);
- }
+ // If the name has changed, call SetAccessibleName and notify
+ // assistive technology that the name has changed so they can
+ // announce it immediately.
+ if (new_name != current_name) {
+ SetAccessibleName(new_name);
+ if (GetWidget())
+ NotifyAccessibilityEvent(AccessibilityTypes::EVENT_NAME_CHANGED);
}
}
diff --git a/chrome/browser/ui/views/download_item_view.h b/chrome/browser/ui/views/download_item_view.h
index 6994378..e8f427a 100644
--- a/chrome/browser/ui/views/download_item_view.h
+++ b/chrome/browser/ui/views/download_item_view.h
@@ -77,7 +77,8 @@ class DownloadItemView : public views::ButtonListener,
virtual bool OnMouseDragged(const views::MouseEvent& event);
virtual bool OnKeyPressed(const views::KeyEvent& e);
virtual void ShowContextMenu(const gfx::Point& p, bool is_mouse_gesture);
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual AccessibilityTypes::Role GetAccessibleRole();
+ virtual AccessibilityTypes::State GetAccessibleState();
// ButtonListener implementation.
virtual void ButtonPressed(views::Button* sender, const views::Event& event);
@@ -278,9 +279,6 @@ class DownloadItemView : public views::ButtonListener,
// might delete us).
bool* deleted_;
- // The name of this view as reported to assistive technology.
- string16 accessible_name_;
-
DISALLOW_COPY_AND_ASSIGN(DownloadItemView);
};
diff --git a/chrome/browser/ui/views/first_run_search_engine_view.cc b/chrome/browser/ui/views/first_run_search_engine_view.cc
index d204d62c..0e6dd44 100644
--- a/chrome/browser/ui/views/first_run_search_engine_view.cc
+++ b/chrome/browser/ui/views/first_run_search_engine_view.cc
@@ -18,11 +18,10 @@
#include "chrome/browser/search_engines/template_url_model.h"
#include "chrome/browser/ui/options/options_window.h"
#include "grit/chromium_strings.h"
-#include "grit/generated_resources.h"
#include "grit/google_chrome_strings.h"
+#include "grit/generated_resources.h"
#include "grit/locale_settings.h"
#include "grit/theme_resources.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/canvas.h"
@@ -266,8 +265,7 @@ void FirstRunSearchEngineView::OnTemplateURLModelChanged() {
// This will tell screenreaders that they should read the full text
// of this dialog to the user now (rather than waiting for the user
// to explore it).
- GetWidget()->NotifyAccessibilityEvent(
- this, ui::AccessibilityTypes::EVENT_ALERT, true);
+ NotifyAccessibilityEvent(AccessibilityTypes::EVENT_ALERT);
}
gfx::Size FirstRunSearchEngineView::GetPreferredSize() {
@@ -429,9 +427,8 @@ void FirstRunSearchEngineView::Layout() {
} // if (search_engine_choices.size() > 0)
}
-void FirstRunSearchEngineView::GetAccessibleState(
- ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_ALERT;
+AccessibilityTypes::Role FirstRunSearchEngineView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_ALERT;
}
std::wstring FirstRunSearchEngineView::GetWindowTitle() const {
diff --git a/chrome/browser/ui/views/first_run_search_engine_view.h b/chrome/browser/ui/views/first_run_search_engine_view.h
index eee914c..5db011b 100644
--- a/chrome/browser/ui/views/first_run_search_engine_view.h
+++ b/chrome/browser/ui/views/first_run_search_engine_view.h
@@ -88,31 +88,29 @@ class FirstRunSearchEngineView
virtual ~FirstRunSearchEngineView();
- bool IsAlwaysOnTop() const { return true; }
- bool HasAlwaysOnTopMenu() const { return false; }
-
// Overridden from views::View:
- virtual gfx::Size GetPreferredSize() OVERRIDE;
- virtual void Layout() OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual gfx::Size GetPreferredSize();
+ virtual void Layout();
+ virtual AccessibilityTypes::Role GetAccessibleRole();
// Overridden from views::WindowDelegate:
- virtual std::wstring GetWindowTitle() const OVERRIDE;
- views::View* GetContentsView() OVERRIDE { return this; }
- bool CanResize() const OVERRIDE{ return false; }
- bool CanMaximize() const OVERRIDE { return false; }
+ virtual std::wstring GetWindowTitle() const;
+ views::View* GetContentsView() { return this; }
+ bool CanResize() const { return false; }
+ bool CanMaximize() const { return false; }
+ bool IsAlwaysOnTop() const { return true; }
+ bool HasAlwaysOnTopMenu() const { return false; }
// Overridden from views::ButtonListener:
- virtual void ButtonPressed(views::Button* sender, const views::Event& event)
- OVERRIDE;
+ virtual void ButtonPressed(views::Button* sender, const views::Event& event);
// Override from View so we can draw the gray background at dialog top.
- virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
+ virtual void OnPaint(gfx::Canvas* canvas);
// Overridden from TemplateURLModelObserver. When the search engines have
// loaded from the profile, we can populate the logos in the dialog box
// to present to the user.
- virtual void OnTemplateURLModelChanged() OVERRIDE;
+ virtual void OnTemplateURLModelChanged();
private:
// Initializes the labels and controls in the view.
@@ -143,3 +141,4 @@ class FirstRunSearchEngineView
};
#endif // CHROME_BROWSER_UI_VIEWS_FIRST_RUN_SEARCH_ENGINE_VIEW_H_
+
diff --git a/chrome/browser/ui/views/frame/browser_root_view.cc b/chrome/browser/ui/views/frame/browser_root_view.cc
index 6476bc4..094e6c3 100644
--- a/chrome/browser/ui/views/frame/browser_root_view.cc
+++ b/chrome/browser/ui/views/frame/browser_root_view.cc
@@ -14,7 +14,6 @@
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/tabs/tab_strip.h"
#include "grit/chromium_strings.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/dragdrop/drag_drop_types.h"
#include "ui/base/dragdrop/os_exchange_data.h"
#include "ui/base/l10n/l10n_util.h"
@@ -23,7 +22,9 @@ BrowserRootView::BrowserRootView(BrowserView* browser_view,
views::Widget* widget)
: views::RootView(widget),
browser_view_(browser_view),
- forwarding_to_tab_strip_(false) { }
+ forwarding_to_tab_strip_(false) {
+ SetAccessibleName(l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));
+}
bool BrowserRootView::GetDropFormats(
int* formats,
@@ -109,11 +110,6 @@ int BrowserRootView::OnPerformDrop(const views::DropTargetEvent& event) {
return tabstrip()->OnPerformDrop(*mapped_event);
}
-void BrowserRootView::GetAccessibleState(ui::AccessibleViewState* state) {
- RootView::GetAccessibleState(state);
- state->name = l10n_util::GetStringUTF16(IDS_PRODUCT_NAME);
-}
-
bool BrowserRootView::ShouldForwardToTabStrip(
const views::DropTargetEvent& event) {
if (!tabstrip()->IsVisible())
diff --git a/chrome/browser/ui/views/frame/browser_root_view.h b/chrome/browser/ui/views/frame/browser_root_view.h
index bba1c10..1fcccb5 100644
--- a/chrome/browser/ui/views/frame/browser_root_view.h
+++ b/chrome/browser/ui/views/frame/browser_root_view.h
@@ -25,17 +25,15 @@ class BrowserRootView : public views::RootView {
// You must call set_tabstrip before this class will accept drops.
BrowserRootView(BrowserView* browser_view, views::Widget* widget);
- // Overridden from views::View:
virtual bool GetDropFormats(
int* formats,
- std::set<ui::OSExchangeData::CustomFormat>* custom_formats) OVERRIDE;
- virtual bool AreDropTypesRequired() OVERRIDE;
- virtual bool CanDrop(const ui::OSExchangeData& data) OVERRIDE;
- virtual void OnDragEntered(const views::DropTargetEvent& event) OVERRIDE;
- virtual int OnDragUpdated(const views::DropTargetEvent& event) OVERRIDE;
- virtual void OnDragExited() OVERRIDE;
- virtual int OnPerformDrop(const views::DropTargetEvent& event) OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ std::set<ui::OSExchangeData::CustomFormat>* custom_formats);
+ virtual bool AreDropTypesRequired();
+ virtual bool CanDrop(const ui::OSExchangeData& data);
+ virtual void OnDragEntered(const views::DropTargetEvent& event);
+ virtual int OnDragUpdated(const views::DropTargetEvent& event);
+ virtual void OnDragExited();
+ virtual int OnPerformDrop(const views::DropTargetEvent& event);
private:
// Returns true if the event should be forwarded to the tabstrip.
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 328b449..aba18fb 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -74,7 +74,6 @@
#include "grit/locale_settings.h"
#include "grit/theme_resources.h"
#include "grit/webkit_resources.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/canvas_skia.h"
@@ -1826,9 +1825,8 @@ void BrowserView::ChildPreferredSizeChanged(View* child) {
Layout();
}
-void BrowserView::GetAccessibleState(ui::AccessibleViewState* state) {
- state->name = l10n_util::GetStringUTF16(IDS_PRODUCT_NAME);
- state->role = ui::AccessibilityTypes::ROLE_CLIENT;
+AccessibilityTypes::Role BrowserView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_CLIENT;
}
void BrowserView::InfoBarContainerSizeChanged(bool is_animating) {
@@ -1857,6 +1855,8 @@ void BrowserView::InitTabStrip(TabStripModel* model) {
new BrowserTabStripController(browser_.get(), model);
tabstrip_ = CreateTabStrip(tabstrip_controller, UseVerticalTabs());
+
+ tabstrip_->SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_TABSTRIP));
AddChildView(tabstrip_);
tabstrip_controller->InitFromModel(tabstrip_);
@@ -1884,12 +1884,14 @@ void BrowserView::Init() {
}
LoadAccelerators();
+ SetAccessibleName(l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));
InitTabStrip(browser_->tabstrip_model());
toolbar_ = new ToolbarView(browser_.get());
AddChildView(toolbar_);
toolbar_->Init(browser_->profile());
+ toolbar_->SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_TOOLBAR));
infobar_container_ = new InfoBarContainer(this);
AddChildView(infobar_container_);
@@ -2020,6 +2022,8 @@ bool BrowserView::MaybeShowBookmarkBar(TabContentsWrapper* contents) {
bookmark_bar_view_->SetProfile(contents->profile());
}
bookmark_bar_view_->SetPageNavigator(contents->tab_contents());
+ bookmark_bar_view_->SetAccessibleName(
+ l10n_util::GetStringUTF16(IDS_ACCNAME_BOOKMARKS));
new_bookmark_bar_view = bookmark_bar_view_.get();
}
return UpdateChildViewAndLayout(new_bookmark_bar_view, &active_bookmark_bar_);
diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h
index 74a71b0..fecd185 100644
--- a/chrome/browser/ui/views/frame/browser_view.h
+++ b/chrome/browser/ui/views/frame/browser_view.h
@@ -414,14 +414,14 @@ class BrowserView : public BrowserBubbleHost,
}
// Overridden from views::View:
- virtual std::string GetClassName() const OVERRIDE;
- virtual void Layout() OVERRIDE;
- virtual void PaintChildren(gfx::Canvas* canvas) OVERRIDE;
+ virtual std::string GetClassName() const;
+ virtual void Layout();
+ virtual void PaintChildren(gfx::Canvas* canvas);
virtual void ViewHierarchyChanged(bool is_add,
views::View* parent,
- views::View* child) OVERRIDE;
- virtual void ChildPreferredSizeChanged(View* child) OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ views::View* child);
+ virtual void ChildPreferredSizeChanged(View* child);
+ virtual AccessibilityTypes::Role GetAccessibleRole();
// Factory Methods.
// Returns a new LayoutManager for this browser view. A subclass may
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
index c68c571..3bdbd2c 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
@@ -16,7 +16,6 @@
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/base/theme_provider.h"
@@ -401,9 +400,8 @@ bool OpaqueBrowserFrameView::HitTest(const gfx::Point& l) const {
return browser_view_->IsPositionInWindowCaption(browser_view_point);
}
-void OpaqueBrowserFrameView::GetAccessibleState(
- ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_TITLEBAR;
+AccessibilityTypes::Role OpaqueBrowserFrameView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_TITLEBAR;
}
///////////////////////////////////////////////////////////////////////////////
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.h b/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
index a001b5d..0303d3a 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
@@ -45,30 +45,28 @@ class OpaqueBrowserFrameView : public BrowserNonClientFrameView,
virtual gfx::Rect GetBoundsForReservedArea() const;
// Overridden from views::NonClientFrameView:
- virtual gfx::Rect GetBoundsForClientView() const OVERRIDE;
- virtual bool AlwaysUseNativeFrame() const OVERRIDE;
- virtual bool AlwaysUseCustomFrame() const OVERRIDE;
+ virtual gfx::Rect GetBoundsForClientView() const;
+ virtual bool AlwaysUseNativeFrame() const;
+ virtual bool AlwaysUseCustomFrame() const;
virtual gfx::Rect GetWindowBoundsForClientBounds(
- const gfx::Rect& client_bounds) const OVERRIDE;
- virtual int NonClientHitTest(const gfx::Point& point) OVERRIDE;
- virtual void GetWindowMask(const gfx::Size& size, gfx::Path* window_mask)
- OVERRIDE;
- virtual void EnableClose(bool enable) OVERRIDE;
- virtual void ResetWindowControls() OVERRIDE;
+ const gfx::Rect& client_bounds) const;
+ virtual int NonClientHitTest(const gfx::Point& point);
+ virtual void GetWindowMask(const gfx::Size& size, gfx::Path* window_mask);
+ virtual void EnableClose(bool enable);
+ virtual void ResetWindowControls();
// Overridden from views::View:
- virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
- virtual void Layout() OVERRIDE;
- virtual bool HitTest(const gfx::Point& l) const OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual void OnPaint(gfx::Canvas* canvas);
+ virtual void Layout();
+ virtual bool HitTest(const gfx::Point& l) const;
+ virtual AccessibilityTypes::Role GetAccessibleRole();
// Overridden from views::ButtonListener:
- virtual void ButtonPressed(views::Button* sender, const views::Event& event)
- OVERRIDE;
+ virtual void ButtonPressed(views::Button* sender, const views::Event& event);
// Overridden from TabIconView::TabIconViewModel:
- virtual bool ShouldTabIconViewAnimate() const OVERRIDE;
- virtual SkBitmap GetFavIconForTabIconView() OVERRIDE;
+ virtual bool ShouldTabIconViewAnimate() const;
+ virtual SkBitmap GetFavIconForTabIconView();
private:
// Returns the thickness of the border that makes up the window frame edges.
diff --git a/chrome/browser/ui/views/infobars/infobar_container.cc b/chrome/browser/ui/views/infobars/infobar_container.cc
index d8a1c72..20761aa 100644
--- a/chrome/browser/ui/views/infobars/infobar_container.cc
+++ b/chrome/browser/ui/views/infobars/infobar_container.cc
@@ -12,7 +12,6 @@
#include "chrome/common/notification_source.h"
#include "content/browser/tab_contents/tab_contents.h"
#include "grit/generated_resources.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/l10n/l10n_util.h"
InfoBarContainer::Delegate::~Delegate() {
@@ -22,6 +21,7 @@ InfoBarContainer::InfoBarContainer(Delegate* delegate)
: delegate_(delegate),
tab_contents_(NULL) {
SetID(VIEW_ID_INFO_BAR_CONTAINER);
+ SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_INFOBAR_CONTAINER));
}
InfoBarContainer::~InfoBarContainer() {
@@ -109,9 +109,8 @@ void InfoBarContainer::Layout() {
}
}
-void InfoBarContainer::GetAccessibleState(ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_GROUPING;
- state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_INFOBAR_CONTAINER);
+AccessibilityTypes::Role InfoBarContainer::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_GROUPING;
}
void InfoBarContainer::Observe(NotificationType type,
diff --git a/chrome/browser/ui/views/infobars/infobar_container.h b/chrome/browser/ui/views/infobars/infobar_container.h
index 0715192..4dba347 100644
--- a/chrome/browser/ui/views/infobars/infobar_container.h
+++ b/chrome/browser/ui/views/infobars/infobar_container.h
@@ -68,14 +68,14 @@ class InfoBarContainer : public AccessiblePaneView,
typedef std::set<InfoBarView*> InfoBars;
// AccessiblePaneView:
- virtual gfx::Size GetPreferredSize() OVERRIDE;
- virtual void Layout() OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual gfx::Size GetPreferredSize();
+ virtual void Layout();
+ virtual AccessibilityTypes::Role GetAccessibleRole();
// NotificationObserver:
virtual void Observe(NotificationType type,
const NotificationSource& source,
- const NotificationDetails& details) OVERRIDE;
+ const NotificationDetails& details);
// Removes an InfoBar for the specified delegate, in response to a
// notification from the selected TabContents. The InfoBar's disappearance
diff --git a/chrome/browser/ui/views/infobars/infobar_view.cc b/chrome/browser/ui/views/infobars/infobar_view.cc
index 97689bf..c973d2a 100644
--- a/chrome/browser/ui/views/infobars/infobar_view.cc
+++ b/chrome/browser/ui/views/infobars/infobar_view.cc
@@ -13,7 +13,6 @@
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
#include "third_party/skia/include/effects/SkGradientShader.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/animation/slide_animation.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
@@ -55,6 +54,9 @@ InfoBarView::InfoBarView(InfoBarDelegate* delegate)
InfoBarDelegate::Type infobar_type = delegate->GetInfoBarType();
set_background(new InfoBarBackground(infobar_type));
+ SetAccessibleName(l10n_util::GetStringUTF16(
+ (infobar_type == InfoBarDelegate::WARNING_TYPE) ?
+ IDS_ACCNAME_INFOBAR_WARNING : IDS_ACCNAME_INFOBAR_PAGE_ACTION));
animation_->SetTweenType(ui::Tween::LINEAR);
}
@@ -271,8 +273,7 @@ void InfoBarView::ViewHierarchyChanged(bool is_add, View* parent, View* child) {
#endif
if (GetFocusManager())
GetFocusManager()->AddFocusChangeListener(this);
- GetWidget()->NotifyAccessibilityEvent(
- this, ui::AccessibilityTypes::EVENT_ALERT, true);
+ NotifyAccessibilityEvent(AccessibilityTypes::EVENT_ALERT);
if (close_button_ == NULL) {
SkBitmap* image = delegate_->GetIcon();
@@ -363,11 +364,8 @@ int InfoBarView::OffsetY(const gfx::Size prefsize) const {
return CenterY(prefsize) - (target_height_ - height());
}
-void InfoBarView::GetAccessibleState(ui::AccessibleViewState* state) {
- state->name = l10n_util::GetStringUTF16(
- (delegate_->GetInfoBarType() == InfoBarDelegate::WARNING_TYPE) ?
- IDS_ACCNAME_INFOBAR_WARNING : IDS_ACCNAME_INFOBAR_PAGE_ACTION);
- state->role = ui::AccessibilityTypes::ROLE_ALERT;
+AccessibilityTypes::Role InfoBarView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_ALERT;
}
gfx::Size InfoBarView::GetPreferredSize() {
@@ -379,10 +377,8 @@ void InfoBarView::FocusWillChange(View* focused_before, View* focused_now) {
// This will trigger some screen readers to read the entire contents of this
// infobar.
if (focused_before && focused_now && !this->Contains(focused_before) &&
- this->Contains(focused_now)) {
- GetWidget()->NotifyAccessibilityEvent(
- this, ui::AccessibilityTypes::EVENT_ALERT, true);
- }
+ this->Contains(focused_now))
+ NotifyAccessibilityEvent(AccessibilityTypes::EVENT_ALERT);
}
void InfoBarView::AnimationEnded(const ui::Animation* animation) {
diff --git a/chrome/browser/ui/views/infobars/infobar_view.h b/chrome/browser/ui/views/infobars/infobar_view.h
index dbe847f..fe3655b 100644
--- a/chrome/browser/ui/views/infobars/infobar_view.h
+++ b/chrome/browser/ui/views/infobars/infobar_view.h
@@ -106,16 +106,14 @@ class InfoBarView : public InfoBar,
bool needs_elevation);
// views::View:
- virtual void Layout() OVERRIDE;
- virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child)
- OVERRIDE;
+ virtual void Layout();
+ virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child);
// views::ButtonListener:
- virtual void ButtonPressed(views::Button* sender, const views::Event& event)
- OVERRIDE;
+ virtual void ButtonPressed(views::Button* sender, const views::Event& event);
// ui::AnimationDelegate:
- virtual void AnimationProgressed(const ui::Animation* animation) OVERRIDE;
+ virtual void AnimationProgressed(const ui::Animation* animation);
// Returns the minimum width the content (that is, everything between the icon
// and the close button) can be shrunk to. This is used to prevent the close
@@ -149,15 +147,14 @@ class InfoBarView : public InfoBar,
static const int kHorizontalPadding;
// views::View:
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
- virtual gfx::Size GetPreferredSize() OVERRIDE;
+ virtual AccessibilityTypes::Role GetAccessibleRole();
+ virtual gfx::Size GetPreferredSize();
// views::FocusChangeListener:
- virtual void FocusWillChange(View* focused_before, View* focused_now)
- OVERRIDE;
+ virtual void FocusWillChange(View* focused_before, View* focused_now);
// ui::AnimationDelegate:
- virtual void AnimationEnded(const ui::Animation* animation) OVERRIDE;
+ virtual void AnimationEnded(const ui::Animation* animation);
// Destroys the external focus tracker, if present. If |restore_focus| is
// true, restores focus to the view tracked by the focus tracker before doing
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index 6afd564..686c6f7 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -37,7 +37,6 @@
#include "content/browser/renderer_host/render_widget_host_view.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/dragdrop/drag_drop_types.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
@@ -173,6 +172,8 @@ void LocationBarView::Init() {
location_entry_view_ = location_entry_->AddToView(this);
location_entry_view_->SetID(VIEW_ID_AUTOCOMPLETE);
+ location_entry_view_->SetAccessibleName(
+ l10n_util::GetStringUTF16(IDS_ACCNAME_LOCATION));
selected_keyword_view_ = new SelectedKeywordView(
kSelectedKeywordBackgroundImages, IDR_KEYWORD_SEARCH_MAGNIFIER,
@@ -204,6 +205,8 @@ void LocationBarView::Init() {
star_view_->SetVisible(true);
}
+ SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_LOCATION));
+
// Initialize the location entry. We do this to avoid a black flash which is
// visible when the location entry has just been initialized.
Update(NULL);
@@ -1052,9 +1055,8 @@ bool LocationBarView::SkipDefaultKeyEventProcessing(const views::KeyEvent& e) {
#endif
}
-void LocationBarView::GetAccessibleState(ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_GROUPING;
- state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_LOCATION);
+AccessibilityTypes::Role LocationBarView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_GROUPING;
}
void LocationBarView::WriteDragData(views::View* sender,
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.h b/chrome/browser/ui/views/location_bar/location_bar_view.h
index 2226c3a..90607c8 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.h
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.h
@@ -208,7 +208,7 @@ class LocationBarView : public LocationBar,
// Overridden from views::View:
virtual std::string GetClassName() const OVERRIDE;
virtual bool SkipDefaultKeyEventProcessing(const views::KeyEvent& e) OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual AccessibilityTypes::Role GetAccessibleRole() OVERRIDE;
// Overridden from views::DragController:
virtual void WriteDragData(View* sender,
diff --git a/chrome/browser/ui/views/location_bar/page_action_image_view.cc b/chrome/browser/ui/views/location_bar/page_action_image_view.cc
index 1127067..1e7ca9a 100644
--- a/chrome/browser/ui/views/location_bar/page_action_image_view.cc
+++ b/chrome/browser/ui/views/location_bar/page_action_image_view.cc
@@ -8,13 +8,12 @@
#include "chrome/browser/browser_list.h"
#include "chrome/browser/extensions/extension_browser_event_router.h"
#include "chrome/browser/extensions/extension_service.h"
-#include "chrome/browser/platform_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
+#include "chrome/browser/platform_util.h"
#include "chrome/common/extensions/extension_action.h"
#include "chrome/common/extensions/extension_resource.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "views/controls/menu/menu_2.h"
PageActionImageView::PageActionImageView(LocationBarView* owner,
@@ -102,8 +101,8 @@ void PageActionImageView::ExecuteAction(int button,
}
}
-void PageActionImageView::GetAccessibleState(ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_PUSHBUTTON;
+AccessibilityTypes::Role PageActionImageView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_PUSHBUTTON;
}
bool PageActionImageView::OnMousePressed(const views::MouseEvent& event) {
diff --git a/chrome/browser/ui/views/location_bar/page_action_image_view.h b/chrome/browser/ui/views/location_bar/page_action_image_view.h
index 47c39fd..ed0f190 100644
--- a/chrome/browser/ui/views/location_bar/page_action_image_view.h
+++ b/chrome/browser/ui/views/location_bar/page_action_image_view.h
@@ -41,23 +41,21 @@ class PageActionImageView : public views::ImageView,
}
// Overridden from view.
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
- virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE;
- virtual void OnMouseReleased(const views::MouseEvent& event, bool canceled)
- OVERRIDE;
- virtual bool OnKeyPressed(const views::KeyEvent& e) OVERRIDE;
- virtual void ShowContextMenu(const gfx::Point& p, bool is_mouse_gesture)
- OVERRIDE;
+ virtual AccessibilityTypes::Role GetAccessibleRole();
+ virtual bool OnMousePressed(const views::MouseEvent& event);
+ virtual void OnMouseReleased(const views::MouseEvent& event, bool canceled);
+ virtual bool OnKeyPressed(const views::KeyEvent& e);
+ virtual void ShowContextMenu(const gfx::Point& p, bool is_mouse_gesture);
// Overridden from ImageLoadingTracker.
virtual void OnImageLoaded(
- SkBitmap* image, ExtensionResource resource, int index) OVERRIDE;
+ SkBitmap* image, ExtensionResource resource, int index);
// Overridden from ExtensionContextMenuModelModel::Delegate
- virtual void InspectPopup(ExtensionAction* action) OVERRIDE;
+ virtual void InspectPopup(ExtensionAction* action);
// Overridden from ExtensionPopup::Observer
- virtual void ExtensionPopupIsClosing(ExtensionPopup* popup) OVERRIDE;
+ virtual void ExtensionPopupIsClosing(ExtensionPopup* popup);
// Called to notify the PageAction that it should determine whether to be
// visible or hidden. |contents| is the TabContents that is active, |url| is
diff --git a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc
index fd6d717..75cc136 100644
--- a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc
+++ b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc
@@ -6,7 +6,6 @@
#include "chrome/browser/ui/views/location_bar/page_action_image_view.h"
#include "chrome/common/extensions/extension.h"
-#include "ui/base/accessibility/accessible_view_state.h"
PageActionWithBadgeView::PageActionWithBadgeView(
PageActionImageView* image_view) {
@@ -14,9 +13,8 @@ PageActionWithBadgeView::PageActionWithBadgeView(
AddChildView(image_view_);
}
-void PageActionWithBadgeView::GetAccessibleState(
- ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_GROUPING;
+AccessibilityTypes::Role PageActionWithBadgeView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_GROUPING;
}
gfx::Size PageActionWithBadgeView::GetPreferredSize() {
diff --git a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.h b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.h
index 06f145d..6071bad 100644
--- a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.h
+++ b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.h
@@ -20,9 +20,8 @@ class PageActionWithBadgeView : public views::View {
PageActionImageView* image_view() { return image_view_; }
- // View overrides:
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
- virtual gfx::Size GetPreferredSize() OVERRIDE;
+ virtual AccessibilityTypes::Role GetAccessibleRole();
+ virtual gfx::Size GetPreferredSize();
void UpdateVisibility(TabContents* contents, const GURL& url);
diff --git a/chrome/browser/ui/views/location_bar/star_view.cc b/chrome/browser/ui/views/location_bar/star_view.cc
index 2e49fc7..886aec2 100644
--- a/chrome/browser/ui/views/location_bar/star_view.cc
+++ b/chrome/browser/ui/views/location_bar/star_view.cc
@@ -11,7 +11,6 @@
#include "chrome/browser/ui/views/browser_dialogs.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
@@ -28,13 +27,16 @@ StarView::~StarView() {
void StarView::SetToggled(bool on) {
SetTooltipText(UTF16ToWide(l10n_util::GetStringUTF16(
on ? IDS_TOOLTIP_STARRED : IDS_TOOLTIP_STAR)));
+ // Since StarView is an ImageView, the SetTooltipText changes the accessible
+ // name. To keep the accessible name unchanged, we need to set the accessible
+ // name right after we modify the tooltip text for this view.
+ SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_STAR));
SetImage(ResourceBundle::GetSharedInstance().GetBitmapNamed(
on ? IDR_STAR_LIT : IDR_STAR));
}
-void StarView::GetAccessibleState(ui::AccessibleViewState* state) {
- state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_STAR);
- state->role = ui::AccessibilityTypes::ROLE_PUSHBUTTON;
+AccessibilityTypes::Role StarView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_PUSHBUTTON;
}
bool StarView::GetTooltipText(const gfx::Point& p, std::wstring* tooltip) {
diff --git a/chrome/browser/ui/views/location_bar/star_view.h b/chrome/browser/ui/views/location_bar/star_view.h
index f27f3f0..ad02f9e 100644
--- a/chrome/browser/ui/views/location_bar/star_view.h
+++ b/chrome/browser/ui/views/location_bar/star_view.h
@@ -27,19 +27,17 @@ class StarView : public views::ImageView, public InfoBubbleDelegate {
private:
// views::ImageView overrides:
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
- virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip)
- OVERRIDE;
- virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE;
- virtual void OnMouseReleased(const views::MouseEvent& event, bool canceled)
- OVERRIDE;
- virtual bool OnKeyPressed(const views::KeyEvent& e) OVERRIDE;
+ virtual AccessibilityTypes::Role GetAccessibleRole();
+ virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip);
+ virtual bool OnMousePressed(const views::MouseEvent& event);
+ virtual void OnMouseReleased(const views::MouseEvent& event, bool canceled);
+ virtual bool OnKeyPressed(const views::KeyEvent& e);
// InfoBubbleDelegate overrides:
virtual void InfoBubbleClosing(InfoBubble* info_bubble,
- bool closed_by_escape) OVERRIDE;
- virtual bool CloseOnEscape() OVERRIDE;
- virtual bool FadeInOnShow() OVERRIDE { return false; }
+ bool closed_by_escape);
+ virtual bool CloseOnEscape();
+ virtual bool FadeInOnShow() { return false; }
// The CommandUpdater for the Browser object that owns the location bar.
CommandUpdater* command_updater_;
diff --git a/chrome/browser/ui/views/options/general_page_view.cc b/chrome/browser/ui/views/options/general_page_view.cc
index 621ffae..0996b4a 100644
--- a/chrome/browser/ui/views/options/general_page_view.cc
+++ b/chrome/browser/ui/views/options/general_page_view.cc
@@ -35,7 +35,6 @@
#include "chrome/installer/util/browser_distribution.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/models/combobox_model.h"
#include "views/controls/button/radio_button.h"
@@ -67,8 +66,8 @@ class OptionsGroupContents : public views::View {
OptionsGroupContents() { }
// views::View overrides:
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE {
- state->state = ui::AccessibilityTypes::ROLE_GROUPING;
+ virtual AccessibilityTypes::Role GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_GROUPING;
}
private:
diff --git a/chrome/browser/ui/views/options/options_group_view.cc b/chrome/browser/ui/views/options/options_group_view.cc
index 7a7d741..f4a9670 100644
--- a/chrome/browser/ui/views/options/options_group_view.cc
+++ b/chrome/browser/ui/views/options/options_group_view.cc
@@ -9,9 +9,8 @@
#include "base/string_number_conversions.h"
#include "base/utf_string_conversions.h"
-#include "grit/generated_resources.h"
#include "grit/locale_settings.h"
-#include "ui/base/accessibility/accessible_view_state.h"
+#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/canvas.h"
@@ -51,6 +50,9 @@ OptionsGroupView::OptionsGroupView(views::View* contents,
description_label_->SetMultiLine(true);
description_label_->SetHorizontalAlignment(views::Label::ALIGN_LEFT);
+
+ SetAccessibleName(WideToUTF16Hack(title));
+ contents->SetAccessibleName(WideToUTF16Hack(title));
}
OptionsGroupView::~OptionsGroupView() {
@@ -68,9 +70,8 @@ int OptionsGroupView::GetContentsWidth() const {
///////////////////////////////////////////////////////////////////////////////
// OptionsGroupView, views::View overrides:
-void OptionsGroupView::GetAccessibleState(ui::AccessibleViewState* state) {
- title_label_->GetAccessibleState(state);
- state->role = ui::AccessibilityTypes::ROLE_GROUPING;
+AccessibilityTypes::Role OptionsGroupView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_GROUPING;
}
void OptionsGroupView::OnPaint(gfx::Canvas* canvas) {
diff --git a/chrome/browser/ui/views/options/options_group_view.h b/chrome/browser/ui/views/options/options_group_view.h
index 2add3c4..1d32c0a 100644
--- a/chrome/browser/ui/views/options/options_group_view.h
+++ b/chrome/browser/ui/views/options/options_group_view.h
@@ -35,11 +35,11 @@ class OptionsGroupView : public views::View {
protected:
// views::View overrides:
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
- virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
+ virtual AccessibilityTypes::Role GetAccessibleRole();
+ virtual void OnPaint(gfx::Canvas* canvas);
virtual void ViewHierarchyChanged(bool is_add,
views::View* parent,
- views::View* child) OVERRIDE;
+ views::View* child);
private:
void Init();
diff --git a/chrome/browser/ui/views/options/options_page_view.cc b/chrome/browser/ui/views/options/options_page_view.cc
index 3cbf3a5..b81b3af 100644
--- a/chrome/browser/ui/views/options/options_page_view.cc
+++ b/chrome/browser/ui/views/options/options_page_view.cc
@@ -5,7 +5,6 @@
#include "chrome/browser/ui/views/options/options_page_view.h"
#include "chrome/browser/metrics/user_metrics.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "views/widget/widget.h"
///////////////////////////////////////////////////////////////////////////////
@@ -34,6 +33,6 @@ void OptionsPageView::ViewHierarchyChanged(bool is_add,
}
}
-void OptionsPageView::GetAccessibleState(ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_PAGETAB;
+AccessibilityTypes::Role OptionsPageView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_PAGETAB;
}
diff --git a/chrome/browser/ui/views/options/options_page_view.h b/chrome/browser/ui/views/options/options_page_view.h
index de438a1..bbbc8c4 100644
--- a/chrome/browser/ui/views/options/options_page_view.h
+++ b/chrome/browser/ui/views/options/options_page_view.h
@@ -39,8 +39,8 @@ class OptionsPageView : public views::View,
// views::View overrides:
virtual void ViewHierarchyChanged(bool is_add,
views::View* parent,
- views::View* child) OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ views::View* child);
+ virtual AccessibilityTypes::Role GetAccessibleRole();
private:
// Whether or not the control layout has been initialized for this page.
diff --git a/chrome/browser/ui/views/options/options_window_view.cc b/chrome/browser/ui/views/options/options_window_view.cc
index 91d4290..7126f7d 100644
--- a/chrome/browser/ui/views/options/options_window_view.cc
+++ b/chrome/browser/ui/views/options/options_window_view.cc
@@ -17,7 +17,6 @@
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
#include "grit/locale_settings.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/l10n/l10n_util.h"
#include "views/controls/tabbed_pane/tabbed_pane.h"
#include "views/widget/root_view.h"
@@ -40,29 +39,29 @@ class OptionsWindowView : public views::View,
void ShowOptionsPage(OptionsPage page, OptionsGroup highlight_group);
// views::DialogDelegate implementation:
- virtual int GetDialogButtons() const OVERRIDE {
+ virtual int GetDialogButtons() const {
return MessageBoxFlags::DIALOGBUTTON_CANCEL;
}
- virtual std::wstring GetWindowTitle() const OVERRIDE;
- virtual std::wstring GetWindowName() const OVERRIDE;
- virtual void WindowClosing() OVERRIDE;
- virtual bool Cancel() OVERRIDE;
- virtual views::View* GetContentsView() OVERRIDE;
- virtual bool ShouldRestoreWindowSize() const OVERRIDE;
+ virtual std::wstring GetWindowTitle() const;
+ virtual std::wstring GetWindowName() const;
+ virtual void WindowClosing();
+ virtual bool Cancel();
+ virtual views::View* GetContentsView();
+ virtual bool ShouldRestoreWindowSize() const;
// views::TabbedPane::Listener implementation:
- virtual void TabSelectedAt(int index) OVERRIDE;
+ virtual void TabSelectedAt(int index);
// views::View overrides:
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
- virtual void Layout() OVERRIDE;
- virtual gfx::Size GetPreferredSize() OVERRIDE;
+ virtual AccessibilityTypes::Role GetAccessibleRole();
+ virtual void Layout();
+ virtual gfx::Size GetPreferredSize();
protected:
// views::View overrides:
virtual void ViewHierarchyChanged(bool is_add,
views::View* parent,
- views::View* child) OVERRIDE;
+ views::View* child);
private:
// Init the assorted Tabbed pages
void Init();
@@ -167,8 +166,8 @@ void OptionsWindowView::TabSelectedAt(int index) {
///////////////////////////////////////////////////////////////////////////////
// OptionsWindowView, views::View overrides:
-void OptionsWindowView::GetAccessibleState(ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_CLIENT;
+AccessibilityTypes::Role OptionsWindowView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_CLIENT;
}
void OptionsWindowView::Layout() {
diff --git a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc
index 6ac2a5b8..f99517c 100644
--- a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc
+++ b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc
@@ -9,7 +9,6 @@
#include "content/browser/renderer_host/render_widget_host_view.h"
#include "content/browser/tab_contents/interstitial_page.h"
#include "content/browser/tab_contents/tab_contents.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "views/focus/focus_manager.h"
////////////////////////////////////////////////////////////////////////////////
@@ -131,9 +130,8 @@ void NativeTabContentsContainerGtk::AboutToRequestFocusFromTabTraversal(
container_->tab_contents()->FocusThroughTabTraversal(reverse);
}
-void NativeTabContentsContainerGtk::GetAccessibleState(
- ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_GROUPING;
+AccessibilityTypes::Role NativeTabContentsContainerGtk::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_GROUPING;
}
////////////////////////////////////////////////////////////////////////////////
diff --git a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.h b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.h
index 469f11e..004b689 100644
--- a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.h
+++ b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.h
@@ -33,7 +33,7 @@ class NativeTabContentsContainerGtk : public NativeTabContentsContainer,
virtual void OnFocus() OVERRIDE;
virtual void RequestFocus() OVERRIDE;
virtual void AboutToRequestFocusFromTabTraversal(bool reverse) OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual AccessibilityTypes::Role GetAccessibleRole() OVERRIDE;
private:
TabContentsContainer* container_;
diff --git a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc
index f0f7c9d..e4dfd02 100644
--- a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc
+++ b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc
@@ -10,7 +10,7 @@
#include "content/browser/renderer_host/render_widget_host_view.h"
#include "content/browser/tab_contents/interstitial_page.h"
#include "content/browser/tab_contents/tab_contents.h"
-#include "ui/base/accessibility/accessible_view_state.h"
+
#include "views/focus/focus_manager.h"
////////////////////////////////////////////////////////////////////////////////
@@ -129,9 +129,8 @@ void NativeTabContentsContainerWin::AboutToRequestFocusFromTabTraversal(
container_->tab_contents()->FocusThroughTabTraversal(reverse);
}
-void NativeTabContentsContainerWin::GetAccessibleState(
- ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_GROUPING;
+AccessibilityTypes::Role NativeTabContentsContainerWin::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_GROUPING;
}
////////////////////////////////////////////////////////////////////////////////
diff --git a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.h b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.h
index 4d60be22..1cfb5b5 100644
--- a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.h
+++ b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.h
@@ -30,7 +30,7 @@ class NativeTabContentsContainerWin : public NativeTabContentsContainer,
virtual void OnFocus() OVERRIDE;
virtual void RequestFocus() OVERRIDE;
virtual void AboutToRequestFocusFromTabTraversal(bool reverse) OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual AccessibilityTypes::Role GetAccessibleRole() OVERRIDE;
private:
TabContentsContainer* container_;
diff --git a/chrome/browser/ui/views/tab_contents/tab_contents_container.cc b/chrome/browser/ui/views/tab_contents/tab_contents_container.cc
index 7170163..9de15da 100644
--- a/chrome/browser/ui/views/tab_contents/tab_contents_container.cc
+++ b/chrome/browser/ui/views/tab_contents/tab_contents_container.cc
@@ -12,7 +12,6 @@
#include "content/browser/renderer_host/render_widget_host_view.h"
#include "content/browser/tab_contents/interstitial_page.h"
#include "content/browser/tab_contents/tab_contents.h"
-#include "ui/base/accessibility/accessible_view_state.h"
////////////////////////////////////////////////////////////////////////////////
@@ -44,8 +43,8 @@ void TabContentsContainer::Observe(NotificationType type,
////////////////////////////////////////////////////////////////////////////////
// TabContentsContainer, View overrides:
-void TabContentsContainer::GetAccessibleState(ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_WINDOW;
+AccessibilityTypes::Role TabContentsContainer::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_WINDOW;
}
////////////////////////////////////////////////////////////////////////////////
diff --git a/chrome/browser/ui/views/tab_contents/tab_contents_container_native.h b/chrome/browser/ui/views/tab_contents/tab_contents_container_native.h
index 94ab8bb..a845464 100644
--- a/chrome/browser/ui/views/tab_contents/tab_contents_container_native.h
+++ b/chrome/browser/ui/views/tab_contents/tab_contents_container_native.h
@@ -44,16 +44,16 @@ class TabContentsContainer : public views::View,
// Overridden from NotificationObserver:
virtual void Observe(NotificationType type,
const NotificationSource& source,
- const NotificationDetails& details) OVERRIDE;
+ const NotificationDetails& details);
// Overridden from views::View:
- virtual void Layout() OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual void Layout();
+ virtual AccessibilityTypes::Role GetAccessibleRole();
protected:
// Overridden from views::View:
virtual void ViewHierarchyChanged(bool is_add, views::View* parent,
- views::View* child) OVERRIDE;
+ views::View* child);
private:
// Add or remove observers for events that we care about.
diff --git a/chrome/browser/ui/views/tab_contents/tab_contents_container_views.h b/chrome/browser/ui/views/tab_contents/tab_contents_container_views.h
index 7330f30..d5a79aa 100644
--- a/chrome/browser/ui/views/tab_contents/tab_contents_container_views.h
+++ b/chrome/browser/ui/views/tab_contents/tab_contents_container_views.h
@@ -43,9 +43,9 @@ class TabContentsContainer : public views::View,
// Overridden from NotificationObserver:
virtual void Observe(NotificationType type,
const NotificationSource& source,
- const NotificationDetails& details) OVERRIDE;
+ const NotificationDetails& details);
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual AccessibilityTypes::Role GetAccessibleRole();
private:
// Add or remove observers for events that we care about.
diff --git a/chrome/browser/ui/views/tabs/base_tab.cc b/chrome/browser/ui/views/tabs/base_tab.cc
index e4a2643..9c99e47 100644
--- a/chrome/browser/ui/views/tabs/base_tab.cc
+++ b/chrome/browser/ui/views/tabs/base_tab.cc
@@ -9,15 +9,14 @@
#include "base/command_line.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
#include "chrome/browser/ui/view_ids.h"
#include "chrome/browser/ui/views/tabs/tab_controller.h"
+#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
#include "chrome/common/chrome_switches.h"
#include "content/browser/tab_contents/tab_contents.h"
#include "grit/app_resources.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/animation/slide_animation.h"
#include "ui/base/animation/throb_animation.h"
#include "ui/base/l10n/l10n_util.h"
@@ -213,6 +212,9 @@ void BaseTab::SetData(const TabRendererData& data) {
ResetCrashedFavIcon();
}
+ // Sets the accessible name for the tab.
+ SetAccessibleName(data_.title);
+
DataChanged(old);
Layout();
@@ -346,12 +348,11 @@ bool BaseTab::GetTooltipText(const gfx::Point& p, std::wstring* tooltip) {
return false;
}
-void BaseTab::GetAccessibleState(ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_PAGETAB;
- state->name = data_.title;
+AccessibilityTypes::Role BaseTab::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_PAGETAB;
}
-ui::ThemeProvider* BaseTab::GetThemeProvider() const {
+ui::ThemeProvider* BaseTab::GetThemeProvider() {
ui::ThemeProvider* tp = View::GetThemeProvider();
return tp ? tp : theme_provider_;
}
diff --git a/chrome/browser/ui/views/tabs/base_tab.h b/chrome/browser/ui/views/tabs/base_tab.h
index 75d34fc..8a43f06 100644
--- a/chrome/browser/ui/views/tabs/base_tab.h
+++ b/chrome/browser/ui/views/tabs/base_tab.h
@@ -83,16 +83,15 @@ class BaseTab : public ui::AnimationDelegate,
bool IsCloseable() const;
// views::View overrides:
- virtual void OnMouseEntered(const views::MouseEvent& event) OVERRIDE;
- virtual void OnMouseExited(const views::MouseEvent& event) OVERRIDE;
- virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE;
- virtual bool OnMouseDragged(const views::MouseEvent& event) OVERRIDE;
+ virtual void OnMouseEntered(const views::MouseEvent& event);
+ virtual void OnMouseExited(const views::MouseEvent& event);
+ virtual bool OnMousePressed(const views::MouseEvent& event);
+ virtual bool OnMouseDragged(const views::MouseEvent& event);
virtual void OnMouseReleased(const views::MouseEvent& event,
- bool canceled) OVERRIDE;
- virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip)
- OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
- virtual ThemeProvider* GetThemeProvider() const OVERRIDE;
+ bool canceled);
+ virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip);
+ virtual AccessibilityTypes::Role GetAccessibleRole();
+ virtual ThemeProvider* GetThemeProvider();
protected:
// Invoked from SetData after |data_| has been updated to the new data.
@@ -120,18 +119,18 @@ class BaseTab : public ui::AnimationDelegate,
void PaintTitle(gfx::Canvas* canvas, SkColor title_color);
// Overridden from AnimationDelegate:
- virtual void AnimationProgressed(const ui::Animation* animation) OVERRIDE;
- virtual void AnimationCanceled(const ui::Animation* animation) OVERRIDE;
- virtual void AnimationEnded(const ui::Animation* animation) OVERRIDE;
+ virtual void AnimationProgressed(const ui::Animation* animation);
+ virtual void AnimationCanceled(const ui::Animation* animation);
+ virtual void AnimationEnded(const ui::Animation* animation);
// views::ButtonListener overrides:
virtual void ButtonPressed(views::Button* sender,
- const views::Event& event) OVERRIDE;
+ const views::Event& event);
// views::ContextMenuController overrides:
virtual void ShowContextMenu(views::View* source,
const gfx::Point& p,
- bool is_mouse_gesture) OVERRIDE;
+ bool is_mouse_gesture);
// Returns the bounds of the title and icon.
virtual const gfx::Rect& GetTitleBounds() const = 0;
diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc
index e316db6..059c7e5 100644
--- a/chrome/browser/ui/views/tabs/tab_strip.cc
+++ b/chrome/browser/ui/views/tabs/tab_strip.cc
@@ -16,7 +16,6 @@
#include "chrome/browser/ui/views/tabs/tab_strip_controller.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/animation/animation_container.h"
#include "ui/base/dragdrop/drag_drop_types.h"
#include "ui/base/l10n/l10n_util.h"
@@ -364,9 +363,8 @@ int TabStrip::OnPerformDrop(const DropTargetEvent& event) {
return GetDropEffect(event);
}
-void TabStrip::GetAccessibleState(ui::AccessibleViewState* state) {
- state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_TABSTRIP);
- state->role = ui::AccessibilityTypes::ROLE_PAGETABLIST;
+AccessibilityTypes::Role TabStrip::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_PAGETABLIST;
}
views::View* TabStrip::GetEventHandlerForPoint(const gfx::Point& point) {
diff --git a/chrome/browser/ui/views/tabs/tab_strip.h b/chrome/browser/ui/views/tabs/tab_strip.h
index 45cdf45..7f0a339 100644
--- a/chrome/browser/ui/views/tabs/tab_strip.h
+++ b/chrome/browser/ui/views/tabs/tab_strip.h
@@ -56,30 +56,29 @@ class TabStrip : public BaseTabStrip,
virtual void MouseMovedOutOfView();
// BaseTabStrip implementation:
- virtual void SetBackgroundOffset(const gfx::Point& offset) OVERRIDE;
- virtual bool IsPositionInWindowCaption(const gfx::Point& point) OVERRIDE;
- virtual void PrepareForCloseAt(int model_index) OVERRIDE;
- virtual void RemoveTabAt(int model_index) OVERRIDE;
- virtual void SelectTabAt(int old_model_index, int new_model_index) OVERRIDE;
- virtual void TabTitleChangedNotLoading(int model_index) OVERRIDE;
- virtual void StartHighlight(int model_index) OVERRIDE;
- virtual void StopAllHighlighting() OVERRIDE;
- virtual BaseTab* CreateTabForDragging() OVERRIDE;
+ virtual void SetBackgroundOffset(const gfx::Point& offset);
+ virtual bool IsPositionInWindowCaption(const gfx::Point& point);
+ virtual void PrepareForCloseAt(int model_index);
+ virtual void RemoveTabAt(int model_index);
+ virtual void SelectTabAt(int old_model_index, int new_model_index);
+ virtual void TabTitleChangedNotLoading(int model_index);
+ virtual void StartHighlight(int model_index);
+ virtual void StopAllHighlighting();
+ virtual BaseTab* CreateTabForDragging();
// views::View overrides:
- virtual void PaintChildren(gfx::Canvas* canvas) OVERRIDE;
- virtual const views::View* GetViewByID(int id) const OVERRIDE;
- virtual gfx::Size GetPreferredSize() OVERRIDE;
+ virtual void PaintChildren(gfx::Canvas* canvas);
+ virtual const views::View* GetViewByID(int id) const;
+ virtual gfx::Size GetPreferredSize();
// NOTE: the drag and drop methods are invoked from FrameView. This is done to
// allow for a drop region that extends outside the bounds of the TabStrip.
- virtual void OnDragEntered(const views::DropTargetEvent& event) OVERRIDE;
- virtual int OnDragUpdated(const views::DropTargetEvent& event) OVERRIDE;
- virtual void OnDragExited() OVERRIDE;
- virtual int OnPerformDrop(const views::DropTargetEvent& event) OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
- virtual views::View* GetEventHandlerForPoint(const gfx::Point& point)
- OVERRIDE;
- virtual void OnThemeChanged() OVERRIDE;
+ virtual void OnDragEntered(const views::DropTargetEvent& event);
+ virtual int OnDragUpdated(const views::DropTargetEvent& event);
+ virtual void OnDragExited();
+ virtual int OnPerformDrop(const views::DropTargetEvent& event);
+ virtual AccessibilityTypes::Role GetAccessibleRole();
+ virtual views::View* GetEventHandlerForPoint(const gfx::Point& point);
+ virtual void OnThemeChanged();
protected:
// BaseTabStrip overrides:
diff --git a/chrome/browser/ui/views/toolbar_view.cc b/chrome/browser/ui/views/toolbar_view.cc
index cff8fe1..1eb475a 100644
--- a/chrome/browser/ui/views/toolbar_view.cc
+++ b/chrome/browser/ui/views/toolbar_view.cc
@@ -25,7 +25,6 @@
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
-#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/canvas.h"
@@ -307,9 +306,8 @@ bool ToolbarView::SetPaneFocus(
return true;
}
-void ToolbarView::GetAccessibleState(ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_TOOLBAR;
- state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_TOOLBAR);
+AccessibilityTypes::Role ToolbarView::GetAccessibleRole() {
+ return AccessibilityTypes::ROLE_TOOLBAR;
}
////////////////////////////////////////////////////////////////////////////////
diff --git a/chrome/browser/ui/views/toolbar_view.h b/chrome/browser/ui/views/toolbar_view.h
index 42d803a..1aa143c 100644
--- a/chrome/browser/ui/views/toolbar_view.h
+++ b/chrome/browser/ui/views/toolbar_view.h
@@ -78,8 +78,6 @@ class ToolbarView : public AccessiblePaneView,
// Remove a menu listener.
void RemoveMenuListener(views::MenuListener* listener);
- virtual bool GetAcceleratorInfo(int id, ui::Accelerator* accel);
-
// Accessors...
Browser* browser() const { return browser_; }
BrowserActionsContainer* browser_actions() const { return browser_actions_; }
@@ -88,44 +86,46 @@ class ToolbarView : public AccessiblePaneView,
views::MenuButton* app_menu() const { return app_menu_; }
// Overridden from AccessiblePaneView
- virtual bool SetPaneFocus(int view_storage_id, View* initial_focus) OVERRIDE;
- virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+ virtual bool SetPaneFocus(int view_storage_id, View* initial_focus);
+ virtual AccessibilityTypes::Role GetAccessibleRole();
+
+ // Overridden from Menu::Delegate:
+ virtual bool GetAcceleratorInfo(int id, ui::Accelerator* accel);
// Overridden from views::MenuDelegate:
- virtual void RunMenu(views::View* source, const gfx::Point& pt) OVERRIDE;
+ virtual void RunMenu(views::View* source, const gfx::Point& pt);
// Overridden from LocationBarView::Delegate:
- virtual TabContentsWrapper* GetTabContentsWrapper() OVERRIDE;
- virtual InstantController* GetInstant() OVERRIDE;
- virtual void OnInputInProgress(bool in_progress) OVERRIDE;
+ virtual TabContentsWrapper* GetTabContentsWrapper();
+ virtual InstantController* GetInstant();
+ virtual void OnInputInProgress(bool in_progress);
// Overridden from CommandUpdater::CommandObserver:
- virtual void EnabledStateChangedForCommand(int id, bool enabled) OVERRIDE;
+ virtual void EnabledStateChangedForCommand(int id, bool enabled);
// Overridden from views::BaseButton::ButtonListener:
- virtual void ButtonPressed(views::Button* sender, const views::Event& event)
- OVERRIDE;
+ virtual void ButtonPressed(views::Button* sender, const views::Event& event);
// Overridden from NotificationObserver:
virtual void Observe(NotificationType type,
const NotificationSource& source,
- const NotificationDetails& details) OVERRIDE;
+ const NotificationDetails& details);
// Overridden from ui::AcceleratorProvider:
- virtual bool GetAcceleratorForCommandId(
- int command_id, ui::Accelerator* accelerator) OVERRIDE;
+ virtual bool GetAcceleratorForCommandId(int command_id,
+ ui::Accelerator* accelerator);
// Overridden from views::View:
- virtual gfx::Size GetPreferredSize() OVERRIDE;
- virtual void Layout() OVERRIDE;
- virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
+ virtual gfx::Size GetPreferredSize();
+ virtual void Layout();
+ virtual void OnPaint(gfx::Canvas* canvas);
virtual bool GetDropFormats(
int* formats,
- std::set<OSExchangeData::CustomFormat>* custom_formats) OVERRIDE;
- virtual bool CanDrop(const ui::OSExchangeData& data) OVERRIDE;
- virtual int OnDragUpdated(const views::DropTargetEvent& event) OVERRIDE;
- virtual int OnPerformDrop(const views::DropTargetEvent& event) OVERRIDE;
- virtual void OnThemeChanged() OVERRIDE;
+ std::set<OSExchangeData::CustomFormat>* custom_formats);
+ virtual bool CanDrop(const ui::OSExchangeData& data);
+ virtual int OnDragUpdated(const views::DropTargetEvent& event);
+ virtual int OnPerformDrop(const views::DropTargetEvent& event);
+ virtual void OnThemeChanged();
// The apparent horizontal space between most items, and the vertical padding
// above and below them.
@@ -137,8 +137,8 @@ class ToolbarView : public AccessiblePaneView,
protected:
// Overridden from AccessiblePaneView
- virtual views::View* GetDefaultFocusableChild() OVERRIDE;
- virtual void RemovePaneFocus() OVERRIDE;
+ virtual views::View* GetDefaultFocusableChild();
+ virtual void RemovePaneFocus();
private:
// Returns true if we should show the upgrade recommended dot.
diff --git a/chrome/browser/ui/views/wrench_menu.cc b/chrome/browser/ui/views/wrench_menu.cc
index f983fb9..2720aca 100644
--- a/chrome/browser/ui/views/wrench_menu.cc
+++ b/chrome/browser/ui/views/wrench_menu.cc
@@ -570,6 +570,7 @@ WrenchMenu::WrenchMenu(Browser* browser)
void WrenchMenu::Init(ui::MenuModel* model) {
DCHECK(!root_.get());
root_.reset(new MenuItemView(this));
+ root_->SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_APP));
root_->set_has_icons(true); // We have checks, radios and icons, set this
// so we get the taller menu style.
int next_id = 1;