diff options
author | ajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-06 22:12:28 +0000 |
---|---|---|
committer | ajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-06 22:12:28 +0000 |
commit | c694427c13725a8d73303fbe2c47e8cbd6abd6c3 (patch) | |
tree | ed40f286e831e116b5718f37e454d8dace85abfb /chrome | |
parent | 0b8545bf5feeb7e5340eeff11279402c2d06a778 (diff) | |
download | chromium_src-c694427c13725a8d73303fbe2c47e8cbd6abd6c3.zip chromium_src-c694427c13725a8d73303fbe2c47e8cbd6abd6c3.tar.gz chromium_src-c694427c13725a8d73303fbe2c47e8cbd6abd6c3.tar.bz2 |
Remove task.h and finish base::Bind() migration.
Over 341 CLs, in ~3 months, touching 3251 unique files!
Top 5 most CLs:
(121) jhawkins
( 45) dcheng
( 24) achuith
( 23) csilv
( 12) tfarina
( 12) groby
~1000 files touched:
(918) jhawkins
100+ files touched:
(486) ajwong
(385) willchan
(372) dcheng
(126) csilv
(123) fischman
(112) sergeyu
49+ files touched:
(65) tfarina
(57) acolwell
(52) adamk
(49) tzik
BUG=35223
TEST=existing
Review URL: http://codereview.chromium.org/9114020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
111 files changed, 41 insertions, 122 deletions
diff --git a/chrome/browser/autocomplete_history_manager_unittest.cc b/chrome/browser/autocomplete_history_manager_unittest.cc index b08f7f5..83f27c3 100644 --- a/chrome/browser/autocomplete_history_manager_unittest.cc +++ b/chrome/browser/autocomplete_history_manager_unittest.cc @@ -6,7 +6,6 @@ #include "base/memory/ref_counted.h" #include "base/string16.h" -#include "base/task.h" #include "base/utf_string_conversions.h" #include "chrome/browser/autocomplete_history_manager.h" #include "chrome/browser/autofill/autofill_external_delegate.h" diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc index f33ca73..85c7f3a 100644 --- a/chrome/browser/automation/automation_provider.cc +++ b/chrome/browser/automation/automation_provider.cc @@ -22,7 +22,6 @@ #include "base/string_number_conversions.h" #include "base/string_util.h" #include "base/synchronization/waitable_event.h" -#include "base/task.h" #include "base/threading/thread.h" #include "base/utf_string_conversions.h" #include "base/values.h" diff --git a/chrome/browser/automation/ui_controls_internal_win.cc b/chrome/browser/automation/ui_controls_internal_win.cc index 76be27f..39925cf 100644 --- a/chrome/browser/automation/ui_controls_internal_win.cc +++ b/chrome/browser/automation/ui_controls_internal_win.cc @@ -9,7 +9,6 @@ #include "base/logging.h" #include "base/memory/ref_counted.h" #include "base/message_loop.h" -#include "base/task.h" #include "ui/base/keycodes/keyboard_codes.h" #include "ui/base/keycodes/keyboard_code_conversion_win.h" diff --git a/chrome/browser/automation/url_request_automation_job.h b/chrome/browser/automation/url_request_automation_job.h index 096ce06..72ab6bb 100644 --- a/chrome/browser/automation/url_request_automation_job.h +++ b/chrome/browser/automation/url_request_automation_job.h @@ -8,7 +8,6 @@ #pragma once #include "base/memory/weak_ptr.h" -#include "base/task.h" #include "chrome/common/ref_counted_util.h" #include "net/url_request/url_request.h" #include "net/url_request/url_request_job.h" diff --git a/chrome/browser/background/background_contents_service.h b/chrome/browser/background/background_contents_service.h index 5e8062a..b45112c 100644 --- a/chrome/browser/background/background_contents_service.h +++ b/chrome/browser/background/background_contents_service.h @@ -12,7 +12,6 @@ #include "base/gtest_prod_util.h" #include "base/memory/ref_counted.h" -#include "base/task.h" #include "chrome/browser/profiles/profile_keyed_service.h" #include "chrome/browser/tab_contents/background_contents.h" #include "content/public/browser/notification_observer.h" diff --git a/chrome/browser/background/background_mode_manager_gtk.cc b/chrome/browser/background/background_mode_manager_gtk.cc index 27923fc..26f2b1e 100644 --- a/chrome/browser/background/background_mode_manager_gtk.cc +++ b/chrome/browser/background/background_mode_manager_gtk.cc @@ -11,7 +11,6 @@ #include "base/file_util.h" #include "base/logging.h" #include "base/nix/xdg_util.h" -#include "base/task.h" #include "chrome/browser/background/background_mode_manager.h" #include "chrome/browser/shell_integration.h" #include "chrome/browser/ui/gtk/gtk_util.h" diff --git a/chrome/browser/background/background_mode_manager_win.cc b/chrome/browser/background/background_mode_manager_win.cc index a27632a..63e846f 100644 --- a/chrome/browser/background/background_mode_manager_win.cc +++ b/chrome/browser/background/background_mode_manager_win.cc @@ -8,7 +8,6 @@ #include "base/file_path.h" #include "base/logging.h" #include "base/path_service.h" -#include "base/task.h" #include "base/utf_string_conversions.h" #include "base/win/registry.h" #include "chrome/browser/background/background_mode_manager.h" diff --git a/chrome/browser/browsing_data_quota_helper_impl.h b/chrome/browser/browsing_data_quota_helper_impl.h index d436449..26071b9 100644 --- a/chrome/browser/browsing_data_quota_helper_impl.h +++ b/chrome/browser/browsing_data_quota_helper_impl.h @@ -14,6 +14,7 @@ #include "base/compiler_specific.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" +#include "base/memory/weak_ptr.h" #include "base/time.h" #include "chrome/browser/browsing_data_quota_helper.h" #include "content/public/browser/browser_thread.h" diff --git a/chrome/browser/cancelable_request.h b/chrome/browser/cancelable_request.h index ae57ba5..9e7c5a4 100644 --- a/chrome/browser/cancelable_request.h +++ b/chrome/browser/cancelable_request.h @@ -102,7 +102,6 @@ #include "base/message_loop.h" #include "base/synchronization/cancellation_flag.h" #include "base/synchronization/lock.h" -#include "base/task.h" #include "build/build_config.h" class CancelableRequestBase; diff --git a/chrome/browser/chromeos/disks/disk_mount_manager.cc b/chrome/browser/chromeos/disks/disk_mount_manager.cc index e04abcb..e831ccf 100644 --- a/chrome/browser/chromeos/disks/disk_mount_manager.cc +++ b/chrome/browser/chromeos/disks/disk_mount_manager.cc @@ -10,6 +10,7 @@ #include <sys/statvfs.h> #include "base/bind.h" +#include "base/memory/weak_ptr.h" #include "base/observer_list.h" #include "base/string_util.h" #include "chrome/browser/chromeos/dbus/dbus_thread_manager.h" @@ -72,7 +73,7 @@ class DiskMountManagerImpl : public DiskMountManager { type, // When succeeds, OnMountCompleted will be called by // "MountCompleted" signal instead. - base::Bind(&DoNothing), + base::Bind(&base::DoNothing), base::Bind(&DiskMountManagerImpl::OnMountCompleted, weak_ptr_factory_.GetWeakPtr(), MOUNT_ERROR_INTERNAL, @@ -87,7 +88,7 @@ class DiskMountManagerImpl : public DiskMountManager { cros_disks_client_->Unmount(mount_path, base::Bind(&DiskMountManagerImpl::OnUnmountPath, weak_ptr_factory_.GetWeakPtr()), - base::Bind(&DoNothing)); + base::Bind(&base::DoNothing)); } // DiskMountManager override. @@ -219,7 +220,7 @@ class DiskMountManagerImpl : public DiskMountManager { cros_disks_client_->EnumerateAutoMountableDevices( base::Bind(&DiskMountManagerImpl::OnRequestMountInfo, weak_ptr_factory_.GetWeakPtr()), - base::Bind(&DoNothing)); + base::Bind(&base::DoNothing)); } // DiskMountManager override. @@ -395,7 +396,7 @@ class DiskMountManagerImpl : public DiskMountManager { devices[i], base::Bind(&DiskMountManagerImpl::OnGetDeviceProperties, weak_ptr_factory_.GetWeakPtr()), - base::Bind(&DoNothing)); + base::Bind(&base::DoNothing)); } } // Search and remove disks that are no longer present. @@ -422,7 +423,7 @@ class DiskMountManagerImpl : public DiskMountManager { device_path, base::Bind(&DiskMountManagerImpl::OnGetDeviceProperties, weak_ptr_factory_.GetWeakPtr()), - base::Bind(&DoNothing)); + base::Bind(&base::DoNothing)); return; } case DISK_REMOVED: { @@ -526,10 +527,6 @@ class DiskMountManagerImpl : public DiskMountManager { return EmptyString(); } - // A function to be used as an empty callback. - static void DoNothing() { - } - // Mount event change observers. ObserverList<Observer> observers_; diff --git a/chrome/browser/chromeos/external_metrics.h b/chrome/browser/chromeos/external_metrics.h index 55b0f7a..afbabe3 100644 --- a/chrome/browser/chromeos/external_metrics.h +++ b/chrome/browser/chromeos/external_metrics.h @@ -11,7 +11,7 @@ #include "base/file_path.h" #include "base/gtest_prod_util.h" #include "base/hash_tables.h" -#include "base/task.h" +#include "base/memory/ref_counted.h" namespace chromeos { diff --git a/chrome/browser/chromeos/login/existing_user_controller.h b/chrome/browser/chromeos/login/existing_user_controller.h index b22c057..ec36479 100644 --- a/chrome/browser/chromeos/login/existing_user_controller.h +++ b/chrome/browser/chromeos/login/existing_user_controller.h @@ -14,7 +14,6 @@ #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" #include "base/string16.h" -#include "base/task.h" #include "base/timer.h" #include "chrome/browser/chromeos/login/captcha_view.h" #include "chrome/browser/chromeos/login/login_display.h" diff --git a/chrome/browser/chromeos/login/login_performer.h b/chrome/browser/chromeos/login/login_performer.h index e45136a..08343cc 100644 --- a/chrome/browser/chromeos/login/login_performer.h +++ b/chrome/browser/chromeos/login/login_performer.h @@ -10,7 +10,6 @@ #include "base/basictypes.h" #include "base/memory/weak_ptr.h" -#include "base/task.h" #include "chrome/browser/chromeos/login/authenticator.h" #include "chrome/browser/chromeos/login/login_status_consumer.h" #include "chrome/browser/profiles/profile_manager.h" diff --git a/chrome/browser/chromeos/login/mock_url_fetchers.h b/chrome/browser/chromeos/login/mock_url_fetchers.h index 44254dc..02a33a0 100644 --- a/chrome/browser/chromeos/login/mock_url_fetchers.h +++ b/chrome/browser/chromeos/login/mock_url_fetchers.h @@ -11,7 +11,6 @@ #include "base/memory/weak_ptr.h" #include "base/compiler_specific.h" #include "base/message_loop.h" -#include "base/task.h" #include "content/test/test_url_fetcher_factory.h" #include "googleurl/src/gurl.h" #include "net/url_request/url_request_status.h" diff --git a/chrome/browser/chromeos/login/network_screen.h b/chrome/browser/chromeos/login/network_screen.h index 04c6ab6..483bdc1 100644 --- a/chrome/browser/chromeos/login/network_screen.h +++ b/chrome/browser/chromeos/login/network_screen.h @@ -9,7 +9,6 @@ #include "base/compiler_specific.h" #include "base/memory/ref_counted.h" #include "base/string16.h" -#include "base/task.h" #include "base/timer.h" #include "chrome/browser/chromeos/cros/network_library.h" #include "chrome/browser/chromeos/login/language_switch_menu.h" diff --git a/chrome/browser/chromeos/login/tpm_password_fetcher.h b/chrome/browser/chromeos/login/tpm_password_fetcher.h index b30783d..326e942 100644 --- a/chrome/browser/chromeos/login/tpm_password_fetcher.h +++ b/chrome/browser/chromeos/login/tpm_password_fetcher.h @@ -9,7 +9,6 @@ #include "base/basictypes.h" #include "base/memory/weak_ptr.h" -#include "base/task.h" namespace chromeos { diff --git a/chrome/browser/chromeos/login/user_manager.cc b/chrome/browser/chromeos/login/user_manager.cc index f56f299..be6fc80 100644 --- a/chrome/browser/chromeos/login/user_manager.cc +++ b/chrome/browser/chromeos/login/user_manager.cc @@ -19,7 +19,6 @@ #include "base/rand_util.h" #include "base/string_util.h" #include "base/stringprintf.h" -#include "base/task.h" #include "base/time.h" #include "base/utf_string_conversions.h" #include "base/values.h" diff --git a/chrome/browser/chromeos/net/network_change_notifier_chromeos.h b/chrome/browser/chromeos/net/network_change_notifier_chromeos.h index f41dd61..a2bf168 100644 --- a/chrome/browser/chromeos/net/network_change_notifier_chromeos.h +++ b/chrome/browser/chromeos/net/network_change_notifier_chromeos.h @@ -8,7 +8,7 @@ #include "base/basictypes.h" #include "base/compiler_specific.h" -#include "base/task.h" +#include "base/memory/weak_ptr.h" #include "chrome/browser/chromeos/cros/network_library.h" #include "chrome/browser/chromeos/dbus/power_manager_client.h" #include "net/base/network_change_notifier.h" diff --git a/chrome/browser/chromeos/offline/offline_load_page.h b/chrome/browser/chromeos/offline/offline_load_page.h index 5288291..e403949 100644 --- a/chrome/browser/chromeos/offline/offline_load_page.h +++ b/chrome/browser/chromeos/offline/offline_load_page.h @@ -9,7 +9,6 @@ #include <string> #include "base/compiler_specific.h" -#include "base/task.h" #include "chrome/browser/tab_contents/chrome_interstitial_page.h" #include "net/base/network_change_notifier.h" diff --git a/chrome/browser/chromeos/system/statistics_provider.cc b/chrome/browser/chromeos/system/statistics_provider.cc index 17e4bd2..32ef5ca 100644 --- a/chrome/browser/chromeos/system/statistics_provider.cc +++ b/chrome/browser/chromeos/system/statistics_provider.cc @@ -10,7 +10,6 @@ #include "base/logging.h" #include "base/memory/singleton.h" #include "base/synchronization/waitable_event.h" -#include "base/task.h" #include "base/time.h" #include "chrome/browser/chromeos/system/name_value_pairs_parser.h" #include "chrome/browser/chromeos/system/runtime_environment.h" diff --git a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc index a5a6690..a6c0b97 100644 --- a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc +++ b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc @@ -8,7 +8,6 @@ #include "base/memory/scoped_ptr.h" #include "base/message_loop.h" -#include "base/task.h" #include "base/utf_string_conversions.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/custom_handlers/protocol_handler.h" diff --git a/chrome/browser/download/chrome_download_manager_delegate.h b/chrome/browser/download/chrome_download_manager_delegate.h index b1e7817..b8f0ff10 100644 --- a/chrome/browser/download/chrome_download_manager_delegate.h +++ b/chrome/browser/download/chrome_download_manager_delegate.h @@ -10,7 +10,7 @@ #include "base/hash_tables.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" -#include "base/task.h" +#include "base/memory/weak_ptr.h" #include "chrome/browser/safe_browsing/download_protection_service.h" #include "content/public/browser/download_manager_delegate.h" #include "content/public/browser/notification_observer.h" diff --git a/chrome/browser/download/download_prefs.cc b/chrome/browser/download/download_prefs.cc index e6e127b..0c0a613 100644 --- a/chrome/browser/download/download_prefs.cc +++ b/chrome/browser/download/download_prefs.cc @@ -11,7 +11,6 @@ #include "base/string_split.h" #include "base/string_util.h" #include "base/sys_string_conversions.h" -#include "base/task.h" #include "base/utf_string_conversions.h" #include "chrome/browser/download/chrome_download_manager_delegate.h" #include "chrome/browser/download/download_extensions.h" diff --git a/chrome/browser/extensions/extension_cookies_api.cc b/chrome/browser/extensions/extension_cookies_api.cc index 596278e..1a8fe97 100644 --- a/chrome/browser/extensions/extension_cookies_api.cc +++ b/chrome/browser/extensions/extension_cookies_api.cc @@ -8,7 +8,6 @@ #include "base/bind.h" #include "base/json/json_writer.h" -#include "base/task.h" #include "base/values.h" #include "chrome/browser/extensions/extension_cookies_api_constants.h" #include "chrome/browser/extensions/extension_cookies_helpers.h" diff --git a/chrome/browser/extensions/extension_devtools_manager.cc b/chrome/browser/extensions/extension_devtools_manager.cc index 20f4eb0..e0a739c 100644 --- a/chrome/browser/extensions/extension_devtools_manager.cc +++ b/chrome/browser/extensions/extension_devtools_manager.cc @@ -6,7 +6,6 @@ #include "base/message_loop.h" #include "base/string_util.h" -#include "base/task.h" #include "chrome/browser/extensions/extension_devtools_bridge.h" #include "chrome/browser/extensions/extension_devtools_events.h" diff --git a/chrome/browser/extensions/extension_idle_api.cc b/chrome/browser/extensions/extension_idle_api.cc index ffdf9a7..74dc949 100644 --- a/chrome/browser/extensions/extension_idle_api.cc +++ b/chrome/browser/extensions/extension_idle_api.cc @@ -13,7 +13,6 @@ #include "base/json/json_writer.h" #include "base/message_loop.h" #include "base/stl_util.h" -#include "base/task.h" #include "base/time.h" #include "chrome/browser/extensions/extension_event_router.h" #include "chrome/browser/extensions/extension_host.h" diff --git a/chrome/browser/extensions/extension_processes_api.cc b/chrome/browser/extensions/extension_processes_api.cc index ff58808..bbf1faf 100644 --- a/chrome/browser/extensions/extension_processes_api.cc +++ b/chrome/browser/extensions/extension_processes_api.cc @@ -8,7 +8,6 @@ #include "base/json/json_writer.h" #include "base/message_loop.h" #include "base/string_number_conversions.h" -#include "base/task.h" #include "base/utf_string_conversions.h" #include "base/values.h" diff --git a/chrome/browser/extensions/extension_webrequest_api_unittest.cc b/chrome/browser/extensions/extension_webrequest_api_unittest.cc index 2d266b5b..0eb1aaf 100644 --- a/chrome/browser/extensions/extension_webrequest_api_unittest.cc +++ b/chrome/browser/extensions/extension_webrequest_api_unittest.cc @@ -9,6 +9,7 @@ #include "base/callback.h" #include "base/file_util.h" #include "base/json/json_value_serializer.h" +#include "base/memory/weak_ptr.h" #include "base/path_service.h" #include "base/stl_util.h" #include "base/utf_string_conversions.h" @@ -62,7 +63,7 @@ class TestIPCSender : public IPC::Message::Sender { // Adds a Task to the queue. We will fire these in order as events are // dispatched. - void PushTask(base::Closure task) { + void PushTask(const base::Closure& task) { task_queue_.push(task); } @@ -361,9 +362,6 @@ class ExtensionWebRequestHeaderModificationTest : scoped_refptr<TestURLRequestContext> context_; }; -static void DoNothing() { -} - TEST_P(ExtensionWebRequestHeaderModificationTest, TestModifications) { std::string extension1_id("1"); std::string extension2_id("2"); @@ -439,7 +437,7 @@ TEST_P(ExtensionWebRequestHeaderModificationTest, TestModifications) { } // Don't do anything for the onSendHeaders message. - ipc_sender_.PushTask(base::Bind(&DoNothing)); + ipc_sender_.PushTask(base::Bind(&base::DoNothing)); // Note that we mess up the headers slightly: // request.Start() will first add additional headers (e.g. the User-Agent) diff --git a/chrome/browser/extensions/settings/settings_backend.h b/chrome/browser/extensions/settings/settings_backend.h index ab36894..e80e182 100644 --- a/chrome/browser/extensions/settings/settings_backend.h +++ b/chrome/browser/extensions/settings/settings_backend.h @@ -11,7 +11,6 @@ #include "base/memory/linked_ptr.h" #include "base/memory/ref_counted.h" #include "base/observer_list_threadsafe.h" -#include "base/task.h" #include "chrome/browser/extensions/settings/settings_leveldb_storage.h" #include "chrome/browser/extensions/settings/settings_observer.h" #include "chrome/browser/extensions/settings/syncable_settings_storage.h" diff --git a/chrome/browser/extensions/settings/settings_leveldb_storage.h b/chrome/browser/extensions/settings/settings_leveldb_storage.h index 390bc61..6af1eed 100644 --- a/chrome/browser/extensions/settings/settings_leveldb_storage.h +++ b/chrome/browser/extensions/settings/settings_leveldb_storage.h @@ -12,7 +12,6 @@ #include "base/file_path.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" -#include "base/task.h" #include "chrome/browser/extensions/settings/settings_storage.h" #include "chrome/browser/extensions/settings/settings_storage_factory.h" #include "third_party/leveldatabase/src/include/leveldb/db.h" diff --git a/chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc b/chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc index 83c044a..10f379d 100644 --- a/chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc +++ b/chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc @@ -9,7 +9,6 @@ #include "base/memory/scoped_ptr.h" #include "base/message_loop.h" #include "base/metrics/histogram.h" -#include "base/task.h" namespace extensions { diff --git a/chrome/browser/extensions/settings/settings_storage_unittest.h b/chrome/browser/extensions/settings/settings_storage_unittest.h index 890b8aa..55930d5 100644 --- a/chrome/browser/extensions/settings/settings_storage_unittest.h +++ b/chrome/browser/extensions/settings/settings_storage_unittest.h @@ -12,7 +12,6 @@ #include "base/memory/scoped_ptr.h" #include "base/message_loop.h" #include "base/scoped_temp_dir.h" -#include "base/task.h" #include "chrome/browser/extensions/settings/settings_backend.h" #include "chrome/browser/extensions/settings/settings_frontend.h" #include "chrome/test/base/testing_profile.h" diff --git a/chrome/browser/extensions/settings/settings_sync_unittest.cc b/chrome/browser/extensions/settings/settings_sync_unittest.cc index ef84c79..2f7ef83 100644 --- a/chrome/browser/extensions/settings/settings_sync_unittest.cc +++ b/chrome/browser/extensions/settings/settings_sync_unittest.cc @@ -10,7 +10,6 @@ #include "base/memory/scoped_ptr.h" #include "base/message_loop.h" #include "base/scoped_temp_dir.h" -#include "base/task.h" #include "chrome/browser/extensions/settings/failing_settings_storage.h" #include "chrome/browser/extensions/settings/settings_frontend.h" #include "chrome/browser/extensions/settings/settings_storage_cache.h" diff --git a/chrome/browser/favicon/favicon_service.h b/chrome/browser/favicon/favicon_service.h index 179b743..6c8c4b1 100644 --- a/chrome/browser/favicon/favicon_service.h +++ b/chrome/browser/favicon/favicon_service.h @@ -11,7 +11,6 @@ #include "base/callback.h" #include "base/memory/ref_counted.h" #include "base/memory/ref_counted_memory.h" -#include "base/task.h" #include "chrome/browser/cancelable_request.h" #include "chrome/browser/history/history_types.h" #include "chrome/common/ref_counted_util.h" diff --git a/chrome/browser/google/google_update.cc b/chrome/browser/google/google_update.cc index dd6afd8..75eca53 100644 --- a/chrome/browser/google/google_update.cc +++ b/chrome/browser/google/google_update.cc @@ -13,7 +13,6 @@ #include "base/path_service.h" #include "base/string_util.h" #include "base/stringprintf.h" -#include "base/task.h" #include "base/threading/thread.h" #include "base/win/scoped_comptr.h" #include "base/win/windows_version.h" diff --git a/chrome/browser/history/expire_history_backend.h b/chrome/browser/history/expire_history_backend.h index 67c97b7..ed8ca36 100644 --- a/chrome/browser/history/expire_history_backend.h +++ b/chrome/browser/history/expire_history_backend.h @@ -14,7 +14,6 @@ #include "base/gtest_prod_util.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" -#include "base/task.h" #include "base/time.h" #include "chrome/browser/history/history_types.h" diff --git a/chrome/browser/history/history.cc b/chrome/browser/history/history.cc index 2f3cc3c..7ef5edd 100644 --- a/chrome/browser/history/history.cc +++ b/chrome/browser/history/history.cc @@ -29,7 +29,6 @@ #include "base/message_loop.h" #include "base/path_service.h" #include "base/string_util.h" -#include "base/task.h" #include "base/threading/thread.h" #include "chrome/browser/autocomplete/history_url_provider.h" #include "chrome/browser/browser_process.h" diff --git a/chrome/browser/history/history.h b/chrome/browser/history/history.h index 00365b5..71e4df9 100644 --- a/chrome/browser/history/history.h +++ b/chrome/browser/history/history.h @@ -15,7 +15,6 @@ #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/string16.h" -#include "base/task.h" #include "chrome/browser/cancelable_request.h" #include "chrome/browser/favicon/favicon_service.h" #include "chrome/browser/history/history_types.h" diff --git a/chrome/browser/history/history_extension_api.cc b/chrome/browser/history/history_extension_api.cc index bee3543..2d2695b 100644 --- a/chrome/browser/history/history_extension_api.cc +++ b/chrome/browser/history/history_extension_api.cc @@ -10,7 +10,6 @@ #include "base/json/json_writer.h" #include "base/message_loop.h" #include "base/string_number_conversions.h" -#include "base/task.h" #include "base/values.h" #include "chrome/browser/extensions/extension_event_router.h" #include "chrome/browser/history/history.h" diff --git a/chrome/browser/history/history_unittest.cc b/chrome/browser/history/history_unittest.cc index dba30db..66a8dbf 100644 --- a/chrome/browser/history/history_unittest.cc +++ b/chrome/browser/history/history_unittest.cc @@ -34,7 +34,6 @@ #include "base/path_service.h" #include "base/scoped_temp_dir.h" #include "base/string_util.h" -#include "base/task.h" #include "base/utf_string_conversions.h" #include "chrome/browser/history/history.h" #include "chrome/browser/history/history_backend.h" diff --git a/chrome/browser/history/shortcuts_backend.cc b/chrome/browser/history/shortcuts_backend.cc index 8d8f936..5af231a 100644 --- a/chrome/browser/history/shortcuts_backend.cc +++ b/chrome/browser/history/shortcuts_backend.cc @@ -12,7 +12,6 @@ #include "base/bind_helpers.h" #include "base/i18n/case_conversion.h" #include "base/string_util.h" -#include "base/task.h" #include "chrome/browser/autocomplete/autocomplete.h" #include "chrome/browser/autocomplete/autocomplete_match.h" #include "chrome/browser/history/history.h" diff --git a/chrome/browser/history/text_database_manager.h b/chrome/browser/history/text_database_manager.h index 89b750a..514a25e 100644 --- a/chrome/browser/history/text_database_manager.h +++ b/chrome/browser/history/text_database_manager.h @@ -14,7 +14,6 @@ #include "base/gtest_prod_util.h" #include "base/memory/weak_ptr.h" #include "base/string16.h" -#include "base/task.h" #include "base/memory/mru_cache.h" #include "chrome/browser/history/history_types.h" #include "chrome/browser/history/text_database.h" diff --git a/chrome/browser/mac/keystone_glue.mm b/chrome/browser/mac/keystone_glue.mm index f837410..6704e3c 100644 --- a/chrome/browser/mac/keystone_glue.mm +++ b/chrome/browser/mac/keystone_glue.mm @@ -18,7 +18,6 @@ #include "base/mac/scoped_nsexception_enabler.h" #include "base/memory/ref_counted.h" #include "base/sys_string_conversions.h" -#include "base/task.h" #include "base/threading/worker_pool.h" #include "chrome/browser/mac/authorization_util.h" #import "chrome/browser/mac/keystone_registration.h" diff --git a/chrome/browser/mock_browsing_data_cookie_helper.cc b/chrome/browser/mock_browsing_data_cookie_helper.cc index 2d85cab..be897b5 100644 --- a/chrome/browser/mock_browsing_data_cookie_helper.cc +++ b/chrome/browser/mock_browsing_data_cookie_helper.cc @@ -4,6 +4,8 @@ #include "chrome/browser/mock_browsing_data_cookie_helper.h" +#include "base/logging.h" + MockBrowsingDataCookieHelper::MockBrowsingDataCookieHelper(Profile* profile) : BrowsingDataCookieHelper(profile), profile_(profile) { diff --git a/chrome/browser/net/connection_tester.cc b/chrome/browser/net/connection_tester.cc index 6aa1e9a..63af8d1 100644 --- a/chrome/browser/net/connection_tester.cc +++ b/chrome/browser/net/connection_tester.cc @@ -8,8 +8,8 @@ #include "base/command_line.h" #include "base/compiler_specific.h" #include "base/logging.h" +#include "base/memory/weak_ptr.h" #include "base/message_loop.h" -#include "base/task.h" #include "base/threading/thread_restrictions.h" #include "base/utf_string_conversions.h" #include "chrome/browser/importer/firefox_proxy_settings.h" diff --git a/chrome/browser/net/cookie_policy_browsertest.cc b/chrome/browser/net/cookie_policy_browsertest.cc index ae8a3af..b41333f 100644 --- a/chrome/browser/net/cookie_policy_browsertest.cc +++ b/chrome/browser/net/cookie_policy_browsertest.cc @@ -4,7 +4,6 @@ #include "base/bind.h" #include "base/bind_helpers.h" -#include "base/task.h" #include "base/synchronization/waitable_event.h" #include "chrome/browser/content_settings/host_content_settings_map.h" #include "chrome/browser/prefs/pref_service.h" diff --git a/chrome/browser/net/crl_set_fetcher.h b/chrome/browser/net/crl_set_fetcher.h index be97726..b6958637 100644 --- a/chrome/browser/net/crl_set_fetcher.h +++ b/chrome/browser/net/crl_set_fetcher.h @@ -10,7 +10,6 @@ #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" -#include "base/task.h" #include "base/time.h" #include "chrome/browser/component_updater/component_updater_service.h" diff --git a/chrome/browser/net/net_pref_observer.cc b/chrome/browser/net/net_pref_observer.cc index 198a993..6566553 100644 --- a/chrome/browser/net/net_pref_observer.cc +++ b/chrome/browser/net/net_pref_observer.cc @@ -5,7 +5,6 @@ #include "chrome/browser/net/net_pref_observer.h" #include "base/bind.h" -#include "base/task.h" #include "chrome/browser/net/predictor.h" #include "chrome/browser/prefs/pref_service.h" #include "chrome/browser/prerender/prerender_manager.h" diff --git a/chrome/browser/net/network_stats.cc b/chrome/browser/net/network_stats.cc index 919cf69..1cb0c6b 100644 --- a/chrome/browser/net/network_stats.cc +++ b/chrome/browser/net/network_stats.cc @@ -10,7 +10,6 @@ #include "base/metrics/field_trial.h" #include "base/metrics/histogram.h" #include "base/stringprintf.h" -#include "base/task.h" #include "base/threading/platform_thread.h" #include "base/time.h" #include "base/tuple.h" diff --git a/chrome/browser/net/predictor.h b/chrome/browser/net/predictor.h index 2ec8dc0..db6114e 100644 --- a/chrome/browser/net/predictor.h +++ b/chrome/browser/net/predictor.h @@ -28,6 +28,7 @@ #include "base/gtest_prod_util.h" #include "base/memory/scoped_ptr.h" +#include "base/memory/weak_ptr.h" #include "chrome/browser/net/url_info.h" #include "chrome/browser/net/referrer.h" #include "chrome/common/net/predictor_common.h" diff --git a/chrome/browser/net/referrer.h b/chrome/browser/net/referrer.h index ff6a26f..7a76419 100644 --- a/chrome/browser/net/referrer.h +++ b/chrome/browser/net/referrer.h @@ -19,7 +19,6 @@ #include <map> #include "base/basictypes.h" -#include "base/task.h" #include "base/time.h" #include "googleurl/src/gurl.h" #include "net/base/host_port_pair.h" diff --git a/chrome/browser/net/sdch_dictionary_fetcher.h b/chrome/browser/net/sdch_dictionary_fetcher.h index 0eaa0b9..b96368f 100644 --- a/chrome/browser/net/sdch_dictionary_fetcher.h +++ b/chrome/browser/net/sdch_dictionary_fetcher.h @@ -15,7 +15,7 @@ #include <string> #include "base/memory/scoped_ptr.h" -#include "base/task.h" +#include "base/memory/weak_ptr.h" #include "base/threading/non_thread_safe.h" #include "content/public/common/url_fetcher_delegate.h" #include "net/base/sdch_manager.h" diff --git a/chrome/browser/oom_priority_manager.h b/chrome/browser/oom_priority_manager.h index 0872712..5bff732 100644 --- a/chrome/browser/oom_priority_manager.h +++ b/chrome/browser/oom_priority_manager.h @@ -14,7 +14,6 @@ #include "base/process.h" #include "base/string16.h" #include "base/synchronization/lock.h" -#include "base/task.h" #include "base/time.h" #include "base/timer.h" #include "content/public/browser/notification_observer.h" diff --git a/chrome/browser/password_manager/password_store_mac.cc b/chrome/browser/password_manager/password_store_mac.cc index 1cdc148..f1980ef 100644 --- a/chrome/browser/password_manager/password_store_mac.cc +++ b/chrome/browser/password_manager/password_store_mac.cc @@ -10,12 +10,12 @@ #include <string> #include <vector> +#include "base/callback.h" #include "base/logging.h" #include "base/mac/mac_util.h" #include "base/message_loop.h" #include "base/stl_util.h" #include "base/string_util.h" -#include "base/task.h" #include "base/utf_string_conversions.h" #include "chrome/browser/keychain_mac.h" #include "chrome/browser/password_manager/login_database.h" diff --git a/chrome/browser/platform_util_chromeos.cc b/chrome/browser/platform_util_chromeos.cc index de0bac4..e8a76ef 100644 --- a/chrome/browser/platform_util_chromeos.cc +++ b/chrome/browser/platform_util_chromeos.cc @@ -5,8 +5,8 @@ #include "chrome/browser/platform_util.h" #include "base/bind.h" +#include "base/callback.h" #include "base/file_util.h" -#include "base/task.h" #include "base/utf_string_conversions.h" #include "chrome/browser/extensions/file_manager_util.h" #include "chrome/browser/tabs/tab_strip_model.h" diff --git a/chrome/browser/prerender/prerender_contents.cc b/chrome/browser/prerender/prerender_contents.cc index c0f1f31..81e7d35 100644 --- a/chrome/browser/prerender/prerender_contents.cc +++ b/chrome/browser/prerender/prerender_contents.cc @@ -8,7 +8,6 @@ #include <utility> #include "base/process_util.h" -#include "base/task.h" #include "base/utf_string_conversions.h" #include "chrome/browser/history/history_tab_helper.h" #include "chrome/browser/history/history_types.h" diff --git a/chrome/browser/prerender/prerender_manager.h b/chrome/browser/prerender/prerender_manager.h index e823f9b..3a3ec35 100644 --- a/chrome/browser/prerender/prerender_manager.h +++ b/chrome/browser/prerender/prerender_manager.h @@ -14,7 +14,6 @@ #include "base/memory/scoped_ptr.h" #include "base/memory/scoped_vector.h" #include "base/memory/weak_ptr.h" -#include "base/task.h" #include "base/threading/non_thread_safe.h" #include "base/time.h" #include "base/timer.h" diff --git a/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h b/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h index 18c8259..13c0053 100644 --- a/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h +++ b/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h @@ -9,9 +9,9 @@ #include <string> #include "base/basictypes.h" +#include "base/callback_forward.h" #include "base/memory/weak_ptr.h" #include "base/observer_list.h" -#include "base/task.h" #include "chrome/browser/prefs/pref_change_registrar.h" #include "chrome/browser/printing/cloud_print/cloud_print_setup_handler.h" #include "chrome/browser/profiles/profile_keyed_service.h" diff --git a/chrome/browser/printing/print_job_worker.h b/chrome/browser/printing/print_job_worker.h index cfbae62..fee682d 100644 --- a/chrome/browser/printing/print_job_worker.h +++ b/chrome/browser/printing/print_job_worker.h @@ -9,7 +9,6 @@ #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" -#include "base/task.h" #include "base/threading/thread.h" #include "printing/page_number.h" #include "printing/printing_context.h" diff --git a/chrome/browser/printing/print_system_task_proxy.h b/chrome/browser/printing/print_system_task_proxy.h index 420ffd8..8d9c5767 100644 --- a/chrome/browser/printing/print_system_task_proxy.h +++ b/chrome/browser/printing/print_system_task_proxy.h @@ -11,6 +11,7 @@ #include "base/gtest_prod_util.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" +#include "base/memory/weak_ptr.h" #include "base/message_loop_helpers.h" #include "build/build_config.h" #include "content/public/browser/browser_thread.h" diff --git a/chrome/browser/safe_browsing/browser_feature_extractor.cc b/chrome/browser/safe_browsing/browser_feature_extractor.cc index 4c694c4..4c11126 100644 --- a/chrome/browser/safe_browsing/browser_feature_extractor.cc +++ b/chrome/browser/safe_browsing/browser_feature_extractor.cc @@ -12,7 +12,6 @@ #include "base/format_macros.h" #include "base/stl_util.h" #include "base/stringprintf.h" -#include "base/task.h" #include "base/time.h" #include "chrome/browser/cancelable_request.h" #include "chrome/browser/history/history.h" diff --git a/chrome/browser/safe_browsing/client_side_detection_service.cc b/chrome/browser/safe_browsing/client_side_detection_service.cc index 05d6dd81..0af1ab4 100644 --- a/chrome/browser/safe_browsing/client_side_detection_service.cc +++ b/chrome/browser/safe_browsing/client_side_detection_service.cc @@ -12,8 +12,6 @@ #include "base/metrics/histogram.h" #include "base/stl_util.h" #include "base/string_util.h" -#include "base/task.h" -#include "base/time.h" #include "base/time.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/prefs/pref_service.h" diff --git a/chrome/browser/safe_browsing/client_side_detection_service.h b/chrome/browser/safe_browsing/client_side_detection_service.h index 03a3b05..83ae62a 100644 --- a/chrome/browser/safe_browsing/client_side_detection_service.h +++ b/chrome/browser/safe_browsing/client_side_detection_service.h @@ -22,11 +22,12 @@ #include <vector> #include "base/basictypes.h" +#include "base/callback_forward.h" #include "base/gtest_prod_util.h" #include "base/memory/linked_ptr.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" -#include "base/task.h" +#include "base/memory/weak_ptr.h" #include "base/time.h" #include "content/public/common/url_fetcher_delegate.h" #include "content/public/browser/notification_observer.h" diff --git a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc index 56dc133..e17de28 100644 --- a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc +++ b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc @@ -11,7 +11,6 @@ #include "base/logging.h" #include "base/memory/scoped_ptr.h" #include "base/message_loop.h" -#include "base/task.h" #include "base/time.h" #include "chrome/browser/safe_browsing/client_side_detection_service.h" #include "chrome/common/safe_browsing/client_model.pb.h" diff --git a/chrome/browser/safe_browsing/protocol_manager.cc b/chrome/browser/safe_browsing/protocol_manager.cc index d157f8c..669c85c 100644 --- a/chrome/browser/safe_browsing/protocol_manager.cc +++ b/chrome/browser/safe_browsing/protocol_manager.cc @@ -15,7 +15,6 @@ #include "base/stl_util.h" #include "base/string_util.h" #include "base/stringprintf.h" -#include "base/task.h" #include "base/timer.h" #include "chrome/browser/safe_browsing/protocol_parser.h" #include "chrome/browser/safe_browsing/safe_browsing_service.h" diff --git a/chrome/browser/safe_browsing/safe_browsing_database.h b/chrome/browser/safe_browsing/safe_browsing_database.h index e254190..37aefe7 100644 --- a/chrome/browser/safe_browsing/safe_browsing_database.h +++ b/chrome/browser/safe_browsing/safe_browsing_database.h @@ -12,8 +12,8 @@ #include "base/file_path.h" #include "base/gtest_prod_util.h" #include "base/memory/scoped_ptr.h" +#include "base/memory/weak_ptr.h" #include "base/synchronization/lock.h" -#include "base/task.h" #include "chrome/browser/safe_browsing/safe_browsing_store.h" namespace base { diff --git a/chrome/browser/search_engines/search_host_to_urls_map.cc b/chrome/browser/search_engines/search_host_to_urls_map.cc index cb91724..af8257e 100644 --- a/chrome/browser/search_engines/search_host_to_urls_map.cc +++ b/chrome/browser/search_engines/search_host_to_urls_map.cc @@ -5,7 +5,6 @@ #include "chrome/browser/search_engines/search_host_to_urls_map.h" #include "base/memory/scoped_ptr.h" -#include "base/task.h" #include "chrome/browser/search_engines/template_url.h" #include "chrome/browser/search_engines/template_url_service.h" diff --git a/chrome/browser/service/service_process_control.h b/chrome/browser/service/service_process_control.h index 51929da..8da4956 100644 --- a/chrome/browser/service/service_process_control.h +++ b/chrome/browser/service/service_process_control.h @@ -16,7 +16,6 @@ #include "base/memory/scoped_ptr.h" #include "base/memory/singleton.h" #include "base/process.h" -#include "base/task.h" #include "content/public/browser/notification_observer.h" #include "content/public/browser/notification_registrar.h" #include "ipc/ipc_channel_proxy.h" diff --git a/chrome/browser/shell_integration_linux.cc b/chrome/browser/shell_integration_linux.cc index 4ec3e02..d74cf87 100644 --- a/chrome/browser/shell_integration_linux.cc +++ b/chrome/browser/shell_integration_linux.cc @@ -27,7 +27,6 @@ #include "base/scoped_temp_dir.h" #include "base/string_number_conversions.h" #include "base/string_tokenizer.h" -#include "base/task.h" #include "base/threading/thread.h" #include "base/utf_string_conversions.h" #include "build/build_config.h" diff --git a/chrome/browser/sync/profile_sync_components_factory.h b/chrome/browser/sync/profile_sync_components_factory.h index ed4e91d..6779b7e 100644 --- a/chrome/browser/sync/profile_sync_components_factory.h +++ b/chrome/browser/sync/profile_sync_components_factory.h @@ -8,6 +8,7 @@ #include <string> +#include "base/memory/weak_ptr.h" #include "chrome/browser/sync/glue/data_type_controller.h" #include "chrome/browser/sync/internal_api/includes/unrecoverable_error_handler.h" diff --git a/chrome/browser/ui/certificate_dialogs.cc b/chrome/browser/ui/certificate_dialogs.cc index 406b48c..0b12590 100644 --- a/chrome/browser/ui/certificate_dialogs.cc +++ b/chrome/browser/ui/certificate_dialogs.cc @@ -12,7 +12,6 @@ #include "base/file_util.h" #include "base/logging.h" #include "base/memory/scoped_ptr.h" -#include "base/task.h" #include "chrome/common/net/x509_certificate_model.h" #include "content/public/browser/browser_thread.h" #include "grit/generated_resources.h" diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm index 07618585..ea45d80 100644 --- a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm +++ b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm @@ -5,7 +5,6 @@ #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu.h" #include "base/sys_string_conversions.h" -#include "base/task.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/extension_tab_util.h" #include "chrome/browser/extensions/extension_uninstall_dialog.h" diff --git a/chrome/browser/ui/fullscreen_controller.h b/chrome/browser/ui/fullscreen_controller.h index de86677..4a6a48a 100644 --- a/chrome/browser/ui/fullscreen_controller.h +++ b/chrome/browser/ui/fullscreen_controller.h @@ -8,7 +8,6 @@ #include "base/basictypes.h" #include "base/memory/ref_counted.h" -#include "base/task.h" #include "chrome/browser/ui/fullscreen_exit_bubble_type.h" #include "chrome/common/content_settings.h" diff --git a/chrome/browser/ui/gtk/back_forward_button_gtk.h b/chrome/browser/ui/gtk/back_forward_button_gtk.h index d09a71f..0063dda 100644 --- a/chrome/browser/ui/gtk/back_forward_button_gtk.h +++ b/chrome/browser/ui/gtk/back_forward_button_gtk.h @@ -9,7 +9,6 @@ #include "base/compiler_specific.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" -#include "base/task.h" #include "chrome/browser/ui/gtk/custom_button.h" #include "chrome/browser/ui/gtk/menu_gtk.h" #include "ui/base/gtk/gtk_signal.h" diff --git a/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.h b/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.h index d34742a..fd69535 100644 --- a/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.h +++ b/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.h @@ -20,7 +20,6 @@ #include "base/compiler_specific.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" -#include "base/task.h" #include "chrome/browser/ui/gtk/bubble/bubble_gtk.h" #include "content/public/browser/notification_observer.h" #include "content/public/browser/notification_registrar.h" diff --git a/chrome/browser/ui/gtk/browser_window_gtk.cc b/chrome/browser/ui/gtk/browser_window_gtk.cc index 98a68d1..8ce9b47 100644 --- a/chrome/browser/ui/gtk/browser_window_gtk.cc +++ b/chrome/browser/ui/gtk/browser_window_gtk.cc @@ -22,7 +22,6 @@ #include "base/nix/xdg_util.h" #include "base/path_service.h" #include "base/string_util.h" -#include "base/task.h" #include "base/time.h" #include "base/utf_string_conversions.h" #include "chrome/app/chrome_command_ids.h" @@ -1581,7 +1580,7 @@ void BrowserWindowGtk::OnMainWindowDestroy(GtkWidget* widget) { // We don't want to use DeleteSoon() here since it won't work on a nested pump // (like in UI tests). MessageLoop::current()->PostTask( - FROM_HERE, base::Bind(&DeletePointer<BrowserWindowGtk>, this)); + FROM_HERE, base::Bind(&base::DeletePointer<BrowserWindowGtk>, this)); } void BrowserWindowGtk::UnMaximize() { diff --git a/chrome/browser/ui/gtk/constrained_window_gtk.h b/chrome/browser/ui/gtk/constrained_window_gtk.h index 49eb7bc..d0d456f 100644 --- a/chrome/browser/ui/gtk/constrained_window_gtk.h +++ b/chrome/browser/ui/gtk/constrained_window_gtk.h @@ -11,7 +11,6 @@ #include "base/basictypes.h" #include "base/compiler_specific.h" #include "base/memory/weak_ptr.h" -#include "base/task.h" #include "chrome/browser/ui/constrained_window.h" #include "ui/base/gtk/gtk_signal.h" #include "ui/base/gtk/owned_widget_gtk.h" diff --git a/chrome/browser/ui/gtk/extensions/extension_popup_gtk.h b/chrome/browser/ui/gtk/extensions/extension_popup_gtk.h index 4cb5a30..462fcc6 100644 --- a/chrome/browser/ui/gtk/extensions/extension_popup_gtk.h +++ b/chrome/browser/ui/gtk/extensions/extension_popup_gtk.h @@ -9,7 +9,6 @@ #include "base/compiler_specific.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" -#include "base/task.h" #include "chrome/browser/ui/gtk/bubble/bubble_gtk.h" #include "chrome/browser/ui/gtk/extensions/extension_view_gtk.h" #include "content/public/browser/notification_observer.h" diff --git a/chrome/browser/ui/gtk/tabs/dragged_view_gtk.h b/chrome/browser/ui/gtk/tabs/dragged_view_gtk.h index 7e8c195..ffa2b76 100644 --- a/chrome/browser/ui/gtk/tabs/dragged_view_gtk.h +++ b/chrome/browser/ui/gtk/tabs/dragged_view_gtk.h @@ -9,9 +9,9 @@ #include <gtk/gtk.h> #include <vector> +#include "base/callback.h" #include "base/compiler_specific.h" #include "base/memory/scoped_ptr.h" -#include "base/task.h" #include "ui/base/animation/animation_delegate.h" #include "ui/base/animation/slide_animation.h" #include "ui/base/gtk/gtk_signal.h" diff --git a/chrome/browser/ui/gtk/tabs/tab_strip_gtk.h b/chrome/browser/ui/gtk/tabs/tab_strip_gtk.h index fb72d5d..2795b24 100644 --- a/chrome/browser/ui/gtk/tabs/tab_strip_gtk.h +++ b/chrome/browser/ui/gtk/tabs/tab_strip_gtk.h @@ -13,7 +13,6 @@ #include "base/compiler_specific.h" #include "base/memory/weak_ptr.h" #include "base/message_loop.h" -#include "base/task.h" #include "chrome/browser/tabs/tab_strip_model.h" #include "chrome/browser/ui/gtk/tabs/tab_gtk.h" #include "chrome/browser/ui/gtk/tabstrip_origin_provider.h" diff --git a/chrome/browser/ui/panels/base_panel_browser_test.h b/chrome/browser/ui/panels/base_panel_browser_test.h index 641660e..9a08681 100644 --- a/chrome/browser/ui/panels/base_panel_browser_test.h +++ b/chrome/browser/ui/panels/base_panel_browser_test.h @@ -6,7 +6,6 @@ #define CHROME_BROWSER_UI_PANELS_BASE_PANEL_BROWSER_TEST_H_ #pragma once -#include "base/task.h" #include "base/values.h" #include "base/memory/scoped_ptr.h" #include "chrome/browser/ui/panels/auto_hiding_desktop_bar.h" diff --git a/chrome/browser/ui/tabs/dock_info_gtk.cc b/chrome/browser/ui/tabs/dock_info_gtk.cc index 07c14c1..09b8888 100644 --- a/chrome/browser/ui/tabs/dock_info_gtk.cc +++ b/chrome/browser/ui/tabs/dock_info_gtk.cc @@ -7,7 +7,6 @@ #include <gtk/gtk.h> #include "base/logging.h" -#include "base/task.h" #include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/gtk/browser_window_gtk.h" diff --git a/chrome/browser/ui/views/accessibility_event_router_views.h b/chrome/browser/ui/views/accessibility_event_router_views.h index 88fced0..04e519a 100644 --- a/chrome/browser/ui/views/accessibility_event_router_views.h +++ b/chrome/browser/ui/views/accessibility_event_router_views.h @@ -12,7 +12,6 @@ #include "base/gtest_prod_util.h" #include "base/memory/singleton.h" #include "base/string16.h" -#include "base/task.h" #include "chrome/browser/accessibility/accessibility_events.h" #include "ui/base/accessibility/accessibility_types.h" diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.h b/chrome/browser/ui/views/location_bar/location_bar_view.h index d7ade8e..c2c14ac 100644 --- a/chrome/browser/ui/views/location_bar/location_bar_view.h +++ b/chrome/browser/ui/views/location_bar/location_bar_view.h @@ -10,7 +10,6 @@ #include <vector> #include "base/compiler_specific.h" -#include "base/task.h" #include "chrome/browser/autocomplete/autocomplete_edit.h" #include "chrome/browser/extensions/extension_context_menu_model.h" #include "chrome/browser/first_run/first_run.h" diff --git a/chrome/browser/ui/views/login_view.h b/chrome/browser/ui/views/login_view.h index cb50699..8c152d1 100644 --- a/chrome/browser/ui/views/login_view.h +++ b/chrome/browser/ui/views/login_view.h @@ -6,7 +6,6 @@ #define CHROME_BROWSER_UI_VIEWS_LOGIN_VIEW_H_ #pragma once -#include "base/task.h" #include "chrome/browser/ui/login/login_model.h" #include "ui/views/view.h" diff --git a/chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc b/chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc index a104b37..44e39ee 100644 --- a/chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc +++ b/chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc @@ -11,7 +11,6 @@ #include "base/bind.h" #include "base/file_path.h" #include "base/message_loop.h" -#include "base/task.h" #include "base/threading/platform_thread.h" #include "base/threading/thread.h" #include "base/utf_string_conversions.h" diff --git a/chrome/browser/ui/webui/chrome_url_data_manager_backend.h b/chrome/browser/ui/webui/chrome_url_data_manager_backend.h index 765f90e..c9271de 100644 --- a/chrome/browser/ui/webui/chrome_url_data_manager_backend.h +++ b/chrome/browser/ui/webui/chrome_url_data_manager_backend.h @@ -12,7 +12,6 @@ #include "base/basictypes.h" #include "base/compiler_specific.h" -#include "base/task.h" #include "chrome/browser/ui/webui/chrome_url_data_manager.h" #include "net/url_request/url_request_job_factory.h" diff --git a/chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc b/chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc index 083a687..f2cd398 100644 --- a/chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc +++ b/chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc @@ -119,9 +119,8 @@ WebUIHandlerTaskProxy::~WebUIHandlerTaskProxy() { } void WebUIHandlerTaskProxy::DeleteOnUIThread() { - BrowserThread::PostTask( - BrowserThread::UI, FROM_HERE, - base::Bind(&WebUIHandlerTaskProxy::DoNothing, this)); + BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, + base::Bind(&base::DoNothing)); } //////////////////////////////////////////////////////////////////////////////// diff --git a/chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.cc b/chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.cc index 4691162..f5493b9 100644 --- a/chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.cc +++ b/chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.cc @@ -7,7 +7,6 @@ #include "base/bind.h" #include "base/path_service.h" #include "base/string_util.h" -#include "base/task.h" #include "chrome/browser/profiles/profile.h" #include "chrome/common/chrome_paths.h" #include "content/browser/download/download_types.h" diff --git a/chrome/browser/ui/webui/chromeos/imageburner/webui_handler.h b/chrome/browser/ui/webui/chromeos/imageburner/webui_handler.h index 972ed9d5..dc8d061 100644 --- a/chrome/browser/ui/webui/chromeos/imageburner/webui_handler.h +++ b/chrome/browser/ui/webui/chromeos/imageburner/webui_handler.h @@ -9,6 +9,7 @@ #include <string> #include "base/file_path.h" +#include "base/memory/weak_ptr.h" #include "base/string16.h" #include "base/values.h" #include "chrome/browser/chromeos/cros/burn_library.h" @@ -59,8 +60,6 @@ class WebUIHandlerTaskProxy // we need to post back to the UI thread for destruction. void DeleteOnUIThread(); - void DoNothing() {} - private: base::WeakPtr<Delegate> delegate_; diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc index c8922ec..ef86fb1 100644 --- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc +++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc @@ -9,7 +9,6 @@ #include "base/command_line.h" #include "base/hash_tables.h" #include "base/logging.h" -#include "base/task.h" #include "base/values.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/browser_shutdown.h" diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h index bb49f7e..18caf44 100644 --- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h +++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h @@ -10,7 +10,6 @@ #include "base/memory/ref_counted.h" #include "base/memory/weak_ptr.h" -#include "base/task.h" #include "chrome/browser/browsing_data_remover.h" #include "chrome/browser/chromeos/login/help_app_launcher.h" #include "chrome/browser/chromeos/login/user_manager.h" diff --git a/chrome/browser/ui/webui/extensions/extension_icon_source.cc b/chrome/browser/ui/webui/extensions/extension_icon_source.cc index 2078414b..ddc6ee1 100644 --- a/chrome/browser/ui/webui/extensions/extension_icon_source.cc +++ b/chrome/browser/ui/webui/extensions/extension_icon_source.cc @@ -12,7 +12,6 @@ #include "base/string_split.h" #include "base/string_util.h" #include "base/stringprintf.h" -#include "base/task.h" #include "base/threading/thread.h" #include "chrome/browser/extensions/extension_prefs.h" #include "chrome/browser/extensions/extension_service.h" diff --git a/chrome/browser/ui/webui/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview_handler.cc index 44bb85d..02befb6 100644 --- a/chrome/browser/ui/webui/print_preview_handler.cc +++ b/chrome/browser/ui/webui/print_preview_handler.cc @@ -189,8 +189,9 @@ void ReportPrintSettingsStats(const DictionaryValue& settings) { void PrintToPdfCallback(Metafile* metafile, const FilePath& path) { metafile->SaveTo(path); // |metafile| must be deleted on the UI thread. - BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, - base::Bind(&DeletePointer<Metafile>, metafile)); + BrowserThread::PostTask( + BrowserThread::UI, FROM_HERE, + base::Bind(&base::DeletePointer<Metafile>, metafile)); } } // namespace diff --git a/chrome/browser/ui/webui/screenshot_source.cc b/chrome/browser/ui/webui/screenshot_source.cc index 97338da..4a55a1d 100644 --- a/chrome/browser/ui/webui/screenshot_source.cc +++ b/chrome/browser/ui/webui/screenshot_source.cc @@ -10,7 +10,6 @@ #include "base/memory/ref_counted_memory.h" #include "base/message_loop.h" #include "base/path_service.h" -#include "base/task.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/url_constants.h" diff --git a/chrome/browser/ui/webui/sync_internals_ui.cc b/chrome/browser/ui/webui/sync_internals_ui.cc index 79229a3..d90e632 100644 --- a/chrome/browser/ui/webui/sync_internals_ui.cc +++ b/chrome/browser/ui/webui/sync_internals_ui.cc @@ -9,7 +9,6 @@ #include "base/logging.h" #include "base/memory/ref_counted.h" -#include "base/task.h" #include "base/tracked_objects.h" #include "base/values.h" #include "chrome/browser/profiles/profile.h" diff --git a/chrome/common/important_file_writer.cc b/chrome/common/important_file_writer.cc index 7c1f0b1..6a76dfb 100644 --- a/chrome/common/important_file_writer.cc +++ b/chrome/common/important_file_writer.cc @@ -15,7 +15,6 @@ #include "base/message_loop_proxy.h" #include "base/metrics/histogram.h" #include "base/string_number_conversions.h" -#include "base/task.h" #include "base/threading/thread.h" #include "base/time.h" diff --git a/chrome/common/net/gaia/gaia_oauth_client.cc b/chrome/common/net/gaia/gaia_oauth_client.cc index 0e4a745..6d8b1b0 100644 --- a/chrome/common/net/gaia/gaia_oauth_client.cc +++ b/chrome/common/net/gaia/gaia_oauth_client.cc @@ -5,6 +5,7 @@ #include "chrome/common/net/gaia/gaia_oauth_client.h" #include "base/json/json_reader.h" +#include "base/logging.h" #include "base/memory/scoped_ptr.h" #include "base/values.h" #include "chrome/common/net/http_return.h" diff --git a/chrome/common/service_process_util_win.cc b/chrome/common/service_process_util_win.cc index cccb7a9..d06989b 100644 --- a/chrome/common/service_process_util_win.cc +++ b/chrome/common/service_process_util_win.cc @@ -4,13 +4,13 @@ #include "chrome/common/service_process_util.h" +#include "base/callback.h" #include "base/command_line.h" #include "base/file_util.h" #include "base/logging.h" #include "base/memory/scoped_ptr.h" #include "base/path_service.h" #include "base/string16.h" -#include "base/task.h" #include "base/utf_string_conversions.h" #include "base/win/object_watcher.h" #include "base/win/scoped_handle.h" diff --git a/chrome/common/worker_thread_ticker.cc b/chrome/common/worker_thread_ticker.cc index 3616c15..391f0a3 100644 --- a/chrome/common/worker_thread_ticker.cc +++ b/chrome/common/worker_thread_ticker.cc @@ -10,7 +10,6 @@ #include "base/bind_helpers.h" #include "base/logging.h" #include "base/message_loop.h" -#include "base/task.h" #include "base/threading/thread.h" WorkerThreadTicker::WorkerThreadTicker(int tick_interval) diff --git a/chrome/renderer/net/renderer_net_predictor.h b/chrome/renderer/net/renderer_net_predictor.h index 71f5223..9499cf7 100644 --- a/chrome/renderer/net/renderer_net_predictor.h +++ b/chrome/renderer/net/renderer_net_predictor.h @@ -27,7 +27,6 @@ #include "base/basictypes.h" #include "base/memory/weak_ptr.h" -#include "base/task.h" #include "chrome/renderer/net/predictor_queue.h" class RendererNetPredictor { diff --git a/chrome/renderer/renderer_histogram_snapshots.h b/chrome/renderer/renderer_histogram_snapshots.h index 5fe8ad6..0f5628e 100644 --- a/chrome/renderer/renderer_histogram_snapshots.h +++ b/chrome/renderer/renderer_histogram_snapshots.h @@ -14,7 +14,6 @@ #include "base/memory/weak_ptr.h" #include "base/metrics/histogram.h" #include "base/process.h" -#include "base/task.h" #include "chrome/common/metrics_helpers.h" #include "content/public/renderer/render_process_observer.h" diff --git a/chrome/renderer/safe_browsing/malware_dom_details.h b/chrome/renderer/safe_browsing/malware_dom_details.h index a464cec..4bbcbb6 100644 --- a/chrome/renderer/safe_browsing/malware_dom_details.h +++ b/chrome/renderer/safe_browsing/malware_dom_details.h @@ -14,7 +14,6 @@ #include "base/basictypes.h" #include "base/memory/scoped_ptr.h" -#include "base/task.h" #include "content/public/renderer/render_view_observer.h" namespace WebKit { diff --git a/chrome/renderer/safe_browsing/phishing_classifier.h b/chrome/renderer/safe_browsing/phishing_classifier.h index 557bf29..2a8a9f9 100644 --- a/chrome/renderer/safe_browsing/phishing_classifier.h +++ b/chrome/renderer/safe_browsing/phishing_classifier.h @@ -19,9 +19,10 @@ #define CHROME_RENDERER_SAFE_BROWSING_PHISHING_CLASSIFIER_H_ #include "base/basictypes.h" +#include "base/callback.h" #include "base/memory/scoped_ptr.h" +#include "base/memory/weak_ptr.h" #include "base/string16.h" -#include "base/task.h" namespace content { class RenderView; diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h index 8d83fb6..f553b48 100644 --- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h +++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h @@ -15,7 +15,7 @@ #include "base/basictypes.h" #include "base/callback.h" #include "base/memory/scoped_ptr.h" -#include "base/task.h" +#include "base/memory/weak_ptr.h" #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h" class GURL; diff --git a/chrome/renderer/safe_browsing/phishing_term_feature_extractor.h b/chrome/renderer/safe_browsing/phishing_term_feature_extractor.h index fbd9238..5e9bce5 100644 --- a/chrome/renderer/safe_browsing/phishing_term_feature_extractor.h +++ b/chrome/renderer/safe_browsing/phishing_term_feature_extractor.h @@ -23,9 +23,9 @@ #include "base/hash_tables.h" #include "base/memory/mru_cache.h" #include "base/memory/scoped_ptr.h" +#include "base/memory/weak_ptr.h" #include "base/string_piece.h" #include "base/string16.h" -#include "base/task.h" namespace safe_browsing { class FeatureExtractorClock; diff --git a/chrome/service/cloud_print/cloud_print_helpers.cc b/chrome/service/cloud_print/cloud_print_helpers.cc index 311f69c..603d741 100644 --- a/chrome/service/cloud_print/cloud_print_helpers.cc +++ b/chrome/service/cloud_print/cloud_print_helpers.cc @@ -10,7 +10,6 @@ #include "base/rand_util.h" #include "base/string_util.h" #include "base/stringprintf.h" -#include "base/task.h" #include "base/utf_string_conversions.h" #include "base/values.h" #include "chrome/service/cloud_print/cloud_print_consts.h" diff --git a/chrome/service/cloud_print/print_system_cups.cc b/chrome/service/cloud_print/print_system_cups.cc index 41485d3..1371a0b 100644 --- a/chrome/service/cloud_print/print_system_cups.cc +++ b/chrome/service/cloud_print/print_system_cups.cc @@ -23,7 +23,6 @@ #include "base/rand_util.h" #include "base/string_number_conversions.h" #include "base/string_util.h" -#include "base/task.h" #include "base/utf_string_conversions.h" #include "base/values.h" #include "chrome/service/cloud_print/cloud_print_consts.h" diff --git a/chrome/service/service_utility_process_host.h b/chrome/service/service_utility_process_host.h index a0bef70..0b91776 100644 --- a/chrome/service/service_utility_process_host.h +++ b/chrome/service/service_utility_process_host.h @@ -16,7 +16,6 @@ #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/process.h" -#include "base/task.h" #include "ipc/ipc_channel.h" #include "content/public/common/child_process_host_delegate.h" #include "printing/pdf_render_settings.h" diff --git a/chrome/test/webdriver/webdriver_automation.h b/chrome/test/webdriver/webdriver_automation.h index 861f53a..73ac2c6 100644 --- a/chrome/test/webdriver/webdriver_automation.h +++ b/chrome/test/webdriver/webdriver_automation.h @@ -13,7 +13,6 @@ #include "base/file_path.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" -#include "base/task.h" #include "chrome/common/automation_constants.h" #include "chrome/test/webdriver/webdriver_logging.h" #include "ui/base/keycodes/keyboard_codes.h" diff --git a/chrome/test/webdriver/webdriver_key_converter.cc b/chrome/test/webdriver/webdriver_key_converter.cc index ef71693..0ac9aa6 100644 --- a/chrome/test/webdriver/webdriver_key_converter.cc +++ b/chrome/test/webdriver/webdriver_key_converter.cc @@ -5,6 +5,7 @@ #include "chrome/test/webdriver/webdriver_key_converter.h" #include "base/format_macros.h" +#include "base/logging.h" #include "base/stringprintf.h" #include "base/utf_string_conversions.h" #include "chrome/common/automation_constants.h" |