Add dataType=string to <select> elements with 'pref' attribute, if missing.

dataType has been required for <select pref=...> since
http://src.chromium.org/viewvc/chrome?view=rev&revision=71284

BUG=to be filed
TEST=confirmed that the punctuation style setting worked for mozc.
also confirmed that all <select> elements with 'pref' attribute have dataType:
% perl -n0e 's/(<select[^>]*pref.*?>)/print "$ARGV:$1\n"/gse' *.html > all_select_prefs
% perl -n0e 's/(<select[^>]*dataType.*?>)/print "$ARGV:$1\n"/gse' *.html > select_prefs_with_datatype
% diff all_select_prefs select_prefs_with_datatype

Review URL: http://codereview.chromium.org/6286002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71625 0039d316-1c4b-4281-b951-d872f2087c98

5 files changed, 18 insertions, 0 deletions

diff --git a/chrome/browser/resources/options/chromeos_language_chewing_options.html b/chrome/browser/resources/options/chromeos_language_chewing_options.html
index dd11a85..810ecc8 100644
--- a/chrome/browser/resources/options/chromeos_language_chewing_options.html
+++ b/chrome/browser/resources/options/chromeos_language_chewing_options.html
@@ -97,6 +97,7 @@
          <td class="option-value">
            <select id="chewing-cand-per-page" class="control"
                 pref="settings.language.chewing_cand_per_page"
+                dataType="string"
                 i18n-options="Chewing_candPerPageValue"></select>
          </td>
        </tr>
@@ -105,6 +106,7 @@
          <td class="option-value">
            <select id="chewing-keyboard-type" class="control"
                 pref="settings.language.chewing_keyboard_type"
+                dataType="string"
                 i18n-options="Chewing_KBTypeValue"></select>
          </td>
        </tr>
@@ -113,6 +115,7 @@
          <td class="option-value">
            <select id="chewing-sel-keys" class="control"
                 pref="settings.language.chewing_sel_keys"
+                dataType="string"
                 i18n-options="Chewing_selKeysValue"></select>
          </td>
        </tr>
@@ -121,6 +124,7 @@
          <td class="option-value">
            <select id="chewing-sel-key-type" class="control"
                 pref="settings.language.chewing_hsu_sel_key_type"
+                dataType="string"
                 i18n-options="Chewing_hsuSelKeyTypeValue"></select>
          </td>
        </tr>
diff --git a/chrome/browser/resources/options/chromeos_language_customize_modifier_keys_overlay.html b/chrome/browser/resources/options/chromeos_language_customize_modifier_keys_overlay.html
index af29a3a9..abdf6e9 100644
--- a/chrome/browser/resources/options/chromeos_language_customize_modifier_keys_overlay.html
+++ b/chrome/browser/resources/options/chromeos_language_customize_modifier_keys_overlay.html
@@ -6,6 +6,7 @@
          <td class="option-value">
            <select id="xkb-remap-search-key-to" class="control"
                 pref="settings.language.xkb_remap_search_key_to"
+                dataType="string"
                 i18n-options="xkbRemapSearchKeyToValue"></select>
          </td>
        </tr>
@@ -15,6 +16,7 @@
          <td class="option-value">
            <select id="xkb-remap-control-key-to" class="control"
                 pref="settings.language.xkb_remap_control_key_to"
+                dataType="string"
                 i18n-options="xkbRemapControlKeyToValue"></select>
          </td>
        </tr>
@@ -23,6 +25,7 @@
          <td class="option-value">
            <select id="xkb-remap-alt-key-to" class="control"
                 pref="settings.language.xkb_remap_alt_key_to"
+                dataType="string"
                 i18n-options="xkbRemapAltKeyToValue"></select>
          </td>
        </tr>
diff --git a/chrome/browser/resources/options/chromeos_language_hangul_options.html b/chrome/browser/resources/options/chromeos_language_hangul_options.html
index 7746a7b..6bda90d 100644
--- a/chrome/browser/resources/options/chromeos_language_hangul_options.html
+++ b/chrome/browser/resources/options/chromeos_language_hangul_options.html
@@ -8,6 +8,7 @@
          <td class="option-value">
            <select id="keyboard-layout-select" class="control"
                 pref="settings.language.hangul_keyboard"
+                dataType="string"
                 i18n-options="HangulkeyboardLayoutList"></select>
          </td>
        </tr>
diff --git a/chrome/browser/resources/options/chromeos_language_mozc_options.html b/chrome/browser/resources/options/chromeos_language_mozc_options.html
index 0b40fc5..2d3c6c5 100644
--- a/chrome/browser/resources/options/chromeos_language_mozc_options.html
+++ b/chrome/browser/resources/options/chromeos_language_mozc_options.html
@@ -87,6 +87,7 @@
         <td class="option-value">
           <select id="mozc-preedit-method" class="control"
               pref="settings.language.mozc_preedit_method"
+              dataType="string"
               i18n-options="mozc_preedit_methodValue"></select>
          </td>
        </tr>
@@ -95,6 +96,7 @@
          <td class="option-value">
            <select id="mozc-session-keymap" class="control"
                pref="settings.language.mozc_session_keymap"
+               dataType="string"
                i18n-options="mozc_session_keymapValue"></select>
          </td>
        </tr>
@@ -103,6 +105,7 @@
          <td class="option-value">
            <select id="mozc-punctuation-method" class="control"
                pref="settings.language.mozc_punctuation_method"
+               dataType="string"
                i18n-options="mozc_punctuation_methodValue"></select>
          </td>
        </tr>
@@ -111,6 +114,7 @@
          <td class="option-value">
            <select id="mozc-symbol-method" class="control"
                pref="settings.language.mozc_symbol_method"
+               dataType="string"
                i18n-options="mozc_symbol_methodValue"></select>
          </td>
        </tr>
@@ -120,6 +124,7 @@
          <td class="option-value">
            <select id="mozc-space-character-form" class="control"
                pref="settings.language.mozc_space_character_form"
+               dataType="string"
                i18n-options="mozc_space_character_formValue"></select>
          </td>
        </tr>
@@ -129,6 +134,7 @@
          <td class="option-value">
            <select id="mozc-history-learning-level" class="control"
                pref="settings.language.mozc_history_learning_level"
+               dataType="string"
                i18n-options="mozc_history_learning_levelValue"></select>
          </td>
        </tr>
@@ -138,6 +144,7 @@
          <td class="option-value">
            <select id="mozc-shift-key-mode-switch" class="control"
                pref="settings.language.mozc_shift_key_mode_switch"
+               dataType="string"
                i18n-options="mozc_shift_key_mode_switchValue"></select>
          </td>
        </tr>
@@ -147,6 +154,7 @@
          <td class="option-value">
            <select id="mozc-numpad-character-form" class="control"
                pref="settings.language.mozc_numpad_character_form"
+               dataType="string"
                i18n-options="mozc_numpad_character_formValue"></select>
          </td>
        </tr>
@@ -156,6 +164,7 @@
          <td class="option-value">
            <select id="mozc-suggestions-size" class="control"
                pref="settings.language.mozc_suggestions_size"
+               dataType="string"
                i18n-options="mozc_suggestions_sizeValue"></select>
          </td>
        </tr>
diff --git a/chrome/browser/resources/options/chromeos_language_pinyin_options.html b/chrome/browser/resources/options/chromeos_language_pinyin_options.html
index 8b0e68c..d99f82b 100644
--- a/chrome/browser/resources/options/chromeos_language_pinyin_options.html
+++ b/chrome/browser/resources/options/chromeos_language_pinyin_options.html
@@ -118,6 +118,7 @@
         <td class="option-value">
           <select id="pinyin-double-pinyin-schema" class="control"
               pref="settings.language.pinyin_double_pinyin_schema"
+              dataType="string"
               i18n-options="PinyinDoublePinyinSchemaValue"></select>
         </td>
       </tr>