diff options
| author | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-23 01:46:34 +0000 |
|---|---|---|
| committer | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-23 01:46:34 +0000 |
| commit | 385274cba62f80f7cf49d25002aaeeb361ad9e32 (patch) | |
| tree | 1aea5c20704f329599b9b46ea55ef3643963cf9e /chrome | |
| parent | 3f58f48df2a4c7c36ec8ee9e8388b85777797f14 (diff) | |
| download | chromium_src-385274cba62f80f7cf49d25002aaeeb361ad9e32.zip chromium_src-385274cba62f80f7cf49d25002aaeeb361ad9e32.tar.gz chromium_src-385274cba62f80f7cf49d25002aaeeb361ad9e32.tar.bz2 | |
Build fix: ipc_tests.exe is not getting built for Windows release.
(Broke in r21342)
<jamesr> agl: chromium XP release builder builds chrome.sln and then tries to
run ipc_tests.exe. nothing in chrome.gyp depends on ipc_tests now so the
executable doesn't exist on that builder
<jamesr> agl/jrg: adding a dependency on ../ipc/ipc.gyp:ipc_tests to the
'coverage' target would solve both issues
<jrg> jamesr: agl's change will only impact the coverage bots. Sounds like
that't not what you want, right?
<jamesr> jrg: i think it's correct but won't resolve the chromium XP issue.
coverage should run for those tests either way
<agl> jamesr: how about I tie it to unit_tests?
<agl> jamesr: there's a long term solution and then there's getting the builder
green.
<jamesr> agl: yeah. trying to check super fast if getting that builder to not
run ipc_tests.exe is easy
http://codereview.chromium.org/155977
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21369 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/chrome.gyp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index f2e2941..58ca846 100644 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -3603,6 +3603,9 @@ 'utility', '../app/app.gyp:app_resources', '../ipc/ipc.gyp:ipc', + # TODO(jamesr): this is required for the release builders to build + # ipc_tests.exe. However, it's probably not what we really want. + '../ipc/ipc.gyp:ipc_tests', '../net/net.gyp:net_resources', '../net/net.gyp:net_test_support', '../printing/printing.gyp:printing', @@ -5085,6 +5088,7 @@ # E.g. build/{linux|mac}/chrome_linux.croc 'dependencies': [ '../base/base.gyp:base_unittests', + '../ipc/ipc.gyp:ipc_tests', '../media/media.gyp:media_unittests', '../net/net.gyp:net_unittests', '../printing/printing.gyp:printing_unittests', |