diff options
author | sail@chromium.org <sail@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-05 19:33:21 +0000 |
---|---|---|
committer | sail@chromium.org <sail@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-05 19:33:21 +0000 |
commit | a24462be2d634b7304d1ea6c372e6b94aa2c8fa3 (patch) | |
tree | 1f880b4f11037fdcb76dbc6fba5bae2b9da6c08a /chrome | |
parent | f27cd9b16306a24ed1818d32348ae305273a8610 (diff) | |
download | chromium_src-a24462be2d634b7304d1ea6c372e6b94aa2c8fa3.zip chromium_src-a24462be2d634b7304d1ea6c372e6b94aa2c8fa3.tar.gz chromium_src-a24462be2d634b7304d1ea6c372e6b94aa2c8fa3.tar.bz2 |
Mac: Don't skip words when user clicks ignore in the spelling panel
Clicking Ignore in the spelling panel would skip misspelled words.
The problem was that the Chromium code and the spell checker were both advancing to the next word. This caused us to advance twice instead of once.
Fix was to simply remove the Chromium code that was advancing to the next word.
BUG=68557
TEST=Downloaded version 9.0.597.19 of Google Chrome and verified that the bug existed on both 10.5 and 10.6. Applied my patch and verified that pressing ignore worked correctly on both 10.5 and 10.6.
Review URL: http://codereview.chromium.org/6103001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70532 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r-- | chrome/browser/renderer_host/render_widget_host_view_mac.mm | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/chrome/browser/renderer_host/render_widget_host_view_mac.mm b/chrome/browser/renderer_host/render_widget_host_view_mac.mm index 14b4d82..7c803a7 100644 --- a/chrome/browser/renderer_host/render_widget_host_view_mac.mm +++ b/chrome/browser/renderer_host/render_widget_host_view_mac.mm @@ -2074,14 +2074,8 @@ void RenderWidgetHostViewMac::SetTextInputActive(bool active) { // SpellCheckerPlatform::CheckSpelling remembers the last tag and // SpellCheckerPlatform::IgnoreWord assumes that is the correct tag. NSString* wordToIgnore = [sender stringValue]; - if (wordToIgnore != nil) { + if (wordToIgnore != nil) SpellCheckerPlatform::IgnoreWord(base::SysNSStringToUTF16(wordToIgnore)); - - // Strangely, the spellingPanel doesn't send checkSpelling after a word is - // ignored, so we have to explicitly call AdvanceToNextMisspelling here. - RenderWidgetHostViewMac* thisHostView = [self renderWidgetHostViewMac]; - thisHostView->GetRenderWidgetHost()->AdvanceToNextMisspelling(); - } } - (void)showGuessPanel:(id)sender { |