diff options
| author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-02 20:51:50 +0000 |
|---|---|---|
| committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-02 20:51:50 +0000 |
| commit | d824a60fc2e91cd195c9722d6557a8038cf19503 (patch) | |
| tree | 28412dce56116106c24d4ef3bdbe743be7cd171e /chrome | |
| parent | 6ea309f8db3cadf7abcb2a11ea45c91320b6255b (diff) | |
| download | chromium_src-d824a60fc2e91cd195c9722d6557a8038cf19503.zip chromium_src-d824a60fc2e91cd195c9722d6557a8038cf19503.tar.gz chromium_src-d824a60fc2e91cd195c9722d6557a8038cf19503.tar.bz2 | |
Make plugin descriptions, etc. in chrome://plugins display as LTR.
Otherwise parentheses, periods, etc. look wrong with RTL languages.
Note that for RTL languages, tables should still be layed out right-to-left (and
cells should be aligned to the right).
BUG=34306
TEST=Set your language to your favourite RTL language. Go to chrome://plugins/. Everything should look correct. Expand Details -- everything should look correct. Everything should still look correct in LTR languages as well.
Review URL: http://codereview.chromium.org/1593010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43518 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/resources/plugins.html | 23 |
1 files changed, 9 insertions, 14 deletions
diff --git a/chrome/browser/resources/plugins.html b/chrome/browser/resources/plugins.html index 95fea0e..e621ef5 100644 --- a/chrome/browser/resources/plugins.html +++ b/chrome/browser/resources/plugins.html @@ -412,13 +412,6 @@ function shouldDisplayPluginDescription(plugin) { plugin.description != plugin.name + ' ' + plugin.version; } -/** - * Formats a file extension for display. - */ -function formatFileExtension(ext) { - return '.' + ext; -} - // Unfortunately, we don't have notifications for plugin (list) status changes // (yet), so in the meanwhile just update regularly. setInterval(requestPluginsData, 30000); @@ -479,11 +472,11 @@ document.addEventListener('DOMContentLoaded', requestPluginsData); <td valign="top"> <div class="plugin-text"> <div> - <span class="plugin-name" + <span class="plugin-name" dir="ltr" jscontent="name">PLUGIN NAME</span> <span jsdisplay="shouldDisplayPluginVersion($this)"> - <span i18n-content="pluginVersion">VERSION</span> - <span jscontent="version">x.x.x.x</span> + <span dir="ltr" jscontent="version">x.x.x.x</span> </span> <span jsdisplay="!enabled" i18n-content="pluginDisabled">(DISABLED)</span> @@ -492,12 +485,12 @@ document.addEventListener('DOMContentLoaded', requestPluginsData); <div><table><tr jsdisplay="shouldDisplayPluginDescription($this)"> <td class="plugin-details-label" i18n-content="pluginDescription">DESCRIPTION:</td> - <td jsvalues=".innerHTML:description"></td> + <td><span dir="ltr" jsvalues=".innerHTML:description"></td> </tr></table></div> <div><table><tr> <td class="plugin-details-label" i18n-content="pluginPath">PATH:</td> - <td jscontent="path"></td> + <td><span dir="ltr" jscontent="path"></span></td> </tr></table></div> <div class="showInTmiMode"> <table><tr jsdisplay="mimeTypes.length > 0"> @@ -513,12 +506,14 @@ document.addEventListener('DOMContentLoaded', requestPluginsData); >FILE_EXTENSIONS</td> </tr> <tr jsselect="mimeTypes"> - <td jscontent="mimeType"></td> - <td jsvalues=".innerHTML:description"></td> + <td><span dir="ltr" + jscontent="mimeType"></span></td> + <td><span dir="ltr" + jsvalues=".innerHTML:description"></span></td> <td><table jsdisplay="fileExtensions.length > 0" class="hlisting"> <tr><td jsselect="fileExtensions"> - <span jscontent="formatFileExtension($this)"></span> + <span dir="ltr" jscontent="'.' + $this"> </td></tr> </table></td> </tr> |