diff options
| author | isherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-25 23:07:44 +0000 |
|---|---|---|
| committer | isherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-25 23:07:44 +0000 |
| commit | e5938e5d95c60035d7d8694789f33b64bfe0176b (patch) | |
| tree | 0fa8be243396b89d2098ac2e6a65696485941d14 /chrome | |
| parent | 2b5efe32f302a340b98a136f0ace39b9a08f6e70 (diff) | |
| download | chromium_src-e5938e5d95c60035d7d8694789f33b64bfe0176b.zip chromium_src-e5938e5d95c60035d7d8694789f33b64bfe0176b.tar.gz chromium_src-e5938e5d95c60035d7d8694789f33b64bfe0176b.tar.bz2 | |
Remove setSuggestedValue() hack in autofill.
To work around a WebKit bug, we were calling setSuggestedValue() immediately before setValue() to get the update to happen even when the element does not lose focus. This does not seem to be necessary anymore, so getting rid of it.
BUG=56081
TEST=manual inspection; if verifying, please check on all platforms
Review URL: http://codereview.chromium.org/3979010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63797 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/renderer/autofill_helper.cc | 3 | ||||
| -rw-r--r-- | chrome/renderer/form_manager.cc | 6 |
2 files changed, 0 insertions, 9 deletions
diff --git a/chrome/renderer/autofill_helper.cc b/chrome/renderer/autofill_helper.cc index 6ecd866..33ae926 100644 --- a/chrome/renderer/autofill_helper.cc +++ b/chrome/renderer/autofill_helper.cc @@ -178,11 +178,8 @@ void AutoFillHelper::DidAcceptAutoFillSuggestion(const WebNode& node, // User selected an Autocomplete entry, so we fill directly. WebInputElement element = node.toConst<WebInputElement>(); - // Set the suggested value to update input element value immediately in UI. - // The |setValue| call has update delayed until element loses focus. string16 substring = value; substring = substring.substr(0, element.maxLength()); - element.setSuggestedValue(substring); element.setValue(substring); WebFrame* webframe = node.document().frame(); diff --git a/chrome/renderer/form_manager.cc b/chrome/renderer/form_manager.cc index 851eea4..446cbc9 100644 --- a/chrome/renderer/form_manager.cc +++ b/chrome/renderer/form_manager.cc @@ -810,12 +810,6 @@ void FormManager::FillFormField(WebFormControlElement* field, // If the maxlength attribute contains a negative value, maxLength() // returns the default maxlength value. - // TODO(dhollowa): The call here to |setSuggestedValue| is a work-around - // to a WebKit change in r67122. See http://crbug.com/56081 for details. - // Once the core issue is fixed in WebKit, this work-around should be - // removed. - input_element.setSuggestedValue( - data->value().substr(0, input_element.maxLength())); input_element.setValue(data->value().substr(0, input_element.maxLength())); input_element.setAutofilled(true); } else if (field->formControlType() == WebString::fromUTF8("select-one")) { |