summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authordhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-12 00:15:58 +0000
committerdhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-12 00:15:58 +0000
commit1b1eecda2907942e1db3492ac2e599a0da8b2437 (patch)
tree2829e0ac1ed84cb43d0d556b0170fa0c4365d599 /chrome
parent614f9b9e89c8c638cd9dd60bf42096985eebb45e (diff)
downloadchromium_src-1b1eecda2907942e1db3492ac2e599a0da8b2437.zip
chromium_src-1b1eecda2907942e1db3492ac2e599a0da8b2437.tar.gz
chromium_src-1b1eecda2907942e1db3492ac2e599a0da8b2437.tar.bz2
Autocomplete doesn't honor maxlength attribute.
When filling Autocomplete suggestions limit the filling of the suggestion to the maxlength attribute of the filled element. BUG=46899 TEST=Manual test as per bug steps. Review URL: http://codereview.chromium.org/3179005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55814 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/renderer/autofill_helper.cc6
1 files changed, 4 insertions, 2 deletions
diff --git a/chrome/renderer/autofill_helper.cc b/chrome/renderer/autofill_helper.cc
index c1f5e65..5eb1641 100644
--- a/chrome/renderer/autofill_helper.cc
+++ b/chrome/renderer/autofill_helper.cc
@@ -170,8 +170,10 @@ void AutoFillHelper::DidAcceptAutoFillSuggestion(const WebNode& node,
// Set the suggested value to update input element value immediately in UI.
// The |setValue| call has update delayed until element loses focus.
- element.setSuggestedValue(value);
- element.setValue(value);
+ string16 substring = value;
+ substring = substring.substr(0, element.maxLength());
+ element.setSuggestedValue(substring);
+ element.setValue(substring);
WebFrame* webframe = node.document().frame();
if (webframe)