In path_utils and platform_utils, we had four functions: - TestListPlatformName() - TestListPlatformDir() - PlatformDir() - PlatformNewResultsDir() TestListPlatformDir() was uniformly implemented as TestListPlatformName().lower(), and never called. PlatformDir() and PlatformNewResultsDir() returned the same value on win and linux - "chromium-" + TestListPlatformDir(). On the mac, PlatformDir() returned PlatformNewResultsDir() + "-leopard". PlatformDir() is used to prepend the directory in the search path for test results, and this is ironic since there is no chromium-mac-leopard directory, just chromium-mac. I have replaced all of these with one routine called PlatformDir() that returns "chromium-" + <platform name> [ + "-" + <platform version name> ]. I also modified the code so that test results will always go into a directory with that name, and then modified all of the files that referenced a _new_results_dir (which ostensibly used PlatformNewResultsDir(), which might be different from options.platform, but in practice never was). I also removed a number of platform parameters from functions, since it seemed like that functionality wasn't being used and was redundant with stuff stuffed into options contexts. Lastly, I also attempted to bring some consistency to files needing to import path_utils vs platform_utils, by adding wrapper functions to path_utils and then banning platform_utils imports from all other files. There's gotta be a cleaner way to do this, though. You can still change the platform you're comparing to with the --platform switch, and change the results directory with the --results-directory switch. BUG=none R=pam@chromium.org,tony@chromium.org TEST=none Review URL: http://codereview.chromium.org/164372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23924 0039d316-1c4b-4281-b951-d872f2087c98