diff options
| author | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-27 15:58:49 +0000 |
|---|---|---|
| committer | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-27 15:58:49 +0000 |
| commit | 4909c5712b88aadc1a6533b2a17036d3c83805b2 (patch) | |
| tree | 7ac91a99a47243d0122c701410c6af2b76c7d5b3 /chrome | |
| parent | c3b35c2100dba30c517116bc9a5a4e4149c3a8e5 (diff) | |
| download | chromium_src-4909c5712b88aadc1a6533b2a17036d3c83805b2.zip chromium_src-4909c5712b88aadc1a6533b2a17036d3c83805b2.tar.gz chromium_src-4909c5712b88aadc1a6533b2a17036d3c83805b2.tar.bz2 | |
Enabling test I wrote for Find to catch crash described in issue 1341577.
Review URL: http://codereview.chromium.org/5018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2659 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/find_in_page_controller_uitest.cc | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/chrome/browser/find_in_page_controller_uitest.cc b/chrome/browser/find_in_page_controller_uitest.cc index 852248b..01e2f0f 100644 --- a/chrome/browser/find_in_page_controller_uitest.cc +++ b/chrome/browser/find_in_page_controller_uitest.cc @@ -84,7 +84,7 @@ TEST_F(FindInPageControllerTest, FindUnSelectableText) { } // Try to reproduce the crash seen in issue 1341577. -TEST_F(FindInPageControllerTest, DISABLED_FindCrash_Issue1341577) { +TEST_F(FindInPageControllerTest, FindCrash_Issue1341577) { TestServer server(L"chrome/test/data"); GURL url = server.TestServerPageW(kCrashPage); @@ -96,7 +96,10 @@ TEST_F(FindInPageControllerTest, DISABLED_FindCrash_Issue1341577) { // against the frame, otherwise an active frame pointer is set and it wont // produce the crash. EXPECT_EQ(1, tab->FindInPage(L"\u0D4C", FWD, IGNORE_CASE, false)); - EXPECT_EQ(1, tab->FindInPage(L"\u0D4C", FWD, IGNORE_CASE, true)); // FindNext + // FindNext returns -1 for match count because it doesn't bother with + // recounting the number of matches. We don't care about the match count + // anyway in this case, we just want to make sure it doesn't crash. + EXPECT_EQ(-1, tab->FindInPage(L"\u0D4C", FWD, IGNORE_CASE, true)); // This should work fine. EXPECT_EQ(1, tab->FindInPage(L"\u0D24\u0D46", FWD, IGNORE_CASE, false)); |