summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authordominich@chromium.org <dominich@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-02 15:01:21 +0000
committerdominich@chromium.org <dominich@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-02 15:01:21 +0000
commit58609aee1bcc733af2addbfb9b7a88e2b7dd9461 (patch)
tree6191ae7bf6bdfe2d1c20ba789e76db63fd2e4baa /chrome
parent7f75d5f79684bf2a2a9e6b2855bdb9ab9da06da7 (diff)
downloadchromium_src-58609aee1bcc733af2addbfb9b7a88e2b7dd9461.zip
chromium_src-58609aee1bcc733af2addbfb9b7a88e2b7dd9461.tar.gz
chromium_src-58609aee1bcc733af2addbfb9b7a88e2b7dd9461.tar.bz2
Track recommended actions for all UMA users.
BUG=None TEST=None Review URL: http://codereview.chromium.org/7830023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99367 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/browser/autocomplete/autocomplete_edit.cc23
1 files changed, 13 insertions, 10 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_edit.cc b/chrome/browser/autocomplete/autocomplete_edit.cc
index 99bc515..97e7d0c 100644
--- a/chrome/browser/autocomplete/autocomplete_edit.cc
+++ b/chrome/browser/autocomplete/autocomplete_edit.cc
@@ -209,19 +209,22 @@ bool AutocompleteEditModel::AcceptCurrentInstantPreview() {
void AutocompleteEditModel::OnChanged() {
const AutocompleteMatch current_match = CurrentMatch();
string16 suggested_text;
+
+ // Confer with the NetworkActionPredictor to determine what action, if any,
+ // we should take. Get the recommended action here even if we don't need it
+ // so we can get stats for anyone who is opted in to UMA.
+ NetworkActionPredictor::Action recommended_action =
+ network_action_predictor_.RecommendAction(user_text_, current_match);
+ UMA_HISTOGRAM_ENUMERATION("NetworkActionPredictor.Action", recommended_action,
+ NetworkActionPredictor::LAST_PREDICT_ACTION);
if (!DoInstant(current_match, &suggested_text)) {
- // Confer with the NetworkActionPredictor to determine what action, if any,
- // we should take.
- NetworkActionPredictor::Action action = NetworkActionPredictor::ACTION_NONE;
- if (CommandLine::ForCurrentProcess()->HasSwitch(
+ // Ignore the recommended action if the flag is not set.
+ if (!CommandLine::ForCurrentProcess()->HasSwitch(
switches::kPrerenderFromOmnibox)) {
- action = network_action_predictor_.RecommendAction(user_text_,
- current_match);
- UMA_HISTOGRAM_ENUMERATION("NetworkActionPredictor.Action", action,
- NetworkActionPredictor::LAST_PREDICT_ACTION);
+ recommended_action = NetworkActionPredictor::ACTION_NONE;
}
- switch (action) {
+ switch (recommended_action) {
case NetworkActionPredictor::ACTION_PRERENDER:
DoPrerender(current_match);
break;
@@ -231,7 +234,7 @@ void AutocompleteEditModel::OnChanged() {
case NetworkActionPredictor::ACTION_NONE:
break;
default:
- NOTREACHED() << "Unexpected predict action: " << action;
+ NOTREACHED() << "Unexpected recommended action: " << recommended_action;
break;
}