summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authordkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-19 22:57:09 +0000
committerdkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-19 22:57:09 +0000
commit73e0bbac9d097eff34726194d2095dce90f2dfa3 (patch)
treeda2f14f77ee83984118e733a231ada709432ea52 /chrome
parentcefe1497a83ce69c7da0cec320e258e6f87b3aa9 (diff)
downloadchromium_src-73e0bbac9d097eff34726194d2095dce90f2dfa3.zip
chromium_src-73e0bbac9d097eff34726194d2095dce90f2dfa3.tar.gz
chromium_src-73e0bbac9d097eff34726194d2095dce90f2dfa3.tar.bz2
Enable SSL error handling in Linux again.
Evan, could you review the change since http://codereview.chromium.org/20444 : - load temporary root cert in test_shell Thanks! Review URL: http://codereview.chromium.org/20511 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10055 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/browser/net/url_fetcher_unittest.cc11
-rw-r--r--chrome/browser/ssl/ssl_uitest.cc14
2 files changed, 5 insertions, 20 deletions
diff --git a/chrome/browser/net/url_fetcher_unittest.cc b/chrome/browser/net/url_fetcher_unittest.cc
index 6a6e3ff..6ac3614 100644
--- a/chrome/browser/net/url_fetcher_unittest.cc
+++ b/chrome/browser/net/url_fetcher_unittest.cc
@@ -105,10 +105,6 @@ class URLFetcherBadHTTPSTest : public URLFetcherTest {
const ResponseCookies& cookies,
const std::string& data);
- protected:
- FilePath GetExpiredCertPath();
- SSLTestUtil util_;
-
private:
FilePath cert_dir_;
};
@@ -300,10 +296,6 @@ void URLFetcherBadHTTPSTest::OnURLFetchComplete(
io_loop_.Quit();
}
-FilePath URLFetcherBadHTTPSTest::GetExpiredCertPath() {
- return cert_dir_.AppendASCII("expired_cert.pem");
-}
-
void URLFetcherCancelTest::CreateFetcher(const GURL& url) {
fetcher_ = new URLFetcher(url, URLFetcher::GET, this);
fetcher_->set_request_context(
@@ -436,8 +428,7 @@ TEST_F(URLFetcherBadHTTPSTest, BadHTTPSTest) {
TEST_F(URLFetcherBadHTTPSTest, DISABLED_BadHTTPSTest) {
#endif
scoped_refptr<HTTPSTestServer> server =
- HTTPSTestServer::CreateServer(util_.kHostName, util_.kBadHTTPSPort,
- kDocRoot, util_.GetExpiredCertPath().ToWStringHack());
+ HTTPSTestServer::CreateExpiredServer(kDocRoot);
ASSERT_TRUE(NULL != server.get());
CreateFetcher(GURL(server->TestServerPage("defaultresponse")));
diff --git a/chrome/browser/ssl/ssl_uitest.cc b/chrome/browser/ssl/ssl_uitest.cc
index f31d8f2..47f4753 100644
--- a/chrome/browser/ssl/ssl_uitest.cc
+++ b/chrome/browser/ssl/ssl_uitest.cc
@@ -23,7 +23,6 @@ class SSLUITest : public UITest {
protected:
SSLUITest() {
dom_automation_enabled_ = true;
- EXPECT_TRUE(util_.CheckCATrusted());
}
TabProxy* GetActiveTabProxy() {
@@ -47,18 +46,14 @@ class SSLUITest : public UITest {
}
HTTPSTestServer* GoodCertServer() {
- return HTTPSTestServer::CreateServer(util_.kHostName, util_.kOKHTTPSPort,
- kDocRoot, util_.GetOKCertPath().ToWStringHack());
+ return HTTPSTestServer::CreateGoodServer(kDocRoot);
}
HTTPSTestServer* BadCertServer() {
- return HTTPSTestServer::CreateServer(util_.kHostName, util_.kBadHTTPSPort,
- kDocRoot, util_.GetExpiredCertPath().ToWStringHack());
+ return HTTPSTestServer::CreateExpiredServer(kDocRoot);
}
protected:
- SSLTestUtil util_;
-
DISALLOW_COPY_AND_ASSIGN(SSLUITest);
};
@@ -424,8 +419,7 @@ TEST_F(SSLUITest, TestCachedMixedContents) {
TEST_F(SSLUITest, DISABLED_TestCNInvalidStickiness) {
const std::string kLocalHost = "localhost";
scoped_refptr<HTTPSTestServer> https_server =
- HTTPSTestServer::CreateServer(kLocalHost, util_.kOKHTTPSPort,
- kDocRoot, util_.GetOKCertPath().ToWStringHack());
+ HTTPSTestServer::CreateMismatchedServer(kDocRoot);
ASSERT_TRUE(NULL != https_server.get());
// First we hit the server with hostname, this generates an invalid policy
@@ -462,7 +456,7 @@ TEST_F(SSLUITest, DISABLED_TestCNInvalidStickiness) {
ASSERT_TRUE(hostname_index != std::string::npos); // Test sanity check.
std::string new_url;
new_url.append(url.spec().substr(0, hostname_index));
- new_url.append(util_.kHostName);
+ new_url.append(net::TestServerLauncher::kHostName);
new_url.append(url.spec().substr(hostname_index + kLocalHost.size()));
NavigateTab(tab.get(), GURL(new_url));