summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authoryusukes@chromium.org <yusukes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-16 06:42:48 +0000
committeryusukes@chromium.org <yusukes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-16 06:42:48 +0000
commita6dbaac4225f2fa5a170bdc657ab306390fdc439 (patch)
tree2856b792b929f5b4ffaaf93e75e47d47e30568d8 /chrome
parent027838185c65978f66af08ef5b67e5450855446d (diff)
downloadchromium_src-a6dbaac4225f2fa5a170bdc657ab306390fdc439.zip
chromium_src-a6dbaac4225f2fa5a170bdc657ab306390fdc439.tar.gz
chromium_src-a6dbaac4225f2fa5a170bdc657ab306390fdc439.tar.bz2
cros/input_method_library clean up.
- Remove unused variable kDefaultKeyboardLayout. - Fix bad indent. - Add comment to SetImeConfig(). BUG=none TEST=manually Review URL: http://codereview.chromium.org/3148014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56186 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/browser/chromeos/cros/input_method_library.cc7
-rw-r--r--chrome/browser/chromeos/cros/input_method_library.h3
2 files changed, 5 insertions, 5 deletions
diff --git a/chrome/browser/chromeos/cros/input_method_library.cc b/chrome/browser/chromeos/cros/input_method_library.cc
index d2d605a..103ea47 100644
--- a/chrome/browser/chromeos/cros/input_method_library.cc
+++ b/chrome/browser/chromeos/cros/input_method_library.cc
@@ -36,9 +36,6 @@ bool FindAndUpdateProperty(const chromeos::ImeProperty& new_prop,
return false;
}
-// The default keyboard layout.
-const char kDefaultKeyboardLayout[] = "us";
-
} // namespace
namespace chromeos {
@@ -684,8 +681,8 @@ class InputMethodLibraryStubImpl : public InputMethodLibrary {
descriptions->push_back(InputMethodDescriptor(
"xkb:gb:extd:eng", "United Kingdom - Extended - Winkeys", "gb(extd)",
"eng"));
- return descriptions;
-}
+ return descriptions;
+ }
InputMethodDescriptor previous_input_method_;
InputMethodDescriptor current_input_method_;
diff --git a/chrome/browser/chromeos/cros/input_method_library.h b/chrome/browser/chromeos/cros/input_method_library.h
index e4f45a7..2c07956 100644
--- a/chrome/browser/chromeos/cros/input_method_library.h
+++ b/chrome/browser/chromeos/cros/input_method_library.h
@@ -77,6 +77,9 @@ class InputMethodLibrary {
// the request and returns false.
// You can specify |section| and |config_name| arguments in the same way
// as GetImeConfig() above.
+ // Notice: This function might call the Observer::ActiveInputMethodsChanged()
+ // callback function immediately, before returning from the SetImeConfig
+ // function. See also http://crosbug.com/5217.
virtual bool SetImeConfig(const char* section,
const char* config_name,
const ImeConfigValue& value) = 0;