summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authortfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-02 20:27:58 +0000
committertfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-02 20:27:58 +0000
commite02b0857aef243e6179e3b4f9e0e8574ccf2f8fb (patch)
tree822d82d6a588be1abcbbb70815f65ebe16c5d58a /chrome
parentfd1355e6a71d261a6625549ddac905b95ce573f4 (diff)
downloadchromium_src-e02b0857aef243e6179e3b4f9e0e8574ccf2f8fb.zip
chromium_src-e02b0857aef243e6179e3b4f9e0e8574ccf2f8fb.tar.gz
chromium_src-e02b0857aef243e6179e3b4f9e0e8574ccf2f8fb.tar.bz2
Fix type inconsistency with StartImportingWithUI and ProfileInfo.
BUG=28153 TEST=compiles locally and trybots Review URL: http://codereview.chromium.org/4282003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64801 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/browser/cocoa/import_progress_dialog.mm2
-rw-r--r--chrome/browser/cocoa/import_settings_dialog.mm4
-rw-r--r--chrome/browser/first_run/first_run_win.cc2
-rw-r--r--chrome/browser/gtk/import_progress_dialog_gtk.cc2
-rw-r--r--chrome/browser/importer/importer.h2
-rw-r--r--chrome/browser/views/importing_progress_view.cc2
6 files changed, 6 insertions, 8 deletions
diff --git a/chrome/browser/cocoa/import_progress_dialog.mm b/chrome/browser/cocoa/import_progress_dialog.mm
index 109365b..f40ae5f 100644
--- a/chrome/browser/cocoa/import_progress_dialog.mm
+++ b/chrome/browser/cocoa/import_progress_dialog.mm
@@ -154,7 +154,7 @@ NSString* keyForImportItem(importer::ImportItem item) {
@end
void StartImportingWithUI(gfx::NativeWindow parent_window,
- int16 items,
+ uint16 items,
ImporterHost* coordinator,
const importer::ProfileInfo& source_profile,
Profile* target_profile,
diff --git a/chrome/browser/cocoa/import_settings_dialog.mm b/chrome/browser/cocoa/import_settings_dialog.mm
index a11244a..d18dec8 100644
--- a/chrome/browser/cocoa/import_settings_dialog.mm
+++ b/chrome/browser/cocoa/import_settings_dialog.mm
@@ -174,9 +174,7 @@ bool importSettingsDialogVisible = false;
const importer::ProfileInfo& sourceProfile =
importerList_.get()->GetSourceProfileInfoAt([self sourceBrowserIndex]);
uint16 items = sourceProfile.services_supported;
- // ProfileInfo.services_supported is a uint16 while the call to
- // StartImportingWithUI requires an int16.
- int16 servicesToImport = static_cast<int16>(items & [self servicesToImport]);
+ uint16 servicesToImport = items & [self servicesToImport];
if (servicesToImport) {
if (profile_) {
ImporterHost* importerHost = new ExternalProcessImporterHost;
diff --git a/chrome/browser/first_run/first_run_win.cc b/chrome/browser/first_run/first_run_win.cc
index a7f7a3c..35037d5 100644
--- a/chrome/browser/first_run/first_run_win.cc
+++ b/chrome/browser/first_run/first_run_win.cc
@@ -561,7 +561,7 @@ int FirstRun::ImportFromBrowser(Profile* profile,
StartImportingWithUI(
parent_window,
- items_to_import,
+ static_cast<uint16>(items_to_import),
importer_host,
importer_host->GetSourceProfileInfoForBrowserType(browser_type),
profile,
diff --git a/chrome/browser/gtk/import_progress_dialog_gtk.cc b/chrome/browser/gtk/import_progress_dialog_gtk.cc
index b405b13..c70561b 100644
--- a/chrome/browser/gtk/import_progress_dialog_gtk.cc
+++ b/chrome/browser/gtk/import_progress_dialog_gtk.cc
@@ -216,7 +216,7 @@ void ImportProgressDialogGtk::ShowDialog() {
void StartImportingWithUI(GtkWindow* parent,
- int16 items,
+ uint16 items,
ImporterHost* importer_host,
const ProfileInfo& browser_profile,
Profile* profile,
diff --git a/chrome/browser/importer/importer.h b/chrome/browser/importer/importer.h
index 4887138..2f034ba 100644
--- a/chrome/browser/importer/importer.h
+++ b/chrome/browser/importer/importer.h
@@ -514,7 +514,7 @@ class ImportObserver {
// if there's nothing to parent to. first_run is true if it's invoked in the
// first run UI.
void StartImportingWithUI(gfx::NativeWindow parent_window,
- int16 items,
+ uint16 items,
ImporterHost* coordinator,
const importer::ProfileInfo& source_profile,
Profile* target_profile,
diff --git a/chrome/browser/views/importing_progress_view.cc b/chrome/browser/views/importing_progress_view.cc
index f3c2627..ae3135e 100644
--- a/chrome/browser/views/importing_progress_view.cc
+++ b/chrome/browser/views/importing_progress_view.cc
@@ -290,7 +290,7 @@ void ImportingProgressView::InitControlLayout() {
// StartImportingWithUI
void StartImportingWithUI(HWND parent_window,
- int16 items,
+ uint16 items,
ImporterHost* coordinator,
const ProfileInfo& source_profile,
Profile* target_profile,