diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-23 23:33:27 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-23 23:33:27 +0000 |
| commit | e6152c2b62bf6952d4856a4685778269b36e032d (patch) | |
| tree | 539fb113f3538c53871f30f9ee4f10ee35e599e6 /chrome | |
| parent | fe30fceb9de19a4919cf299e00b944786a70b033 (diff) | |
| download | chromium_src-e6152c2b62bf6952d4856a4685778269b36e032d.zip chromium_src-e6152c2b62bf6952d4856a4685778269b36e032d.tar.gz chromium_src-e6152c2b62bf6952d4856a4685778269b36e032d.tar.bz2 | |
Makes sure we close all browsers, not just the active ones.
This fixes NOTREACHED() being hit on browser tests when a browser window that has not been activated is closed.
BUG=None
TEST=Run the browser tests. Prevent the browser test browser window from getting activation by clicking another window before the browser window becomes active.
Review URL: http://codereview.chromium.org/147045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19080 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/test/in_process_browser_test.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/chrome/test/in_process_browser_test.cc b/chrome/test/in_process_browser_test.cc index ed03bbbe..75a9c2d 100644 --- a/chrome/test/in_process_browser_test.cc +++ b/chrome/test/in_process_browser_test.cc @@ -191,9 +191,8 @@ void InProcessBrowserTest::RunTestOnMainThreadLoop() { RunTestOnMainThread(); - BrowserList::const_reverse_iterator browser = - BrowserList::begin_last_active(); - for (; browser != BrowserList::end_last_active(); ++browser) + BrowserList::const_iterator browser = BrowserList::begin(); + for (; browser != BrowserList::end(); ++browser) (*browser)->CloseAllTabs(); // Stop the HTTP server. |