diff options
author | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-24 02:34:36 +0000 |
---|---|---|
committer | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-24 02:34:36 +0000 |
commit | 871fae4b2e378d9452ff1e3f8af54ce2cc880a33 (patch) | |
tree | 960abb613d68c3b22286c306f31ee800ac290d7f /chrome | |
parent | 1592f44e4febf2d824a450e3df5f2b651f0dfc33 (diff) | |
download | chromium_src-871fae4b2e378d9452ff1e3f8af54ce2cc880a33.zip chromium_src-871fae4b2e378d9452ff1e3f8af54ce2cc880a33.tar.gz chromium_src-871fae4b2e378d9452ff1e3f8af54ce2cc880a33.tar.bz2 |
Cleanup: Fix some incorrect messages and style nits in the print preview code.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7718018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97977 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r-- | chrome/browser/printing/print_preview_message_handler.cc | 1 | ||||
-rw-r--r-- | chrome/browser/printing/print_preview_message_handler.h | 2 | ||||
-rw-r--r-- | chrome/browser/ui/webui/print_preview_handler.cc | 17 |
3 files changed, 8 insertions, 12 deletions
diff --git a/chrome/browser/printing/print_preview_message_handler.cc b/chrome/browser/printing/print_preview_message_handler.cc index 9bbc96f..a9462e9 100644 --- a/chrome/browser/printing/print_preview_message_handler.cc +++ b/chrome/browser/printing/print_preview_message_handler.cc @@ -70,7 +70,6 @@ PrintPreviewMessageHandler::~PrintPreviewMessageHandler() { } TabContents* PrintPreviewMessageHandler::GetPrintPreviewTab() { - // Get/Create preview tab for initiator tab. printing::PrintPreviewTabController* tab_controller = printing::PrintPreviewTabController::GetInstance(); if (!tab_controller) diff --git a/chrome/browser/printing/print_preview_message_handler.h b/chrome/browser/printing/print_preview_message_handler.h index 4b6fe89..52fe902 100644 --- a/chrome/browser/printing/print_preview_message_handler.h +++ b/chrome/browser/printing/print_preview_message_handler.h @@ -29,7 +29,7 @@ class PrintPreviewMessageHandler : public TabContentsObserver { virtual void DidStartLoading(); private: - // Gets the print preview tab associated with |owner_|. + // Gets the print preview tab associated with the TabContents being observed. TabContents* GetPrintPreviewTab(); // Message handlers. diff --git a/chrome/browser/ui/webui/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview_handler.cc index aa0007f..5d4aae9 100644 --- a/chrome/browser/ui/webui/print_preview_handler.cc +++ b/chrome/browser/ui/webui/print_preview_handler.cc @@ -596,12 +596,11 @@ void PrintPreviewHandler::HandlePrint(const ListValue* args) { } } -void PrintPreviewHandler::HandleHidePreview(const ListValue* args) { +void PrintPreviewHandler::HandleHidePreview(const ListValue*) { HidePreviewTab(); } -void PrintPreviewHandler::HandleCancelPendingPrintRequest( - const ListValue* args) { +void PrintPreviewHandler::HandleCancelPendingPrintRequest(const ListValue*) { TabContentsWrapper* wrapper = NULL; TabContents* initiator_tab = GetInitiatorTab(); if (initiator_tab) { @@ -619,8 +618,7 @@ void PrintPreviewHandler::HandleCancelPendingPrintRequest( delete TabContentsWrapper::GetCurrentWrapperForContents(preview_tab()); } -void PrintPreviewHandler::HandleSaveLastPrinter( - const ListValue* args) { +void PrintPreviewHandler::HandleSaveLastPrinter(const ListValue* args) { std::string data_to_save; if (args->GetString(0, &data_to_save) && !data_to_save.empty()) { if (last_used_printer_name_ == NULL) @@ -634,8 +632,7 @@ void PrintPreviewHandler::HandleSaveLastPrinter( } } -void PrintPreviewHandler::HandleGetPrinterCapabilities( - const ListValue* args) { +void PrintPreviewHandler::HandleGetPrinterCapabilities(const ListValue* args) { std::string printer_name; bool ret = args->GetString(0, &printer_name); if (!ret || printer_name.empty()) @@ -662,7 +659,7 @@ void PrintPreviewHandler::HandleManageCloudPrint(const ListValue*) { PageTransition::LINK); } -void PrintPreviewHandler::HandleShowSystemDialog(const ListValue* args) { +void PrintPreviewHandler::HandleShowSystemDialog(const ListValue*) { ReportStats(); ReportUserActionHistogram(FALLBACK_TO_ADVANCED_SETTINGS_DIALOG); @@ -677,7 +674,7 @@ void PrintPreviewHandler::HandleShowSystemDialog(const ListValue* args) { manager->PrintForSystemDialogNow(); } -void PrintPreviewHandler::HandleManagePrinters(const ListValue* args) { +void PrintPreviewHandler::HandleManagePrinters(const ListValue*) { ++manage_printers_dialog_request_count_; printing::PrinterManagerDialog::ShowPrinterManagerDialog(); } @@ -695,7 +692,7 @@ void PrintPreviewHandler::HandleReloadCrashedInitiatorTab(const ListValue*) { ActivateInitiatorTabAndClosePreviewTab(); } -void PrintPreviewHandler::HandleClosePreviewTab(const ListValue* args) { +void PrintPreviewHandler::HandleClosePreviewTab(const ListValue*) { ReportStats(); ReportUserActionHistogram(CANCEL); |