summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authorerg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-01 23:44:22 +0000
committererg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-01 23:44:22 +0000
commit3aa12530b0f3fe0ff15b017cfe8b6e0e76019532 (patch)
treec687b33b023937516f87249802e93f37261df9e8 /chrome
parent0ae49bfd7019599f83f6971a9f1800e54eede6ff (diff)
downloadchromium_src-3aa12530b0f3fe0ff15b017cfe8b6e0e76019532.zip
chromium_src-3aa12530b0f3fe0ff15b017cfe8b6e0e76019532.tar.gz
chromium_src-3aa12530b0f3fe0ff15b017cfe8b6e0e76019532.tar.bz2
Revert "FBTF: Move the TabRestoreService::Observer into its own file."
This reverts commit 4a76b908daffee441d9ebf9fbc74b4015d9145df (r58256) due to chromeos compile fail. TBR=akalin Review URL: http://codereview.chromium.org/3340007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58271 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/browser/automation/testing_automation_provider.cc1
-rw-r--r--chrome/browser/browser.cc1
-rw-r--r--chrome/browser/browser.h7
-rw-r--r--chrome/browser/cocoa/history_menu_bridge.h22
-rw-r--r--chrome/browser/cocoa/history_menu_bridge.mm17
-rw-r--r--chrome/browser/cocoa/view_id_util_browsertest.mm1
-rw-r--r--chrome/browser/dom_ui/new_tab_ui.cc5
-rw-r--r--chrome/browser/download/download_manager.cc1
-rw-r--r--chrome/browser/extensions/execute_code_in_tab_function.cc1
-rw-r--r--chrome/browser/extensions/extension_context_menu_browsertest.cc1
-rw-r--r--chrome/browser/extensions/extension_management_api.cc1
-rw-r--r--chrome/browser/extensions/extension_proxy_apitest.cc1
-rw-r--r--chrome/browser/jumplist_win.h5
-rw-r--r--chrome/browser/sessions/session_backend.cc4
-rw-r--r--chrome/browser/sessions/session_backend.h7
-rw-r--r--chrome/browser/sessions/session_types.cc56
-rw-r--r--chrome/browser/sessions/session_types.h25
-rw-r--r--chrome/browser/sessions/tab_restore_service.cc11
-rw-r--r--chrome/browser/sessions/tab_restore_service.h22
-rw-r--r--chrome/browser/sessions/tab_restore_service_observer.h25
-rw-r--r--chrome/browser/views/location_bar/location_bar_view.cc1
21 files changed, 64 insertions, 151 deletions
diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc
index b5cb004..a8ef344b 100644
--- a/chrome/browser/automation/testing_automation_provider.cc
+++ b/chrome/browser/automation/testing_automation_provider.cc
@@ -30,7 +30,6 @@
#include "chrome/browser/find_bar.h"
#include "chrome/browser/location_bar.h"
#include "chrome/browser/login_prompt.h"
-#include "chrome/browser/profile.h"
#include "chrome/browser/platform_util.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/renderer_host/render_process_host.h"
diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc
index 6c4385b..9e3beea 100644
--- a/chrome/browser/browser.cc
+++ b/chrome/browser/browser.cc
@@ -70,7 +70,6 @@
#include "chrome/browser/service/service_process_control_manager.h"
#include "chrome/browser/sessions/session_service.h"
#include "chrome/browser/sessions/session_types.h"
-#include "chrome/browser/sessions/tab_restore_service.h"
#include "chrome/browser/status_bubble.h"
#include "chrome/browser/sync/profile_sync_service.h"
#include "chrome/browser/sync/sync_ui_util.h"
diff --git a/chrome/browser/browser.h b/chrome/browser/browser.h
index 3637871..e2c9c36 100644
--- a/chrome/browser/browser.h
+++ b/chrome/browser/browser.h
@@ -14,12 +14,11 @@
#include "base/basictypes.h"
#include "base/gtest_prod_util.h"
#include "base/scoped_ptr.h"
-#include "base/task.h"
#include "chrome/browser/command_updater.h"
#include "chrome/browser/debugger/devtools_toggle_action.h"
#include "chrome/browser/prefs/pref_member.h"
#include "chrome/browser/sessions/session_id.h"
-#include "chrome/browser/sessions/tab_restore_service_observer.h"
+#include "chrome/browser/sessions/tab_restore_service.h"
#include "chrome/browser/shell_dialogs.h"
#include "chrome/browser/sync/profile_sync_service_observer.h"
#include "chrome/browser/tabs/tab_strip_model.h"
@@ -51,7 +50,7 @@ class Browser : public TabStripModelDelegate,
public CommandUpdater::CommandUpdaterDelegate,
public NotificationObserver,
public SelectFileDialog::Listener,
- public TabRestoreServiceObserver,
+ public TabRestoreService::Observer,
public ProfileSyncServiceObserver {
public:
// If you change the values in this enum you'll need to update browser_proxy.
@@ -620,7 +619,7 @@ class Browser : public TabStripModelDelegate,
// Helper function to run unload listeners on a TabContents.
static bool RunUnloadEventsHelper(TabContents* contents);
- // TabRestoreServiceObserver /////////////////////////////////////////////////
+ // TabRestoreService::Observer ///////////////////////////////////////////////
virtual void TabRestoreServiceChanged(TabRestoreService* service);
virtual void TabRestoreServiceDestroyed(TabRestoreService* service);
diff --git a/chrome/browser/cocoa/history_menu_bridge.h b/chrome/browser/cocoa/history_menu_bridge.h
index 2743752..55dab4d 100644
--- a/chrome/browser/cocoa/history_menu_bridge.h
+++ b/chrome/browser/cocoa/history_menu_bridge.h
@@ -16,7 +16,6 @@
#include "chrome/browser/history/history.h"
#include "chrome/browser/sessions/session_id.h"
#include "chrome/browser/sessions/tab_restore_service.h"
-#include "chrome/browser/sessions/tab_restore_service_observer.h"
#include "chrome/common/notification_observer.h"
class NavigationEntry;
@@ -24,7 +23,6 @@ class NotificationRegistrar;
class PageUsageData;
class Profile;
class TabNavigationEntry;
-class TabRestoreService;
@class HistoryMenuCocoaController;
namespace {
@@ -56,16 +54,26 @@ class HistoryMenuBridgeTest;
// controller is very thin and only exists to interact with Cocoa, but this
// class does the bulk of the work.
class HistoryMenuBridge : public NotificationObserver,
- public TabRestoreServiceObserver {
+ public TabRestoreService::Observer {
public:
// This is a generalization of the data we store in the history menu because
// we pull things from different sources with different data types.
struct HistoryItem {
public:
- HistoryItem();
+ HistoryItem()
+ : icon_requested(false),
+ menu_item(nil),
+ session_id(0) {}
+
// Copy constructor allowed.
- HistoryItem(const HistoryItem& copy);
- ~HistoryItem();
+ HistoryItem(const HistoryItem& copy)
+ : title(copy.title),
+ url(copy.url),
+ icon_requested(false),
+ menu_item(nil),
+ session_id(copy.session_id) {}
+
+ ~HistoryItem() {}
// The title for the menu item.
string16 title;
@@ -128,7 +136,7 @@ class HistoryMenuBridge : public NotificationObserver,
const NotificationSource& source,
const NotificationDetails& details);
- // For TabRestoreServiceObserver
+ // For TabRestoreService::Observer
virtual void TabRestoreServiceChanged(TabRestoreService* service);
virtual void TabRestoreServiceDestroyed(TabRestoreService* service);
diff --git a/chrome/browser/cocoa/history_menu_bridge.mm b/chrome/browser/cocoa/history_menu_bridge.mm
index 10e1bc2..d75043e 100644
--- a/chrome/browser/cocoa/history_menu_bridge.mm
+++ b/chrome/browser/cocoa/history_menu_bridge.mm
@@ -46,23 +46,6 @@ const unsigned int kRecentlyClosedCount = 10;
} // namespace
-HistoryMenuBridge::HistoryItem::HistoryItem()
- : icon_requested(false),
- menu_item(nil),
- session_id(0) {
-}
-
-HistoryMenuBridge::HistoryItem::HistoryItem(const HistoryItem& copy)
- : title(copy.title),
- url(copy.url),
- icon_requested(false),
- menu_item(nil),
- session_id(copy.session_id) {
-}
-
-HistoryMenuBridge::HistoryItem::~HistoryItem() {
-}
-
HistoryMenuBridge::HistoryMenuBridge(Profile* profile)
: controller_([[HistoryMenuCocoaController alloc] initWithBridge:this]),
profile_(profile),
diff --git a/chrome/browser/cocoa/view_id_util_browsertest.mm b/chrome/browser/cocoa/view_id_util_browsertest.mm
index 94e3aa4..f6fa0c3 100644
--- a/chrome/browser/cocoa/view_id_util_browsertest.mm
+++ b/chrome/browser/cocoa/view_id_util_browsertest.mm
@@ -11,7 +11,6 @@
#include "chrome/browser/cocoa/view_id_util.h"
#include "chrome/browser/download/download_shelf.h"
#include "chrome/browser/prefs/pref_service.h"
-#include "chrome/browser/profile.h"
#include "chrome/browser/sidebar/sidebar_manager.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
diff --git a/chrome/browser/dom_ui/new_tab_ui.cc b/chrome/browser/dom_ui/new_tab_ui.cc
index 1183a4e..5b4d28e 100644
--- a/chrome/browser/dom_ui/new_tab_ui.cc
+++ b/chrome/browser/dom_ui/new_tab_ui.cc
@@ -32,7 +32,6 @@
#include "chrome/browser/renderer_host/render_view_host.h"
#include "chrome/browser/sessions/session_types.h"
#include "chrome/browser/sessions/tab_restore_service.h"
-#include "chrome/browser/sessions/tab_restore_service_observer.h"
#include "chrome/browser/sync/profile_sync_service.h"
#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/common/chrome_switches.h"
@@ -121,7 +120,7 @@ class PaintTimer : public RenderWidgetHost::PaintObserver {
// RecentlyClosedTabsHandler
class RecentlyClosedTabsHandler : public DOMMessageHandler,
- public TabRestoreServiceObserver {
+ public TabRestoreService::Observer {
public:
RecentlyClosedTabsHandler() : tab_restore_service_(NULL) {}
virtual ~RecentlyClosedTabsHandler();
@@ -137,7 +136,7 @@ class RecentlyClosedTabsHandler : public DOMMessageHandler,
// Callback for the "getRecentlyClosedTabs" message.
void HandleGetRecentlyClosedTabs(const ListValue* args);
- // Observer callback for TabRestoreServiceObserver. Sends data on
+ // Observer callback for TabRestoreService::Observer. Sends data on
// recently closed tabs to the javascript side of this page to
// display to the user.
virtual void TabRestoreServiceChanged(TabRestoreService* service);
diff --git a/chrome/browser/download/download_manager.cc b/chrome/browser/download/download_manager.cc
index 2283b32..266767b 100644
--- a/chrome/browser/download/download_manager.cc
+++ b/chrome/browser/download/download_manager.cc
@@ -11,7 +11,6 @@
#include "base/logging.h"
#include "base/path_service.h"
#include "base/rand_util.h"
-#include "base/stl_util-inl.h"
#include "base/sys_string_conversions.h"
#include "base/task.h"
#include "base/utf_string_conversions.h"
diff --git a/chrome/browser/extensions/execute_code_in_tab_function.cc b/chrome/browser/extensions/execute_code_in_tab_function.cc
index 52f519d..5debd9a 100644
--- a/chrome/browser/extensions/execute_code_in_tab_function.cc
+++ b/chrome/browser/extensions/execute_code_in_tab_function.cc
@@ -12,7 +12,6 @@
#include "chrome/browser/extensions/extension_tabs_module_constants.h"
#include "chrome/browser/extensions/extensions_service.h"
#include "chrome/browser/extensions/file_reader.h"
-#include "chrome/browser/profile.h"
#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_constants.h"
diff --git a/chrome/browser/extensions/extension_context_menu_browsertest.cc b/chrome/browser/extensions/extension_context_menu_browsertest.cc
index b176c57..65f0ed1 100644
--- a/chrome/browser/extensions/extension_context_menu_browsertest.cc
+++ b/chrome/browser/extensions/extension_context_menu_browsertest.cc
@@ -8,7 +8,6 @@
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/extensions/extension_test_message_listener.h"
#include "chrome/browser/extensions/extensions_service.h"
-#include "chrome/browser/profile.h"
#include "chrome/browser/tab_contents/render_view_context_menu.h"
#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/common/chrome_switches.h"
diff --git a/chrome/browser/extensions/extension_management_api.cc b/chrome/browser/extensions/extension_management_api.cc
index 27caab3..ba5eab3 100644
--- a/chrome/browser/extensions/extension_management_api.cc
+++ b/chrome/browser/extensions/extension_management_api.cc
@@ -14,7 +14,6 @@
#include "chrome/browser/extensions/extension_event_names.h"
#include "chrome/browser/extensions/extension_message_service.h"
#include "chrome/browser/extensions/extensions_service.h"
-#include "chrome/browser/profile.h"
#include "chrome/common/extensions/extension_error_utils.h"
#include "chrome/common/notification_service.h"
#include "chrome/common/notification_type.h"
diff --git a/chrome/browser/extensions/extension_proxy_apitest.cc b/chrome/browser/extensions/extension_proxy_apitest.cc
index c315bf2..4f23236 100644
--- a/chrome/browser/extensions/extension_proxy_apitest.cc
+++ b/chrome/browser/extensions/extension_proxy_apitest.cc
@@ -5,7 +5,6 @@
#include "chrome/browser/browser.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/browser/prefs/pref_service.h"
-#include "chrome/browser/profile.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/pref_names.h"
diff --git a/chrome/browser/jumplist_win.h b/chrome/browser/jumplist_win.h
index 58146d0..e85735d 100644
--- a/chrome/browser/jumplist_win.h
+++ b/chrome/browser/jumplist_win.h
@@ -15,7 +15,6 @@
#include "chrome/browser/cancelable_request.h"
#include "chrome/browser/history/history.h"
#include "chrome/browser/sessions/tab_restore_service.h"
-#include "chrome/browser/sessions/tab_restore_service_observer.h"
class FilePath;
class Profile;
@@ -92,7 +91,7 @@ typedef std::vector<scoped_refptr<ShellLinkItem> > ShellLinkItemList;
// * Creatng COM objects used by JumpList from PageUsageData objects;
// * Adding COM objects to JumpList, etc.
//
-// This class also implements TabRestoreServiceObserver. So, once we call
+// This class also implements TabRestoreService::Observer. So, once we call
// AddObserver() and register this class as an observer, it automatically
// updates a JumpList when a tab is added or removed.
//
@@ -100,7 +99,7 @@ typedef std::vector<scoped_refptr<ShellLinkItem> > ShellLinkItemList;
// update it in a UI thread. To solve this problem, this class posts a
// task when it actually updates a JumpList. (This task is implemented in an
// anomynous namespace in "jumplist_win.cc".)
-class JumpList : public TabRestoreServiceObserver {
+class JumpList : public TabRestoreService::Observer {
public:
JumpList();
~JumpList();
diff --git a/chrome/browser/sessions/session_backend.cc b/chrome/browser/sessions/session_backend.cc
index 342c1f0..c06f811 100644
--- a/chrome/browser/sessions/session_backend.cc
+++ b/chrome/browser/sessions/session_backend.cc
@@ -9,7 +9,6 @@
#include "base/file_util.h"
#include "base/histogram.h"
#include "base/scoped_vector.h"
-#include "net/base/file_stream.h"
using base::TimeTicks;
@@ -336,9 +335,6 @@ bool SessionBackend::AppendCommandsToFile(net::FileStream* file,
return true;
}
-SessionBackend::~SessionBackend() {
-}
-
void SessionBackend::ResetFile() {
DCHECK(inited_);
if (current_session_file_.get()) {
diff --git a/chrome/browser/sessions/session_backend.h b/chrome/browser/sessions/session_backend.h
index 883a58f..523ef58 100644
--- a/chrome/browser/sessions/session_backend.h
+++ b/chrome/browser/sessions/session_backend.h
@@ -12,10 +12,7 @@
#include "base/scoped_ptr.h"
#include "chrome/browser/sessions/base_session_service.h"
#include "chrome/browser/sessions/session_command.h"
-
-namespace net {
-class FileStream;
-}
+#include "net/base/file_stream.h"
// SessionBackend -------------------------------------------------------------
@@ -96,7 +93,7 @@ class SessionBackend : public base::RefCountedThreadSafe<SessionBackend> {
private:
friend class base::RefCountedThreadSafe<SessionBackend>;
- ~SessionBackend();
+ ~SessionBackend() {}
// If current_session_file_ is open, it is truncated so that it is essentially
// empty (only contains the header). If current_session_file_ isn't open, it
diff --git a/chrome/browser/sessions/session_types.cc b/chrome/browser/sessions/session_types.cc
index 995a9a2..cdf77f6 100644
--- a/chrome/browser/sessions/session_types.cc
+++ b/chrome/browser/sessions/session_types.cc
@@ -11,51 +11,6 @@
// TabNavigation --------------------------------------------------------------
-TabNavigation::TabNavigation()
- : transition_(PageTransition::TYPED),
- type_mask_(0),
- index_(-1) {
-}
-
-TabNavigation::TabNavigation(int index,
- const GURL& virtual_url,
- const GURL& referrer,
- const string16& title,
- const std::string& state,
- PageTransition::Type transition)
- : virtual_url_(virtual_url),
- referrer_(referrer),
- title_(title),
- state_(state),
- transition_(transition),
- type_mask_(0),
- index_(index) {
-}
-
-TabNavigation::TabNavigation(const TabNavigation& tab)
- : virtual_url_(tab.virtual_url_),
- referrer_(tab.referrer_),
- title_(tab.title_),
- state_(tab.state_),
- transition_(tab.transition_),
- type_mask_(tab.type_mask_),
- index_(tab.index_) {
-}
-
-TabNavigation::~TabNavigation() {
-}
-
-TabNavigation& TabNavigation::operator=(const TabNavigation& tab) {
- virtual_url_ = tab.virtual_url_;
- referrer_ = tab.referrer_;
- title_ = tab.title_;
- state_ = tab.state_;
- transition_ = tab.transition_;
- type_mask_ = tab.type_mask_;
- index_ = tab.index_;
- return *this;
-}
-
// static
NavigationEntry* TabNavigation::ToNavigationEntry(int page_id,
Profile *profile) const {
@@ -84,17 +39,6 @@ void TabNavigation::SetFromNavigationEntry(const NavigationEntry& entry) {
type_mask_ = entry.has_post_data() ? TabNavigation::HAS_POST_DATA : 0;
}
-// SessionTab -----------------------------------------------------------------
-
-SessionTab::SessionTab()
- : tab_visual_index(-1),
- current_navigation_index(-1),
- pinned(false) {
-}
-
-SessionTab::~SessionTab() {
-}
-
// SessionWindow ---------------------------------------------------------------
SessionWindow::SessionWindow()
diff --git a/chrome/browser/sessions/session_types.h b/chrome/browser/sessions/session_types.h
index 119392a..07dbae4 100644
--- a/chrome/browser/sessions/session_types.h
+++ b/chrome/browser/sessions/session_types.h
@@ -31,16 +31,25 @@ class TabNavigation {
HAS_POST_DATA = 1
};
- TabNavigation();
+ TabNavigation()
+ : transition_(PageTransition::TYPED),
+ type_mask_(0),
+ index_(-1) {
+ }
+
TabNavigation(int index,
const GURL& virtual_url,
const GURL& referrer,
const string16& title,
const std::string& state,
- PageTransition::Type transition);
- TabNavigation(const TabNavigation& tab);
- ~TabNavigation();
- TabNavigation& operator=(const TabNavigation& tab);
+ PageTransition::Type transition)
+ : virtual_url_(virtual_url),
+ referrer_(referrer),
+ title_(title),
+ state_(state),
+ transition_(transition),
+ type_mask_(0),
+ index_(index) {}
// Converts this TabNavigation into a NavigationEntry with a page id of
// |page_id|. The caller owns the returned NavigationEntry.
@@ -98,8 +107,10 @@ class TabNavigation {
// SessionTab corresponds to a NavigationController.
struct SessionTab {
- SessionTab();
- ~SessionTab();
+ SessionTab()
+ : tab_visual_index(-1),
+ current_navigation_index(-1),
+ pinned(false) { }
// Unique id of the window.
SessionID window_id;
diff --git a/chrome/browser/sessions/tab_restore_service.cc b/chrome/browser/sessions/tab_restore_service.cc
index c62312a..116f819 100644
--- a/chrome/browser/sessions/tab_restore_service.cc
+++ b/chrome/browser/sessions/tab_restore_service.cc
@@ -17,7 +17,6 @@
#include "chrome/browser/sessions/session_service.h"
#include "chrome/browser/sessions/session_command.h"
#include "chrome/browser/sessions/session_types.h"
-#include "chrome/browser/sessions/tab_restore_service_observer.h"
#include "chrome/browser/tab_contents/navigation_controller.h"
#include "chrome/browser/tab_contents/navigation_entry.h"
#include "chrome/browser/tab_contents/tab_contents.h"
@@ -183,18 +182,17 @@ TabRestoreService::~TabRestoreService() {
if (backend())
Save();
- FOR_EACH_OBSERVER(TabRestoreServiceObserver, observer_list_,
- TabRestoreServiceDestroyed(this));
+ FOR_EACH_OBSERVER(Observer, observer_list_, TabRestoreServiceDestroyed(this));
STLDeleteElements(&entries_);
STLDeleteElements(&staging_entries_);
time_factory_ = NULL;
}
-void TabRestoreService::AddObserver(TabRestoreServiceObserver* observer) {
+void TabRestoreService::AddObserver(Observer* observer) {
observer_list_.AddObserver(observer);
}
-void TabRestoreService::RemoveObserver(TabRestoreServiceObserver* observer) {
+void TabRestoreService::RemoveObserver(Observer* observer) {
observer_list_.RemoveObserver(observer);
}
@@ -486,8 +484,7 @@ void TabRestoreService::PopulateTab(Tab* tab,
}
void TabRestoreService::NotifyTabsChanged() {
- FOR_EACH_OBSERVER(TabRestoreServiceObserver, observer_list_,
- TabRestoreServiceChanged(this));
+ FOR_EACH_OBSERVER(Observer, observer_list_, TabRestoreServiceChanged(this));
}
void TabRestoreService::AddEntry(Entry* entry, bool notify, bool to_front) {
diff --git a/chrome/browser/sessions/tab_restore_service.h b/chrome/browser/sessions/tab_restore_service.h
index 2f9a237..e12b9d1 100644
--- a/chrome/browser/sessions/tab_restore_service.h
+++ b/chrome/browser/sessions/tab_restore_service.h
@@ -20,7 +20,6 @@ class Browser;
class NavigationController;
class Profile;
struct SessionWindow;
-class TabRestoreServiceObserver;
// TabRestoreService is responsible for maintaining the most recently closed
// tabs and windows. When a tab is closed
@@ -35,6 +34,21 @@ class TabRestoreServiceObserver;
// add an observer.
class TabRestoreService : public BaseSessionService {
public:
+ // Observer is notified when the set of entries managed by TabRestoreService
+ // changes in some way.
+ class Observer {
+ public:
+ // Sent when the set of entries changes in some way.
+ virtual void TabRestoreServiceChanged(TabRestoreService* service) = 0;
+
+ // Sent to all remaining Observers when TabRestoreService's
+ // destructor is run.
+ virtual void TabRestoreServiceDestroyed(TabRestoreService* service) = 0;
+
+ protected:
+ virtual ~Observer() {}
+ };
+
// Interface used to allow the test to provide a custom time.
class TimeFactory {
public:
@@ -118,8 +132,8 @@ class TabRestoreService : public BaseSessionService {
// Adds/removes an observer. TabRestoreService does not take ownership of
// the observer.
- void AddObserver(TabRestoreServiceObserver* observer);
- void RemoveObserver(TabRestoreServiceObserver* observer);
+ void AddObserver(Observer* observer);
+ void RemoveObserver(Observer* observer);
// Creates a Tab to represent |tab| and notifies observers the list of
// entries has changed.
@@ -314,7 +328,7 @@ class TabRestoreService : public BaseSessionService {
// Number of entries we've written.
int entries_written_;
- ObserverList<TabRestoreServiceObserver> observer_list_;
+ ObserverList<Observer> observer_list_;
// Set of tabs that we've received a BrowserClosing method for but no
// corresponding BrowserClosed. We cache the set of browsers closing to
diff --git a/chrome/browser/sessions/tab_restore_service_observer.h b/chrome/browser/sessions/tab_restore_service_observer.h
deleted file mode 100644
index e4d21184..0000000
--- a/chrome/browser/sessions/tab_restore_service_observer.h
+++ /dev/null
@@ -1,25 +0,0 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_SESSIONS_TAB_RESTORE_SERVICE_OBSERVER_H_
-#define CHROME_BROWSER_SESSIONS_TAB_RESTORE_SERVICE_OBSERVER_H_
-
-class TabRestoreService;
-
-// Observer is notified when the set of entries managed by TabRestoreService
-// changes in some way.
-class TabRestoreServiceObserver {
- public:
- // Sent when the set of entries changes in some way.
- virtual void TabRestoreServiceChanged(TabRestoreService* service) = 0;
-
- // Sent to all remaining Observers when TabRestoreService's
- // destructor is run.
- virtual void TabRestoreServiceDestroyed(TabRestoreService* service) = 0;
-
- protected:
- virtual ~TabRestoreServiceObserver() {}
-};
-
-#endif // CHROME_BROWSER_SESSIONS_TAB_RESTORE_SERVICE_OBSERVER_H_
diff --git a/chrome/browser/views/location_bar/location_bar_view.cc b/chrome/browser/views/location_bar/location_bar_view.cc
index 9cf40a1..97b9f2a 100644
--- a/chrome/browser/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/views/location_bar/location_bar_view.cc
@@ -12,7 +12,6 @@
#include "app/l10n_util.h"
#include "app/resource_bundle.h"
#include "app/theme_provider.h"
-#include "base/stl_util-inl.h"
#include "base/utf_string_conversions.h"
#include "chrome/app/chrome_dll_resource.h"
#include "chrome/browser/alternate_nav_url_fetcher.h"