summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authormpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-12-18 23:15:00 +0000
committermpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-12-18 23:15:00 +0000
commit3aa20fe9254d543f491b2ce22471e67a1457df71 (patch)
tree58e9259189f913248301a5bf8a431f0ef50e7941 /chrome
parent2a7eb61d12a13bb4f0ca38dd855ca072d4fe5578 (diff)
downloadchromium_src-3aa20fe9254d543f491b2ce22471e67a1457df71.zip
chromium_src-3aa20fe9254d543f491b2ce22471e67a1457df71.tar.gz
chromium_src-3aa20fe9254d543f491b2ce22471e67a1457df71.tar.bz2
Temporary fix for Google Mail Checker memory leak.
We don't have a limit on the number of console messages we hold in memory. Until we can get this bug fixed in WebKit, I'm removing the console.log statements. BUG=29919 Review URL: http://codereview.chromium.org/502081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35001 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/common/extensions/docs/examples/extensions/gmail/background.html16
-rw-r--r--chrome/common/extensions/docs/examples/extensions/gmail/manifest.json2
2 files changed, 1 insertions, 17 deletions
diff --git a/chrome/common/extensions/docs/examples/extensions/gmail/background.html b/chrome/common/extensions/docs/examples/extensions/gmail/background.html
index a897333..0a0563f 100644
--- a/chrome/common/extensions/docs/examples/extensions/gmail/background.html
+++ b/chrome/common/extensions/docs/examples/extensions/gmail/background.html
@@ -84,7 +84,6 @@ LoadingAnimation.prototype.stop = function() {
chrome.tabs.onUpdated.addListener(function(tabId, changeInfo) {
if (changeInfo.url && isGmailUrl(changeInfo.url)) {
- console.log("saw gmail! updating...");
getInboxCount(function(count) {
updateUnreadCount(count);
});
@@ -111,11 +110,6 @@ function scheduleRequest() {
pollIntervalMax);
delay = Math.round(delay);
- console.log("Scheduling request...");
- console.log(" exponent: ", exponent);
- console.log(" randomness: ", randomness);
- console.log(" delay: ", delay);
-
window.setTimeout(startRequest, delay);
}
@@ -156,14 +150,10 @@ function getInboxCount(onSuccess, onError) {
}
try {
- console.log("request..");
xhr.onreadystatechange = function(){
- console.log("readystate: " + xhr.readyState);
if (xhr.readyState != 4)
return;
- console.log("responseText: " + xhr.responseText.substring(0, 200) +
- "...");
if (xhr.responseXML) {
var xmlDoc = xhr.responseXML;
var fullCountSet = xmlDoc.evaluate("/gmail:feed/gmail:fullcount",
@@ -173,27 +163,21 @@ function getInboxCount(onSuccess, onError) {
handleSuccess(fullCountNode.textContent);
return;
} else {
- console.log("fullcount not found!");
console.error("Error: feed retrieved, but no <fullcount> node " +
"found");
}
- } else {
- console.log("No responseXML!");
}
handleError();
}
xhr.onerror = function(error) {
- console.log("error");
- console.log(error);
handleError();
}
xhr.open("GET", getFeedUrl(), true);
xhr.send(null);
} catch(e) {
- console.log("ex: " + e);
console.error("exception: " + e);
handleError();
}
diff --git a/chrome/common/extensions/docs/examples/extensions/gmail/manifest.json b/chrome/common/extensions/docs/examples/extensions/gmail/manifest.json
index fab4c55..96a7588 100644
--- a/chrome/common/extensions/docs/examples/extensions/gmail/manifest.json
+++ b/chrome/common/extensions/docs/examples/extensions/gmail/manifest.json
@@ -1,7 +1,7 @@
{
"name": "Google Mail Checker",
"description": "Displays the number of unread messages in your Google Mail inbox. You can also click the button to open your inbox.",
- "version": "2",
+ "version": "3",
"background_page": "background.html",
"options_page": "options.html",
"permissions": [