diff options
| author | tony@chromium.org <tony@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-25 23:56:18 +0000 |
|---|---|---|
| committer | tony@chromium.org <tony@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-25 23:56:18 +0000 |
| commit | 55ed730cea1cc40a3f215d42c57edfa3541ca92d (patch) | |
| tree | 6da5b4102832dd7dc4c4e1c984a3f3691ccbfec7 /chrome | |
| parent | eecae45911385c61918d94332a4447e5f5d869b2 (diff) | |
| download | chromium_src-55ed730cea1cc40a3f215d42c57edfa3541ca92d.zip chromium_src-55ed730cea1cc40a3f215d42c57edfa3541ca92d.tar.gz chromium_src-55ed730cea1cc40a3f215d42c57edfa3541ca92d.tar.bz2 | |
Fix a bug where we get an extra resize event for background tabs.
The TabContentsContainerGtk is a GtkFixed that contains a
TabContentsViewGtk for each tab. We hide the background TCVG
and only show the foreground TCVG. However, when the TCCG
gets a resize event, we were still sending a set_size_request
to all the background tabs. Since they were hidden, nothing
happened except in the case described in issue 14114. It
seems like this is a spurious resize by gtk, but not sending
the resize request seems to work around it.
BUG=14114
TEST=see bug
Review URL: http://codereview.chromium.org/246012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27297 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/gtk/tab_contents_container_gtk.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/browser/gtk/tab_contents_container_gtk.cc b/chrome/browser/gtk/tab_contents_container_gtk.cc index 3deda09..2c64dff 100644 --- a/chrome/browser/gtk/tab_contents_container_gtk.cc +++ b/chrome/browser/gtk/tab_contents_container_gtk.cc @@ -18,6 +18,8 @@ namespace { // |allocation|. void ResizeChildren(GtkWidget* widget, void* param) { GtkAllocation* allocation = reinterpret_cast<GtkAllocation*>(param); + if (!GTK_WIDGET_VISIBLE(widget)) + return; if (widget->allocation.width != allocation->width || widget->allocation.height != allocation->height) { |