diff options
author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-23 01:40:11 +0000 |
---|---|---|
committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-23 01:40:11 +0000 |
commit | 6a558a36f77d504f7fdf21c1e4d0ad63caa5909a (patch) | |
tree | 5b530d60155c03aabfff982db1476f2fdd4861e6 /chrome | |
parent | 23866704890933c1c1b6d0eb9df33695b998fb64 (diff) | |
download | chromium_src-6a558a36f77d504f7fdf21c1e4d0ad63caa5909a.zip chromium_src-6a558a36f77d504f7fdf21c1e4d0ad63caa5909a.tar.gz chromium_src-6a558a36f77d504f7fdf21c1e4d0ad63caa5909a.tar.bz2 |
Remove GetURLForDebugging().
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4071004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63614 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r-- | chrome/common/extensions/extension_localization_peer.cc | 4 | ||||
-rw-r--r-- | chrome/common/extensions/extension_localization_peer.h | 1 | ||||
-rw-r--r-- | chrome/common/extensions/extension_localization_peer_unittest.cc | 5 | ||||
-rw-r--r-- | chrome/common/resource_dispatcher_unittest.cc | 8 | ||||
-rw-r--r-- | chrome/common/security_filter_peer.cc | 4 | ||||
-rw-r--r-- | chrome/common/security_filter_peer.h | 1 | ||||
-rw-r--r-- | chrome/plugin/chrome_plugin_host.cc | 4 |
7 files changed, 0 insertions, 27 deletions
diff --git a/chrome/common/extensions/extension_localization_peer.cc b/chrome/common/extensions/extension_localization_peer.cc index 06e0317..e04bd0b 100644 --- a/chrome/common/extensions/extension_localization_peer.cc +++ b/chrome/common/extensions/extension_localization_peer.cc @@ -90,10 +90,6 @@ void ExtensionLocalizationPeer::OnCompletedRequest( original_peer_->OnCompletedRequest(status, security_info, completion_time); } -GURL ExtensionLocalizationPeer::GetURLForDebugging() const { - return original_peer_->GetURLForDebugging(); -} - void ExtensionLocalizationPeer::ReplaceMessages() { if (!message_sender_ || data_.empty()) return; diff --git a/chrome/common/extensions/extension_localization_peer.h b/chrome/common/extensions/extension_localization_peer.h index b2b7c7a..1274421 100644 --- a/chrome/common/extensions/extension_localization_peer.h +++ b/chrome/common/extensions/extension_localization_peer.h @@ -45,7 +45,6 @@ class ExtensionLocalizationPeer virtual void OnCompletedRequest(const URLRequestStatus& status, const std::string& security_info, const base::Time& completion_time); - virtual GURL GetURLForDebugging() const; private: friend class ExtensionLocalizationPeerTest; diff --git a/chrome/common/extensions/extension_localization_peer_unittest.cc b/chrome/common/extensions/extension_localization_peer_unittest.cc index bc6f73f..dc67d5b 100644 --- a/chrome/common/extensions/extension_localization_peer_unittest.cc +++ b/chrome/common/extensions/extension_localization_peer_unittest.cc @@ -72,7 +72,6 @@ class MockResourceLoaderBridgePeer const URLRequestStatus& status, const std::string& security_info, const base::Time& completion_time)); - MOCK_CONST_METHOD0(GetURLForDebugging, GURL()); private: DISALLOW_COPY_AND_ASSIGN(MockResourceLoaderBridgePeer); @@ -153,7 +152,6 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestEmptyData) { // It will self-delete once it exits OnCompletedRequest. ExtensionLocalizationPeer* filter_peer = filter_peer_.release(); - EXPECT_CALL(*original_peer_, GetURLForDebugging()).Times(0); EXPECT_CALL(*original_peer_, OnReceivedData(_, _)).Times(0); EXPECT_CALL(*sender_, Send(_)).Times(0); @@ -172,7 +170,6 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestNoCatalogs) { SetData(filter_peer, "some text"); - EXPECT_CALL(*original_peer_, GetURLForDebugging()).Times(0); EXPECT_CALL(*sender_, Send(_)); std::string data = GetData(filter_peer); @@ -208,7 +205,6 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestWithCatalogs) { SetData(filter_peer, "some __MSG_text__"); - EXPECT_CALL(*original_peer_, GetURLForDebugging()).Times(0); // We already have messages in memory, Send will be skipped. EXPECT_CALL(*sender_, Send(_)).Times(0); @@ -240,7 +236,6 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestReplaceMessagesFails) { std::string message("some __MSG_missing_message__"); SetData(filter_peer, message); - EXPECT_CALL(*original_peer_, GetURLForDebugging()).Times(0); // We already have messages in memory, Send will be skipped. EXPECT_CALL(*sender_, Send(_)).Times(0); diff --git a/chrome/common/resource_dispatcher_unittest.cc b/chrome/common/resource_dispatcher_unittest.cc index 8e31ee9..75fdb08 100644 --- a/chrome/common/resource_dispatcher_unittest.cc +++ b/chrome/common/resource_dispatcher_unittest.cc @@ -69,10 +69,6 @@ class TestRequestCallback : public ResourceLoaderBridge::Peer { complete_ = true; } - virtual GURL GetURLForDebugging() const { - return GURL(); - } - const std::string& data() const { return data_; } @@ -293,10 +289,6 @@ class DeferredResourceLoadingTest : public ResourceDispatcherTest, const base::Time& completion_time) { } - virtual GURL GetURLForDebugging() const { - return GURL(); - } - protected: virtual void SetUp() { EXPECT_EQ(true, shared_handle_.Create("DeferredResourceLoaderTest", false, diff --git a/chrome/common/security_filter_peer.cc b/chrome/common/security_filter_peer.cc index 9b0815b..6fae4d3 100644 --- a/chrome/common/security_filter_peer.cc +++ b/chrome/common/security_filter_peer.cc @@ -90,10 +90,6 @@ void SecurityFilterPeer::OnCompletedRequest(const URLRequestStatus& status, NOTREACHED(); } -GURL SecurityFilterPeer::GetURLForDebugging() const { - return original_peer_->GetURLForDebugging(); -} - // static void ProcessResponseInfo( const webkit_glue::ResourceResponseInfo& info_in, diff --git a/chrome/common/security_filter_peer.h b/chrome/common/security_filter_peer.h index 8365ebd..2559bf3 100644 --- a/chrome/common/security_filter_peer.h +++ b/chrome/common/security_filter_peer.h @@ -44,7 +44,6 @@ class SecurityFilterPeer : public webkit_glue::ResourceLoaderBridge::Peer { virtual void OnCompletedRequest(const URLRequestStatus& status, const std::string& security_info, const base::Time& completion_time); - virtual GURL GetURLForDebugging() const; protected: SecurityFilterPeer(webkit_glue::ResourceLoaderBridge* resource_loader_bridge, diff --git a/chrome/plugin/chrome_plugin_host.cc b/chrome/plugin/chrome_plugin_host.cc index e23b273..22b3da9 100644 --- a/chrome/plugin/chrome_plugin_host.cc +++ b/chrome/plugin/chrome_plugin_host.cc @@ -135,10 +135,6 @@ class PluginRequestHandlerProxy } } - virtual GURL GetURLForDebugging() const { - return GURL(cprequest_->url); - } - void set_extra_headers(const std::string& headers) { extra_headers_ = headers; } |