diff options
| author | kmadhusu@chromium.org <kmadhusu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-22 18:14:52 +0000 |
|---|---|---|
| committer | kmadhusu@chromium.org <kmadhusu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-22 18:14:52 +0000 |
| commit | b4c34808606de3f2266a05eb6b74cd1466cd41e4 (patch) | |
| tree | 05db755f5452f5c745832cc082374c795116cf6a /chrome | |
| parent | 025d744fa84358ea535ad6af5034c66fd9e4aa08 (diff) | |
| download | chromium_src-b4c34808606de3f2266a05eb6b74cd1466cd41e4.zip chromium_src-b4c34808606de3f2266a05eb6b74cd1466cd41e4.tar.gz chromium_src-b4c34808606de3f2266a05eb6b74cd1466cd41e4.tar.bz2 | |
Coverity: Fix unchecked return bugs.
CID=102553, 102548, 102547, 102521, 102470, 102469, 102467, 102458,
102402, 102378
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9008017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115557 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/plugin_finder.cc | 4 | ||||
| -rw-r--r-- | chrome/browser/printing/print_view_manager.cc | 4 | ||||
| -rw-r--r-- | chrome/browser/ui/webui/history_ui.cc | 3 |
3 files changed, 6 insertions, 5 deletions
diff --git a/chrome/browser/plugin_finder.cc b/chrome/browser/plugin_finder.cc index 59777de..9227ff8 100644 --- a/chrome/browser/plugin_finder.cc +++ b/chrome/browser/plugin_finder.cc @@ -39,7 +39,8 @@ PluginFinder::PluginFinder() { base::DictionaryValue* dict = static_cast<base::DictionaryValue*>(value.get()); base::ListValue* list = NULL; - dict->GetList("plugins", &list); + bool success = dict->GetList("plugins", &list); + DCHECK(success); plugin_list_.reset(list->DeepCopy()); } DCHECK(plugin_list_.get()); @@ -113,4 +114,3 @@ void PluginFinder::FindPlugin( } MessageLoop::current()->PostTask(FROM_HERE, not_found_callback); } - diff --git a/chrome/browser/printing/print_view_manager.cc b/chrome/browser/printing/print_view_manager.cc index 68ddc3b..4a77e50 100644 --- a/chrome/browser/printing/print_view_manager.cc +++ b/chrome/browser/printing/print_view_manager.cc @@ -123,7 +123,7 @@ bool PrintViewManager::PrintPreviewNow() { } void PrintViewManager::PrintPreviewDone() { - BrowserThread::CurrentlyOn(BrowserThread::UI); + DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); DCHECK_NE(NOT_PREVIEWING, print_preview_state_); if (print_preview_state_ == SCRIPTED_PREVIEW) { @@ -303,7 +303,7 @@ void PrintViewManager::OnScriptedPrintPreview(bool source_is_modifiable, } void PrintViewManager::OnScriptedPrintPreviewReply(IPC::Message* reply_msg) { - BrowserThread::CurrentlyOn(BrowserThread::UI); + DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); Send(reply_msg); } diff --git a/chrome/browser/ui/webui/history_ui.cc b/chrome/browser/ui/webui/history_ui.cc index a1a6845..b4ade06 100644 --- a/chrome/browser/ui/webui/history_ui.cc +++ b/chrome/browser/ui/webui/history_ui.cc @@ -170,7 +170,8 @@ void BrowsingHistoryHandler::HandleGetHistory(const ListValue* args) { // Get arguments (if any). int day = 0; - ExtractIntegerValue(args, &day); + bool res = ExtractIntegerValue(args, &day); + DCHECK(res); // Set our query options. history::QueryOptions options; |