diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-16 00:20:50 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-16 00:20:50 +0000 |
| commit | b5099fa27ed60884dbc6254bb18bfd7ad204f2de (patch) | |
| tree | 6c0bf227cca10e72c4e94f21c90ebcb4c9e7e7e2 /chrome | |
| parent | e76f29692595c652b11066cfb404ed2a8fecaf68 (diff) | |
| download | chromium_src-b5099fa27ed60884dbc6254bb18bfd7ad204f2de.zip chromium_src-b5099fa27ed60884dbc6254bb18bfd7ad204f2de.tar.gz chromium_src-b5099fa27ed60884dbc6254bb18bfd7ad204f2de.tar.bz2 | |
Escape the feed url, otherwise the web based readers such
as Googler Reader can't use it.
BUG=27696
TEST=Go to news.googlecom, click the RSS icon in the Omnibox
and subscribe with Google Reader. It should recognize the feed
url and offer to subscribe.
Review URL: http://codereview.chromium.org/385126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32036 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/test/data/extensions/subscribe_page_action/manifest.json | 2 | ||||
| -rw-r--r-- | chrome/test/data/extensions/subscribe_page_action/subscribe.js | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/chrome/test/data/extensions/subscribe_page_action/manifest.json b/chrome/test/data/extensions/subscribe_page_action/manifest.json index 533513f..b1577d2 100644 --- a/chrome/test/data/extensions/subscribe_page_action/manifest.json +++ b/chrome/test/data/extensions/subscribe_page_action/manifest.json @@ -1,7 +1,7 @@ { "name": "RSS Subscription Extension", "description": "Adds one-click subscription to your toolbar", - "version": "1.6.1", + "version": "1.6.2", "permissions": [ "tabs", "http://*/*" diff --git a/chrome/test/data/extensions/subscribe_page_action/subscribe.js b/chrome/test/data/extensions/subscribe_page_action/subscribe.js index d0a9a6c..8d9ee1c 100644 --- a/chrome/test/data/extensions/subscribe_page_action/subscribe.js +++ b/chrome/test/data/extensions/subscribe_page_action/subscribe.js @@ -41,7 +41,8 @@ var storageEnabled = window.localStorage != null; // Navigates to the reader of the user's choice (for subscribing to the feed). function navigate() { var select = document.getElementById('readerDropdown'); - var url = feedReaderList[select.selectedIndex].url.replace("%s", feedUrl); + var url = + feedReaderList[select.selectedIndex].url.replace("%s", escape(feedUrl)); document.location = url; } |